From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 715 invoked by alias); 5 May 2012 07:05:18 -0000 Received: (qmail 618 invoked by uid 22791); 5 May 2012 07:05:16 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 05 May 2012 07:05:01 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q457513p026457 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 5 May 2012 03:05:01 -0400 Received: from psique ([10.3.112.12]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q4574uMT020928; Sat, 5 May 2012 03:04:58 -0400 From: Sergio Durigan Junior To: Jan Kratochvil Cc: gdb@sourceware.org Subject: Re: Modify stap-probe.h to identify SystemTap probes References: <20120504152129.GA7418@redhat.com> <20120505060312.GA7019@host2.jankratochvil.net> <20120505062315.GA7458@host2.jankratochvil.net> <20120505065253.GA8272@host2.jankratochvil.net> X-URL: http://www.redhat.com Date: Sat, 05 May 2012 07:05:00 -0000 In-Reply-To: <20120505065253.GA8272@host2.jankratochvil.net> (Jan Kratochvil's message of "Sat, 5 May 2012 08:52:53 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00018.txt.bz2 On Saturday, May 05 2012, Jan Kratochvil wrote: > On Sat, 05 May 2012 08:41:49 +0200, Sergio Durigan Junior wrote: >> On Saturday, May 05 2012, Jan Kratochvil wrote: >> > If the current probe.h interface is insufficient then it should be extended. >> >> I agree, but that's not the case. `probe.h' is sufficient, but it is >> not its responsibility to tell if a probe foo is a SystemTap probe. > > Why cannot probe XYZ serve the task a SystemTap probe does? The name > "SystemTap" makes the probe somehow unique no other probe kind can be placed > at the same address providing the same information? Currently only SystemTap is implemented, and SystemTap userspace probes can have arguments, but this may not be true for all types of probes that will eventually be implemented. Also, and maybe most important, only SystemTap probes are used inside glibc/libgcc for this purpose, so allowing any probe type to be accepted in this case is not conceptually right IMO. If any other probe of any other type is included in glibc/libgcc for the same purpose, it is easy to allow this type of probe in the code too. -- Sergio