From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6781 invoked by alias); 5 May 2012 07:21:34 -0000 Received: (qmail 6766 invoked by uid 22791); 5 May 2012 07:21:31 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 05 May 2012 07:21:16 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q457LFYZ022118 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 5 May 2012 03:21:15 -0400 Received: from psique ([10.3.112.12]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q457LApA016444; Sat, 5 May 2012 03:21:13 -0400 From: Sergio Durigan Junior To: Jan Kratochvil Cc: gdb@sourceware.org Subject: Re: Modify stap-probe.h to identify SystemTap probes References: <20120504152129.GA7418@redhat.com> <20120505060312.GA7019@host2.jankratochvil.net> <20120505062315.GA7458@host2.jankratochvil.net> <20120505065253.GA8272@host2.jankratochvil.net> <20120505071141.GA9035@host2.jankratochvil.net> X-URL: http://www.redhat.com Date: Sat, 05 May 2012 07:21:00 -0000 In-Reply-To: <20120505071141.GA9035@host2.jankratochvil.net> (Jan Kratochvil's message of "Sat, 5 May 2012 09:11:41 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00020.txt.bz2 On Saturday, May 05 2012, Jan Kratochvil wrote: > On Sat, 05 May 2012 09:04:56 +0200, Sergio Durigan Junior wrote: >> If any other probe of any other type is included in glibc/libgcc for the >> same purpose, > > I can include any other type of probe right now into glibc/libgcc. > Even the SystemTap probe isn't upstreamed anyway. libgcc's SystemTap probes are upstreamed. http://gcc.gnu.org/ml/gcc-patches/2011-01/msg01016.html http://gcc.gnu.org/ml/gcc-patches/2011-11/msg02246.html >> it is easy to allow this type of probe in the code too. > > If you want to place exceptions into code here and there then the > virtualization really has no use and it did not have to be there. My goal was not to overcomplicate the code, nor to insert exceptions "here and there" as you say, nor to break the virtualization layer that we implemented (and I totally agreed with), but to guarantee correctness of the code. But I won't push anymore, I understand your reasons and I think it's not worth to spend more time discussing this design change. Thanks, -- Sergio