From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10241 invoked by alias); 27 Jan 2011 20:52:21 -0000 Received: (qmail 10227 invoked by uid 22791); 27 Jan 2011 20:52:20 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 27 Jan 2011 20:52:16 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p0RKq5mP015766 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 27 Jan 2011 15:52:05 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p0RKq5KG029219; Thu, 27 Jan 2011 15:52:05 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p0RKq4GN007698; Thu, 27 Jan 2011 15:52:04 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id F1B4037887A; Thu, 27 Jan 2011 13:52:03 -0700 (MST) From: Tom Tromey To: Avi Gozlan Cc: "'gdb\@sourceware.org'" , Matan Ben Gur Subject: Re: Differentiating symbols in multiple copies of shared libraries References: <9C4E85B61203CD419BB3A638E5F6833301A37EBFB20B@il-ex01.ad.checkpoint.com> <9C4E85B61203CD419BB3A638E5F6833301A393C916FA@il-ex01.ad.checkpoint.com> Date: Thu, 27 Jan 2011 20:52:00 -0000 In-Reply-To: <9C4E85B61203CD419BB3A638E5F6833301A393C916FA@il-ex01.ad.checkpoint.com> (Avi Gozlan's message of "Sun, 23 Jan 2011 14:07:21 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00112.txt.bz2 >>>>> "Avi" == Avi Gozlan writes: Avi> A developer in our organization added some code to allow Avi> differentiation between symbols with the same name in different Avi> object files. This feature is enabled once a GDB variable called Avi> symlib is set. Avi> Presumably this addition is not written according to GNU policy or Avi> GDB conventions, yet this feature is important as discussed below. Avi> Could you recommend on a procedure for promoting this required Avi> feature (or anyway merge the source code to GDB)? Is there any Avi> contact for working with for forwarding the implementation Avi> (currently diff in 4 files: minsym.c, stack.c, symtab.h, symtab.c)? I think the best thing to do is to follow the usual patch submission rules: do your best to make it conform to GNU style guidelines, write a ChangeLog entry, etc, then send it to the gdb-patches list. Since it sounds like a big(-ish) patch, I will get you started on the copyright assignment paperwork. I'll send a note off-list about this. I would warn you to expect some push-back on the details of your approach. If you want to work out the user interface details before submitting, that would be fine too -- just post your plan to this list. Tom