From: Pedro Alves <palves@redhat.com>
To: Kevin Buettner <kevinb@redhat.com>, gdb@sourceware.org
Subject: Re: Proposal: Drop GDB support for Python versions < 2.6
Date: Thu, 21 Feb 2019 17:55:00 -0000 [thread overview]
Message-ID: <fdaff511-c238-8a51-ddf6-499936ca42b9@redhat.com> (raw)
In-Reply-To: <20190220134506.13960235@f29-4.lan>
If we do this, it'd be good to go over gdb/python/python-internal.h and
remove obsolete workarounds such as:
~~~
/* The second argument to PyObject_GetAttrString was missing the 'const'
qualifier in Python-2.4. Hence, we wrap it in a function to avoid errors
when compiled with -Werror. */
static inline PyObject *
gdb_PyObject_GetAttrString (PyObject *obj,
const char *attr) /* ARI: editCase function */
{
return PyObject_GetAttrString (obj, (char *) attr);
}
#define PyObject_GetAttrString(obj, attr) gdb_PyObject_GetAttrString (obj, attr)
~~~
/* Python 2.4 doesn't include stdint.h soon enough to get {u,}intptr_t
needed by pyport.h. */
/* /usr/include/features.h on linux systems will define _POSIX_C_SOURCE
if it sees _GNU_SOURCE (which config.h will define).
pyconfig.h defines _POSIX_C_SOURCE to a different value than
/usr/include/features.h does causing compilation to fail.
To work around this, undef _POSIX_C_SOURCE before we include Python.h.
Same problem with _XOPEN_SOURCE. */
#undef _POSIX_C_SOURCE
#undef _XOPEN_SOURCE
~~~
etc.
Thanks,
Pedro Alves
prev parent reply other threads:[~2019-02-21 17:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 20:45 Kevin Buettner
2019-02-20 21:30 ` Paul Smith
2019-02-20 21:44 ` Jan Vrany
2019-02-20 21:49 ` Joel Sherrill
2019-02-20 22:05 ` Paul Smith
2019-02-20 22:11 ` Kevin Buettner
2019-02-20 23:26 ` André Pönitz
2019-02-21 6:39 ` Kevin Buettner
2019-02-21 14:40 ` Eli Zaretskii
2019-02-21 18:35 ` André Pönitz
2019-02-21 18:52 ` John Baldwin
2019-02-21 9:10 ` Dmitry Samersoff
2019-02-20 22:06 ` Paul Koning
2019-02-21 17:11 ` Tom Tromey
2019-02-20 22:58 ` André Pönitz
2019-02-21 2:39 ` Joel Brobecker
2019-02-21 3:46 ` Eli Zaretskii
2019-02-21 6:46 ` Kevin Buettner
2019-02-21 14:42 ` Eli Zaretskii
2019-02-21 10:45 ` Mark Wielaard
2019-02-21 3:40 ` Eli Zaretskii
2019-02-21 17:55 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdaff511-c238-8a51-ddf6-499936ca42b9@redhat.com \
--to=palves@redhat.com \
--cc=gdb@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox