From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qD6JOhaMh2er1g8AWB0awg (envelope-from ) for ; Wed, 15 Jan 2025 05:21:10 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=hfNas6vj; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EC49C1E100; Wed, 15 Jan 2025 05:21:10 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 727881E08E for ; Wed, 15 Jan 2025 05:21:10 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 048FA385DDCD for ; Wed, 15 Jan 2025 10:21:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 048FA385DDCD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1736936470; bh=am6RrY+6N9aA+fb9uWCYcDibZ3XqpgCWXiA56tXw+eg=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=hfNas6vjD1ZlzGdGZVcfXxxnD0hXY8LmZPqBg9I50+VTok8/hKd/wzzK5VsErF0n5 LcaUtUo6jIjLLNMMfm+6ONg3e9bOEE85f6iBMXAlfpIZy4P5/wO7g17oiq5DGKoUIC MmWuCT6S5YtkuxyXkZS/Rv37u9C9iNMBLk+cOveY= Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazlp170110001.outbound.protection.outlook.com [IPv6:2a01:111:f403:c200::1]) by sourceware.org (Postfix) with ESMTPS id DDD3C385DC29 for ; Wed, 15 Jan 2025 10:20:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DDD3C385DC29 ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DDD3C385DC29 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1736936418; cv=pass; b=WwR9G+xvygj0t869jcQIVNFR31M8eWCCFPGGFuH/umnZmDTgXny3fX5HXHWfFhDAli+qRzEspxo3uD/n1qmuhGLU/W1oB7BkTFJZcBXvgqlEyGnl6hrz4A0NtXhR4EOtVbAxW0xlQhMrOCVJC/DgB3ifV55MxDrByyJjytREf2M= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1736936418; c=relaxed/simple; bh=4APeVW/J7J62kLkHPZLUwAuLEkprSfneoekuS0AQ4F8=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=G9uBLnUO5r8ht78Gci8XatN4705ZEMPi/xMt5CMPbo945ybB1zop6ShgXrAIsoKi6dk7GM4T30YZf7Cw+D8k8dURKw/SicCkjYK3HANbqSNXztvovZMpFU5VvbLCNOTla0zUNAB8vAo0gXm3oXB/TZSlWB7aEPWnZ58O6wbFZZc= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DDD3C385DC29 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JXQLvJj9ZY6gziu4PaSLCD5FvM3lC14LfU/I3MmkHNIYGGXTMjyIQEirVlMAMn84r/Iku66Au6oVW6B1ubyLbYNma5AeC93IUO58P48olcSYA1QQyIigw4CTd1u/TYrFx49ns0RIVRCfWfjndpLLbz7uvieroE83x0mdy3fnHXf91Q7mlXfsN3aHJ8ABWsIVbLEewdHJn/CDPh+AcJOYL9CJtL+Gs43/xmO0b+cHqzmuMDE2rfVz49mm5ugBtTW1IeWp3JfoqKykWqd/rJk9Z6trijVCNczx3bjV8ccIEHEr6mA3iTMmR75+B+hEL5kNPqddpjTssozHjP9gQpMNkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=am6RrY+6N9aA+fb9uWCYcDibZ3XqpgCWXiA56tXw+eg=; b=g1vYQBnxG06wGSjCcO/rIUu3HIr7irF4TwzM5uiJimvtl6l5CEztVgTyAAAbikfUon3h4Q2570R/irpnt2qm6nJI64t2uiaY9agreboMMmFqoBS8ksgeukaEjS0qcse5/IuecVW7TzO429VwmB9yg/0jAruM2+HIpCiVchK7UZ4bzgBBEl0esCvKlGJuTv6m/TT0YeruLZkKMMCyKAxafwaIKeWVle3x4svUxthV7YuhMppO6G61Vb3/kkDbln/wAiBUHlySkqW95+24OkFnsU3wv405BNvgRJ21utGt1Qarfi9Blj6m7+90Nass5mkK8jj9nhwBKlNtDbFG137v+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from PR3PR08MB5852.eurprd08.prod.outlook.com (2603:10a6:102:8e::21) by PAWPR08MB9615.eurprd08.prod.outlook.com (2603:10a6:102:2ef::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.13; Wed, 15 Jan 2025 10:20:13 +0000 Received: from PR3PR08MB5852.eurprd08.prod.outlook.com ([fe80::f44:d113:1c29:825d]) by PR3PR08MB5852.eurprd08.prod.outlook.com ([fe80::f44:d113:1c29:825d%4]) with mapi id 15.20.8356.010; Wed, 15 Jan 2025 10:20:13 +0000 Message-ID: Date: Wed, 15 Jan 2025 10:20:12 +0000 User-Agent: Mozilla Thunderbird Subject: Re: automated coding style tool Content-Language: en-US To: Tom Tromey , Simon Marchi Cc: "Aktemur, Tankut Baris via Gdb" , "Aktemur, Tankut Baris" References: <86538dac-6c3a-4b9e-9de9-3906e645fa4d@redhat.com> <87y16vwbzl.fsf@tromey.com> <74c8b867-f5bb-48f7-9849-11d06e63a3d7@arm.com> <87tta2r5z2.fsf@redhat.com> <87tta1qq1i.fsf@tromey.com> <2985f4ae-33c0-4e02-8982-fa132f4d3741@simark.ca> <87msftuhd3.fsf@tromey.com> In-Reply-To: <87msftuhd3.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0207.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:318::20) To PR3PR08MB5852.eurprd08.prod.outlook.com (2603:10a6:102:8e::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PR3PR08MB5852:EE_|PAWPR08MB9615:EE_ X-MS-Office365-Filtering-Correlation-Id: 81ba4029-8dbe-48fc-29a3-08dd354e32e3 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bkxOL1JEUWk4NG85aThFbnNZNGpaazVQNS9zenJvVUdGWHFsM1gzZGdZMGhM?= =?utf-8?B?MVdseml0OFE2ZjlubjhMK2gvVDlmTE5vNHBhSkJ5YXNLUE5QWEVuRk5uL0cx?= =?utf-8?B?UXVyZnkwTytvaCtNdmU3V005dldaSXhhWldxRzJ2UWV1Ykk0RUFlNHRBbWx1?= =?utf-8?B?Wi9acnR6M0U3N01Pb2oxVjNIcUdNSHNvMVBkZ1pEcld3NkIreUF5NFFiMUNy?= =?utf-8?B?Tnl0bitteVE1ZDBtQ3AzUHNSV2JtOVE0Ri9helB6dHpEeHQwUzBuemhRT0lX?= =?utf-8?B?RkY0c1gzZGVtK0dzZExkaTdPWVo2emtIaEdjU1RhK2NDWVQ3ZEoyZ3ZSZzRN?= =?utf-8?B?VEFUQUVzQjU3bUNieGpNdXMrNzY5eVRIdlpnV0M4dkcrQmtkR1M0SHBDMW96?= =?utf-8?B?a1VZZUxZZnVEK00zQ3hTQm9iVk9nYXJpbWJGelhwQS9DZzY0aTFKd0MyVUdL?= =?utf-8?B?dzlOT0pCcC91K2s3Mlg1K0hwS1dPbWNLbGN2NTVSYTZhcno2Z3M3RkpBZ25m?= =?utf-8?B?Vll3ZEp1eHg1QTlTb1YzNVRQRmRUTnczMllQaDZ2bkJXN055eVlVUFBMVzdk?= =?utf-8?B?bWRhOVpvRDdrN0hRdEcxL2dtcnJPdjk4cTcxNytMUVZ1Y1l6QmVpU0d5VmNR?= =?utf-8?B?MTBGKzBrUDZjSWtNNXVrYm5INy9rb1VnQnNGU3UvZTVZYklyWTduaUFCYkx3?= =?utf-8?B?N3dZRk5GNHpEMklVOHRKNnJ3enF2K0MvZ0NDWm8rdGl1TkliWFkveUk0c20x?= =?utf-8?B?THV4Rit6K2FxdEt4OWdhM0tlbHpLSlR2dmVDMzRtN1BZbDViczk2OWp0UWw0?= =?utf-8?B?SWJsU2M1OVdxNjBqK2hzYzBlR04veXZOUEpSZEhsRXJuQ0MwdGlYcmNTTnBD?= =?utf-8?B?bWRVNXRCS3RHK3NnTjZGbmpsdWZaeXJaMzNibXloRlV1Nm1SdCs0V3NaSW5z?= =?utf-8?B?dkc3YlRUSGV1SEptdm9GZ1F1dE0xSmhOd21kODR4UEhacjdEL1lSc3VsWFJt?= =?utf-8?B?cFFUUFBiZXpxVkU4cUxlMGFZNFZMVEFNK0RDU2hubitXSzZWdjNVQnpESTRI?= =?utf-8?B?R3l4ZXFQSWF2bGJFREdpVGlHRkkybDIzcUhEWklnYlJBaFBmcUs4dVB4Q1BM?= =?utf-8?B?L2YybFFpaWljckg3ZDlINGNOZ0xQd29YVjhpYjhVTHdlT2NtOWhsOXlJYTBK?= =?utf-8?B?MG5lTnlGbW1aR3ZQNUJ6S2VCNytnd1NDQkg2dlJJQXNSQU9GbXA3WWJTV3Z2?= =?utf-8?B?Ykd2RjBEeVRrZUd5RXdKTC9tdVNDTFc4K2VWOGkrMkx1WVZFeFNuTjRGVndW?= =?utf-8?B?MDQ0Ly9XT01zS2xDR3N1ajcxMzQyQXJMZ0VUN093d0ttRzJRTnhZS3ZLZGF5?= =?utf-8?B?VWYxMTk1Y0Y1NG9kczhPWnVrcFQvcXVHMitPR09FYWR1T2RUSFpFekpWWjdw?= =?utf-8?B?SnE4R3hESkRqa1V6c0RMZXl0bm5IY1VKU3R1UEZQU29yeWlUR3lVdUx0aEJB?= =?utf-8?B?NVZDMFhlejR4NUdHTStzaGFsUmxjMVpya240N0lZTm5ic0E0M0xKTWdPcnhh?= =?utf-8?B?QXVYT1ExY1pZbmloSitYeUNkQjAwTTZpc2o3S3hrM3VhRXJMUlVlaUZleU0w?= =?utf-8?B?WDBxbUc0Ykx6ek1YUlpsRXQ0ZEh6TTM4S0d5NWZjNTN2T29tT1cvcHFDY2I1?= =?utf-8?B?WUNqamhuSmNtTzNlbjRsNUxBZXRNWDloT1JvU3JBWXhpd0czSFVmcHYyZjZK?= =?utf-8?B?WkpxM21XVXFOczg1djN0c0JiMG5ycGtyMEc5ZjJCeTYvN0tERUw1ZjYvaHdC?= =?utf-8?B?TTZYWFc3NGpOYVdDck1WSHlhYTNWbHljN0ltZURsdWZEMXgrUXVTQ291RnhW?= =?utf-8?Q?fgHnM51vQUD5u?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PR3PR08MB5852.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c2wzdnkvZVpGRi9xRWxOZzFkVi9vclJRaUtRcHpXcFpDaHRiNTBIMHZOMEJT?= =?utf-8?B?bnpjcFFnbGFCV3NaRWJxQU5lbGFPSE5odGtjbUdwR3VvUVczcHBxWXBJUkoy?= =?utf-8?B?R0xlSitFNjBTd1Z0bmIrdytJZS9kM2JvWlFzT0lpeW0rYkZWdlozVW5CRXoy?= =?utf-8?B?Sjd5UTlJUVBsZU1TbElYVm1wanpiVlhKM2ptOHBrQUd2cUYrbDdUYXMzZU1S?= =?utf-8?B?ZzNnbitlRzh0c0U0Rk5ZcU5sL1JDd3g1YWJlQnNIME1MdmNjZXUwcW1BdXBj?= =?utf-8?B?VEpRYm9TU3c3ZDFPc0l5UUo0dHNtVFZ2VHcxay9tOWNLUEZJODZFeDF3STBF?= =?utf-8?B?alNXM1IvUklvY0poRXU4TjlYbCs2d2RKK2RvRWEwZ01ZeVpWVTUyV08vV1Fj?= =?utf-8?B?TUdpai83bFRKQXNEOE5oaUF3L2lZa2lFNlRNZ1BrcElVZmpBS0ZJZ05iRGRv?= =?utf-8?B?dUloWVVuZmdaSzRNekZOdHRURHFQRmwvaWM3ZFozT094VWZaTmk3Y0pEWXpz?= =?utf-8?B?VjJYM2FyR014T014VlBpdWl1LzVOZHl0UlZuYURFZW1KT0FJM1d2TWVSZmxV?= =?utf-8?B?WnF5VzFjbDRmL3A1aWhBWjMzaXYwL2IwUEt0V2l4LzZ6ZGJKYXJqMnVEOWY1?= =?utf-8?B?M05kbXp3NUhrcUFkVkRKbzZxNjZheWJzU3hTNGo2Z21nTGVtVEJJOHdGQ21D?= =?utf-8?B?OVcyRDFGK25hN0Q5WUVDUzR3d0hCaFVrRS90SUFrdTc5VzF2VkJKYlUvU2x1?= =?utf-8?B?cXNwRTdGeGlmL2ZMRDFnYTU3aGc0SnJuL1dYTVZGT1ltMDBPdGRKYzZjWWFy?= =?utf-8?B?bDNCcHpRQWt3YzZPT3ZRODRIa1E4STZPMlhNOS93LzhDM1gyOUxPMXo2ZXQw?= =?utf-8?B?dXVLL0FLM0J5Nmd4TGRtaHNET2U5OEhBL0p2V1hLTHVmN1VTMkIwcjJEYkFH?= =?utf-8?B?QXN5RjNKT1hoT0R5N3dLT1cwKzUxUytxckc4UlVmQlFPazFyTWZyWUhDUFhX?= =?utf-8?B?aHExY29acEV2cklzbVA1V21qNzhyb2JWR0h4Mm11cVVuK09YL00zTjNuU29X?= =?utf-8?B?blFMYmd0akdZSHhTUklnT2wvSk5qbWVsbW0xd3Rza0FaVzU3TTBQTy81cG1o?= =?utf-8?B?Ry9XRzBCeDFweGxxNmx4ZDYxSW9SUmFZSExnajlLUDNtN1VsUUEvck5oUVMx?= =?utf-8?B?N3VUUDc0WFBKYVRDVmplN3JjUHV4UXpiYVp3VUQyZXhCSmhHQlgzZjljOVZr?= =?utf-8?B?ZmRYM0JoZkdXVUs5b1owMzhtV2ovZ1dZRUhxcTRib2RRRWtSYUhKQ3dIa3VN?= =?utf-8?B?Mkw5dTVDNDJOL0MxOHJBeCtCc0YwRXN5SUtjbGtFR0l1RERqUW9VL0V0ajgv?= =?utf-8?B?dDhIYjkxNVQ3d0pKenZsSmpvYk4zdjdxcGRrOTZuN2ZFZHMwdk1HcHdkdHVu?= =?utf-8?B?RHJwS2NuZmM4MngzK1JTdkZHbzZXYzlFZDREVTBFV090YlB4bDJGb2tQWlB5?= =?utf-8?B?dlgydThTRGpEMW93dTFBbWRQamFPdldHN2thbVZOMHAwQUR1TkxCWXhGNk1q?= =?utf-8?B?L2NKZ2FwajBMQ1B5WFgyMTR1dnFkZzFGZG52bFp3UlRrbUNNaU1WbkdTQ1NS?= =?utf-8?B?TENMdE84WGFHNlU4dFRXSEtUUTNZSjJBOGFpU0lNaDZ6YWxkb1Avd0djMTNw?= =?utf-8?B?UkJFSXFlS3duUXR1SlhCMDVIRTZhY2ZzUk4vOUExd2IwUDZyakFRNzhkclJ6?= =?utf-8?B?T3hSTmRqZFdoblhQMUxoMkNpYlQveW9OVnE1NVVyTFVJNmdaWHhxMUlNbkJS?= =?utf-8?B?SFo2TFIxa3VtQ0Y0ejdZeU9yODJ4QUEzMVZUTGpPZ1BOcUp4V1oydkJWdnRi?= =?utf-8?B?VmRKZ053SnFIQmQyVW9Rd0lvUXRTakMxVVpaS3Zmbm4vU1ZTN1VZSU10MHhH?= =?utf-8?B?bkk5NmJJa0FCS0J2d2ZZcDA5TjZwNDJPaVNZekZQMnV1bjgwOEVoM25VU0Jx?= =?utf-8?B?dE00UGlhZnQ1M0plWXM0ckhZSnkxa0FtaU1Vc1V5SFJTeU9hTmE1S0h6UndR?= =?utf-8?B?Qm1VbUR2azl5aVFGd0FIT1U5VHl2UTRJUzdLS2EzUUFLUHR6Tnh6S3hEQ1l1?= =?utf-8?Q?9PsM8XFbaItTqMpCKCSxdHusI?= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81ba4029-8dbe-48fc-29a3-08dd354e32e3 X-MS-Exchange-CrossTenant-AuthSource: PR3PR08MB5852.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2025 10:20:13.5881 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QgNbhieG2JNYoz+cURk4KvJl01slR6fDNuldfY7gKBzsmxW1+IOPvTvA+6cUwTkTOJejQ4Q8OA3Q7BusOsY1Zg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9615 X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb Reply-To: Luis Machado Errors-To: gdb-bounces~public-inbox=simark.ca@sourceware.org Sender: "Gdb" On 1/14/25 23:04, Tom Tromey wrote: > Simon> If we don't like what the tool outputs, we can argue over than > Simon> and change the tool. > > Yeah - but that's where we're already at. Like, I ran clang-format on > gdb and read the diffs and found a bunch of things I didn't like. IIRC > the main offenders were bin-packing. I imagine Pedro did this too, > since he's made similar comments in the past. > > I at least CCd myself on upstream bugs against the tool. I commented > on some, maybe filed some too (don't remember). > > I'm not super interested in hacking on clang-format, but the tool is > there and all the information for someone who is. > > Simon> Also, if are missing some features to get the output we want, nobody is > Simon> going to magically implement them for us. And if we don't use the tool, > Simon> there's no motivation for us either to go implement the changes. I > Simon> think that the only way to get the ball rolling is to start using the > Simon> tool, even if the output is not ideal, and then if there's something > Simon> really annoying, one of us *might* have the motivation to go improve the > Simon> tool. > > I'm in favor of using a tool but my view is that it has to meet some > minimal standard of usefulness. I just think clang-format does not do > this. That's fair. But are we factoring in the amount of time spent over the years telling contributors "you forgot a space here", "two spaces after period"? I tend to think that is not a good use of one's time. I reviewed some output from applying clang-format --style=gnu on gdb's sources, and it looks generally fine to me. Some stuff is a bit different and some other stuff is very different. But personally I'm willing to see this automation go through and I'm fine adapting to a potentially new format, whatever that is. I might've mentioned this already, but for folks that deal with multiple projects, the norm is to have to deal with varying styles. So it becomes even more of a burden to try to remember the GNU style that mostly applies to C and not C++, even though the project is C++ now. In summary what I want to say is that I'd go for it. If later we want to tweak things, we can. This sounds like it agrees with Simon as well.