From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id rBn6ABCVimeajBIAWB0awg (envelope-from ) for ; Fri, 17 Jan 2025 12:36:16 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=MC2Ty6VE; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E64311E100; Fri, 17 Jan 2025 12:36:15 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 382261E05C for ; Fri, 17 Jan 2025 12:36:14 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B354C383FBA9 for ; Fri, 17 Jan 2025 17:36:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B354C383FBA9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1737135373; bh=cZNri6340rjCp1J481ePhOX782E2zMFLhVNRVl5988o=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=MC2Ty6VExRa/h75mUFb0RQePKYZE4XoQEvBqjRkGxFrpeQ3Ho4Kf9QEtxVvETl29V N/s8AuexigNkEDhOkHbjwPfcAze5f5PLRlzSz+GUCVUKJJE0Dbb3al//x3Gy3s+ZG1 y0VTBoZwljxutZrkVMdVKo/TycdhArWOOgvj67w0= Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id AD88F383FBA0 for ; Fri, 17 Jan 2025 17:35:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AD88F383FBA0 ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AD88F383FBA0 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737135330; cv=none; b=t1/PUFYANxfqQqI3/lziFUFN4mb0XNwmnXNkQ+O0tR1JyoYV1D2arhfRTgCd1oP0lgHDExMpc5aGn9NUXYgVViADR9Qra3rsNg2X2H49L/LJXzIFb6dvVttqn8EfgHTJTuaAUvIxAzC+zQf+KwWFztAk2sDL50rcJfJA3tbQXmI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737135330; c=relaxed/simple; bh=/pVUTJ2/swx4pVpg7/tbghcDVJoOoROuWHwUtxr2/Tk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=UO4YBYJg4U7FsiPJlxDyWwn1VUKZvyUhzybFI18bWwh7NZdlSel+F3mO3nlORUwJYN6M1UV7H0oowU295Ry9ujzYfcBD/lhcoQuk/Eh84UWDQ4WTRvN3iwKapneWg77R2P5wv0tBQ+GiNTA/YaV+1Jl6leXzudRoZKnibfxmuGk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AD88F383FBA0 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4362bae4d7dso16538115e9.1 for ; Fri, 17 Jan 2025 09:35:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737135328; x=1737740128; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cZNri6340rjCp1J481ePhOX782E2zMFLhVNRVl5988o=; b=ovtXLq4PxN8GZb4N29YfRhvLFt+fpTGEWbKQZ0qu8oOf4nKCKp1IBUHXD8YuyuvVmB OJXxxdrn1Zqjcr4hW1fEsjGirqDTnOK4M7Tbzg41bTZoART2B/5BSRfyG06nscRNQmeg wAfsfzHHm76rcUVoudLDx1DmeL15IndKE5T7xOht2K3HurqJkP+BKt/P7FpD5wRzbiG+ rBQvHKO3RTJADHXS95xMeBEwZaJ18m1s7EOZA+F9ntRMHjf5A6sSgpAMVoUSZQYIOiz6 cryi1F1YZ5vysUc4Rab6+Kst331aBZKFLmCUYjrNFA17+ucoZ3IKi3cq+6bjmwieWJMG gavg== X-Gm-Message-State: AOJu0YwbHUUv9UkfPuQ2FtRy6/AAl7G5+4ZI/cdHIWPJlkLQyO+rZbOc PrWmAgvy8HQbS89t8uY2ZyCc5PZyBY/lqws4ewtS2qpoSa7ChJOPlvcasUQ5 X-Gm-Gg: ASbGncvZgHCbFtGveRtgaWodtUN4sV/yJaMTXiokJHHC6HwUTYUq5kpca1F/7zvQM// vZzxYwhw3Pmc4MA3+ZzrLJ9ktD7VPM01ydsySA+JiUAdAk/8Pjn/n9Wv6X0IDt5YEIrhotP2Tu2 Q1DpBNsWpEcEJN117xrXwKz7BxUNLiEmhhhOQODIHbDxfrzRtC/WkH2nKAqf17aPy/E8iwjbk84 Z6Qcppld2HIkA3TaT5/dpTmhiZaJdWKAlKGXYAKiJdqngQQKsPgUySYzxNwvY4s1t8Q458f8SSc a0YRSqtEqnNMX50/McgBhjbd7Qk= X-Google-Smtp-Source: AGHT+IHWAqKTPRKmQkjck6vIy/4vNvzDGU4viCDljghuuxRubCOGfMDdTcRoSmDHSxwE2A8qOCjNgw== X-Received: by 2002:a05:6000:4021:b0:386:1c13:30d5 with SMTP id ffacd0b85a97d-38bf5655290mr3482744f8f.7.1737135327798; Fri, 17 Jan 2025 09:35:27 -0800 (PST) Received: from ?IPV6:2a01:e0a:cf7:f430:a632:7400:7804:2409? ([2a01:e0a:cf7:f430:a632:7400:7804:2409]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf328847esm3043193f8f.98.2025.01.17.09.35.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jan 2025 09:35:26 -0800 (PST) Message-ID: Date: Fri, 17 Jan 2025 18:36:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: automated coding style tool To: gdb@sourceware.org References: <74c8b867-f5bb-48f7-9849-11d06e63a3d7@arm.com> <87tta2r5z2.fsf@redhat.com> <87tta1qq1i.fsf@tromey.com> <2985f4ae-33c0-4e02-8982-fa132f4d3741@simark.ca> <87msftuhd3.fsf@tromey.com> <877c6to8um.fsf@redhat.com> Content-Language: en-US, fr In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Phi via Gdb Reply-To: Phi Errors-To: gdb-bounces~public-inbox=simark.ca@sourceware.org Sender: "Gdb" On 17/01/2025 16:55, Simon Marchi via Gdb wrote: > > Of course, like Joel said, ill-formatted code will certainly get > committed at some point, but the nightly job will tell us. It's a quick Just curious about this interesting thread. I'd like to understand the ill-formatted concept while using a code formatter. I was wondering a !ill-formatted, i.e a well-formatted should always produce a no diff output on its input, I mean $ format-tool foo.c must produce foo.c with no diff's, a hook of some kind can be implemented may be at commit or push time (or git-send-mail) saying the format-tool must be run first and QA re-run. I jumped into this trail, so may this has been discussed already. Cheers.