From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id iP4XB43J9GWVyAgAWB0awg (envelope-from ) for ; Fri, 15 Mar 2024 18:19:57 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=byKzcibW; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1770B1E0BB; Fri, 15 Mar 2024 18:19:57 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F2B2D1E01D for ; Fri, 15 Mar 2024 18:19:54 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 16EDD385E453 for ; Fri, 15 Mar 2024 22:19:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 16EDD385E453 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1710541194; bh=TrTeFh7x1c5t6rm4AUpQCcvyf69pRsa/XncklsJRH8M=; h=Subject:To:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=byKzcibWzQ1S5X1viWMrYkL+58tvIt2k/4fheJBmEf9GsAz0RYhqvafWbd1HOHOtn ZQSJb47EqemNn8LNhMm6YtxP4ZpHVTEB74Wc6c+CK5jb/t2VRuBEOZYHWV0wD+BaFB JAw2yZdkaTokf9nviKwKqZtn++aRgt49kMVFpUuM= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id EE585385E445 for ; Fri, 15 Mar 2024 22:19:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EE585385E445 ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EE585385E445 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710541153; cv=none; b=rrALDMNZTYo9NS2mLpbU70KWcZlZ03nnju80C7AgO5+Jk6NrSlyyC2gDYbJ46oTjkqfFvnmP1u0AhRoWXiBCdq3l1+VX0A+Ka27ntAAMA57fqraafEETs7xRfB2L0HSHaP2+9svVq1GazRnMQBBtcQEvUH/kYorA5hAR3/FTRWE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710541153; c=relaxed/simple; bh=yvxfwDMg75ddOhsode+aaoju2I7NY00efoxxDmKd74g=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=Kx38DqsF3pUvZIUlKSksUUPXO5GdyanIfeEbxM3oOhO6UvcL5ye36EQo/UplfXlDDN65uDAMPWQWgmGZPH3TqxDS18TGdJ58wJZKanY+xbIPCXKVUIFw+9894kPfNE6J2W5Ke8BLZu+aGfgd6gIDKHKAWx8IrwxY6ORyg6W2qhQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlFtF-0005l8-Eo; Fri, 15 Mar 2024 18:19:01 -0400 Message-ID: Subject: Re: GDB 13.2: breakpoint at wrong line after unrelated change To: Simon Marchi , gdb@sourceware.org Date: Fri, 15 Mar 2024 18:19:00 -0400 In-Reply-To: <3b4f943d23543da2ba96dad8c81fa8c495fffd08.camel@gnu.org> References: <7c064cc544bfe453a250ca58b4d5ebd97919178d.camel@gnu.org> <4c3f986c-a562-4506-b382-c754678abcff@simark.ca> <7fcf12fbd4a106af488168d0e740e0d8ca9b3022.camel@gnu.org> <06c7a0d1-6ba7-440a-a21a-616ed05cb5b0@simark.ca> <3b4f943d23543da2ba96dad8c81fa8c495fffd08.camel@gnu.org> Autocrypt: addr=psmith@gnu.org; prefer-encrypt=mutual; keydata=mQINBFgL1QsBEACuYjznLa3tNM8CNqUcGU80xmT1J3Mkc+derJTKrTpqvqBoQi0pSZFr1C4sqUR9E3ERoaAF6kahMywrDpWJgGDyjURskugDmnlGdtGgeL5tehXHiw/y1fh0XFP5S1KmPE4W1KTcHgcWJsoqIiRlZjZx950wowfrbApQnEAHOYhj5wSso1CJ5gXAghThR+QnbBg3NWj8yzo0OoDQjJRuISIlcKu+MQfJ2wV3Wmmg2gH8RIJCrqjc0DyvlqHIT4HtyRlnerEORKUbibudJLLjXOCBXIK/xj5ahLRMcKcEGmVv+f7PQxnBtZ/ew66AbCnO9qVvpXtS+7didkxoUYNWGF983Zfja3gntfbIE/HMrjC7jdk6tJcEddNPpMzytwcO2IQ0DOiokq+5xbhp52ycJProCc/pZQTflMO89hCMOdhrkuMYDtvUJalIRofts+bQ84h22niea6/ewtNAwWrF6fzr5Yn7qKyvOFTe+9x39NzS7k9mqYUOb72JbsZfQc9H86bF0b5LK4iTPr2T0yP482ITfbHt2CZS+fGMYgF+V3E6aer11L9+ecNrT91XrLdUr0SeiYW2scval+fUyISdDKN9odPt8b3TRRU20pQqx9ljTUFV8zZsE1UhLevbHXh1XBSfhcUa3CuEIh+NGb1ojGF/lzorSmbWEGIpgopRlC4sWQARAQABtCZQYXVsIEQuIFNtaXRoIDxwYXVsQG1hZC1zY2llbnRpc3QubmV0PokCOgQTAQoAJAIbAwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgAUCWAvbZQIZAQAKCRCAy3J6IMebsuPwD/9jYcpFxNzDpEw9u48U0dSWU4hG+cnyvXyYFa0ak3eTQJfdIDsRuP18cGL1DTZhBecq4m9ifPqQjhs51qhI6rFV2WVXeUhVrfUhKDleFw0dkx0CI2QahpTyowWfXF3nQNm4NGMFi4vIEkdDy/StNWfNo YQSk8aafRnFTBs0ufEX18OSVHQ2zZemtuUgGsYBTz7VTuSoXn8rAwMWA4nOgkocppgxx8MRVqoYbtuELPNJr9UveXVEmbgCyHUNGiEC0fXTdK5mmJxQnfOcE/tzBRYzlCwpE/83MndE1mM9jFiEmWwNTEOujs3juF/HGm/frUex2Xt3ZFyT9/nghh1kvbqL2ci8kre5jGJfECKqVA5juWlpDwac81wbqpzQjk7cgVxrXyJIYqnahhCHMFbCDMXZcRAdd4LGPFFVyBUP4yXMNH2GVSmcgYWfSpk+ETfBU0SpmVZnMXi6qm82/+tAmBTcd79OBQbBt7DU2k13Qtq/jRMB4RqDe9GJFKcd4FWjwnMzrUyJIa6CJgAdbkLeKtAGOumfDfpSzw6E75Z6t4qXyTxYn1BSwDcyIqBzPRh/W+empFou2kuPFFghfgac2vJj3tuztGgZ04j3CAU7ixKMiqrAlymncHXjDi1zIW7in8NsDR4/cz1lnObDRYta8WMI0tkPVNS01xnFkeKvaS88w7QeUGF1bCBELiBTbWl0aCA8cHNtaXRoQGdudS5vcmc+iQI3BBMBCgAhBQJYC9tLAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJEIDLcnogx5uyOr0P/23tm3fmaLgHcx5f9YRlZIeWnLvhTCyhCMVYvSygFqKG3h/Yw3ldiC9Awv0+ThJ8OBhcR3zlfKdTDJUzZ7ArnYol3UQZ6MrX/VVM4VlH3TncAyEmPfGmjE/gx0RQXjyR8EYRCHruek7Cs+05CjVi7VRExOgndhHqOFnl9NqaijEjjST12z/8WzJV75yvV/4RLuNd9ouIqzMyeESmshnhol9T6b1WnA47XHjZTsreh/ryt3Ob6lZrtj8foJxXOxppwrsVfWqo/qhUzv+wPcblk4zsyjl8vrTfIzpunazckzRVOwkHW5YQJYZuTMkfSthyjQyUqKoG53WKKVq2pahccfumwA kqIdw50LigQiFOV36vZ97755NThvlgNpTSkIb3TfN7uM1X4a4y+xwTsrqPP0jdLiy1NdW14wb59xwcuGJlu2wsJx+TgrdZq428fbLH7sNc+ZeF2uikIhPrw3eskvwpeWgrJlWxqFW6nP1K9QWiRQMu7F2V4nMibS49pROyiZ0O6YWY/ypKj2Q9fPxm3jrrQCkjg/bY+JJod2v9Y8Ac71Xo35zFumJTAgQnQJn66ew7Ur7Tgg1oZNzjkqcBOEuvOoc4heBYnkHvs3o7LqIeHsOUksupyL90R7ef1w3wM9Ol9ZBv3p2qjCQPCXXSptNhXxk0SCu9bVmNJSVXYpS+uQINBFgL1QsBEACqdH+dixdbRlWMCk6JhdNrZFiOIKex1wViDGZVPGl/TnTHTkz9zofWRQCFW79zq3/ygQguvmQo6DBt3w7qUW0N5lsumQ1zpzmJLjdy5JanY8Qj7DnZraLAEMXAD+YsGvrMHD/znFQ9eJ5oV12TJ6tQ/wfqiHXmYaAGdLuto7258Bku68T2UP22ca05ysnEJFHfjEL5rfCqvFJFy8j169DbohZhiCL73IjN5fEbEb6VEANzKue0aK3W1Ls7E+HF9y8N41YzAwriQG/E/NylkcOjEAsj2W5tU9Xm4Hji9NPN504z/yRj1wKngbwoIX8eCqPvB+0+K548sAB8pUzEBnnAfdTYT/O6F+kL9cQfMrIo/eAiB4sT1Bh9j3goRjdJd1WM1mQErh0dXj+37vMfPldwxZ+yqw1VdGhd7NkqbRQ25Esv/RhZCkCacYqLUutm4Sw6zkpB1wX2rcDYqk8ZH8PgQGy6Bqh55VVra738e9LNCTLRz6fMMTDDKuKogXHIOY/ZQlOuw1iVT52rY9rvDbA1DAim4MrC+ZjWtP2PHYx/ZQW5jlJCJNRiA+tOsz68hCdJFRFI6EaHFg8QI7XmP6RlNdFwZySYJ5DZJosbZRKMKcayS/uldqnLNtzVmPSz81wQXtz E5VsEDWyotJGxJHOFWX9Q7NSl9DDMs4KtD87HgQARAQABiQIfBBgBCgAJBQJYC9ULAhsMAAoJEIDLcnogx5uy53AP/An/uB9hLFu1vXsJ/S9CAW7h8rYXPiRzjE8VZKyTkI9bxY0KXWDcQu4gdfgmxTyX8WvfOfV4NWAieZtEjOWkFF4kZjyHnyGvcoYTRpuTE5+4xGEaQum2JRGcqPCijOTPK+kqxcKKF6kN81Cu4/ft0dA5yhC/6huqEAaGA1PuT67DqEJbCnwT8H2bEChFNFHuTXpSX1kfoZU/7LXKW7VZtrz60A4omUluiaOTgwTpP9ph0GoroX4rxfnRu1I18VXCcLOXL4a4x9kJ7gMkhVIOc3SAYo1yoLfwSNHrrxQ1yGuN1e3LAwmdBY6F3JmYUPoAVGzqCAdbAOlZVfsV6B4G/I3qz9OMtYKznGGQcW5VSx6EFsPKAV9mh3MyU8UulSLkX/qTDW7UijvB8dFHZqKZSTfUlQlfGJs+f11eXAEjMP+JARY8YetAjZroEi5PtJk6hGIRcW/Wk6IaadFzb+yffSnduxXP7r9zFAikBaTTRtrmjslXa0FBLx5jTvE+5o6s0w6mIeAoujIKIl3S7QbPllcmgER4l1BgbNlppzIBE+6Bw1mcxOMvyk939IWVBizmllYTFR8I+2MDLIk66WASMK0x/28A3HF88sRAteKRKeMPjGEd0IvvVSCEn0/nxzWneLT50TnEQX1Uu6EKBATzqDgOxuO2jTG3wC6a2Wtxqy3SuQINBFgL288BEAC+Edgtl6Y/aj2PRogKgja7IRCnWbuoNP0RItSVvUWYRYE+/z6iBz/vS2bxX2bULlyjpY+bNWaAqe8a8pdAiM1vxC5oBMGXf1rVUcPY3EYyOwbPXs4UN2jlQ4hFV/qSBdEbuRPMV9/uXHtbr13mIzI6H9/UYfC7ZrdY68pbf1WpSPGUBxW/eOOo1Q/IsgEoyPsRj09RWIrUvpnk4ISM Wp6R/EOzyFw4D+IsLHvbp0iZq08SeTsC5/amUFf127tqewxeJ6yQEPK2QMU876dFlbKBgZmC1gLJrUN7BhruWXeoH0g9gVC02Ob7pscbTVuV0RxO9fIukoX7Tl2hA3bCphrMQdIaxMhFY6GOw0t3Vn963uzR4VIe9KzKaidJEVVQHrSQqApKwaYfhECMggd5es2+WfTWWqJTgFgcc6t+JAR7LxJc/0DXhVp/DGPH0flnlxb7yUNrs2AlJriitwY4jTK//Y8icLWiS9Xc9tU7SLUc9R52tZ6sOejnV9pFx0T08/OEmqEdCkAoc4ZSj77YwQH9CIZpgh07qEJ54ZxnlnmmGM1h6NZxaYXJNHw4FgAc4s3RDzsceLSD+zMo5hK0qJ13h7VObUBe8gHh4OlIHq/kLgZ9A6McEBuStjq3TVWQNleVAcge29ayB8n3LG8ScLKtPNH/p7g1p+0odtQ6zm+tQQARAQABiQREBBgBCgAPBQJYC9vPAhsCBQkSzAMAAikJEIDLcnogx5uywV0gBBkBCgAGBQJYC9vPAAoJEN6syq7beBN60/0QAIF1tphdahppA8/KTGXcyCyRqcvNHJtMnfkFgROxkmSAIHzgk/W8vC0DnGMdnsOKL7/E5mrX5LySLEAIP8S3brIi6cNtwMe0uKKZ7owBRheOcZfK44rvT3MX+fh+CZ2qj6aUtbdyBKszHnZ3BHoxlLVKyD2aso2ljyoIsDwLR5ifvIJsPQLAHRVcKSW5a4/UmNV4EoWWejsl085O516iE60IgnqrDDBLbSb7PYJ93Qz0TkaYMigw0WR6qRZHPlaKRjoSc3ekRiLEMM7/l2e6KypC5VAZOl4tMX664EVWRXjz2peW+210IT/+S2dV9KxL3M/osVuJD3iIZdwVgNsR463Ze+gxigpYYd4uyDIVN7TTMrP128wRCxU7fVMl3Q4ZqXCagpouUf9sacFOU6cBZvKhSBN7jdAq4ybEnAu50xgg2 sX6Cdwg28s6GqhPS0fiznoDnRFSs6CtLcyaKo3WicmAAKudTbN7F6wz0MV53tmyauohd2e8RwSmrNf1Y6Xz42RM4ZySYMlTAkAKY5st7c8zIjDREhK3t2ECRnnSnJL4yS4y9VenCHGCKty3OMOZ75V38zSWvUxyysIpjkVFwoxT/6wv76rIgF414YnlhxwmsmCAbkT1RTj/2vyVSRD4BM4AOsU4aqcuCj8N+TaPxIUar+uCevovBnIOU/lpSZ6qdE4P/1FmY7L5fJ95v73o4HVB+Ek+OSN4WpuU08V8XC5VqmlkpztrYrrRnWqTSFdTq7Fhl1m+Qh/2l6f7Xfc1T35tWSPCz8vYiMbUvqVGUA4//xKWExpkziUb65G7brXr3A9PNPRzKsAargwg9Q2Pe3ITSlAUB4Ee1pHR07mqSw0rHlGn9q/yYRO0qo80xChojCHso0E2sVgGEsXK3rCJPBBUXMYFup0tRJlpV2093pdKKj0ztzNT7fiFY9ZoW+lnn4KMX3+12XybMRoTHSYzHGM/w918GTRFFQ/WlAdlnDjnzA/Pab+og3kLflaoe7vr3di9UeHMvGJ130M9P7SX56YnZGvr8Xfc9EBu3XN4ieo3sfjmzRCQLOSaX0ll7AoFcT1yuAOf0JZoTZDbcZ3WDBuu3WgQZbfU7qt0E+rO0UX+a2GGTBHnssJHN3+FQAM96pi04KF0sgPWTYKY2BXpVrrHlK+1be8dtNJKbVUn0rzR9YqTWXZBPYknpvDRp+nteP3VRqEDBjdWzjcJ8/rDgFPMy+bHmmf1g8kDYoufFaJXq2cpsNGn132G2MZHJHQDze23x3TWx0fJovGAyGM1090fP2qeFOzK5kyDfRlccOehtBIGXK+agJPh3OBAJ+OyblSVZOib6w2JcjVi0WWLKHEB450iCMs/wqLA1i4Z+V46y8In Organization: GNU's Not UNIX! Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (by Flathub.org) MIME-Version: 1.0 X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Paul Smith via Gdb Reply-To: psmith@gnu.org Errors-To: gdb-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb" On Fri, 2024-03-15 at 17:11 -0400, Paul Smith via Gdb wrote: > I can tell you that in the "good" binary case I can see that > amd64_tdep.c:amd64_skip_prologue() is invoked which invokes > symtab.c:skip_prologue_using_sal() as you suggested.=C2=A0 In fact, these > methods are called numerous times. >=20 > In the "bad" binary case, neither of those methods is called, ever.=C2=A0 > I put a gdb_printf() in both functions and in the "good" binary I see > probably 20 invocations between starting, setting the breakpoint, > running, and exiting: in the "bad" binary zero invocations.=C2=A0 I do se= e > that we definitely invoke set_gdbarch_skip_prologue() with the amd64 > function pointer in both cases, so it's not that. More details, no answers. However, the problem is much deeper than some kind of incorrect computation of the prologue length. It appears to be a major difference in the structure of the binary itself, which is weird. The difference happens in symtab.c:find_function_start_sal_1(). When this is called on the "good" binary, sal.symtab->compunit()->locations_valid() is 0 so we fall through to calling skip_prologue_sal(). In the "bad" binary, locations_valid() returns 1 instead. This sends us through this code starting at symtab.c:3607: if (funfirstline && sal.symtab !=3D NULL && (sal.symtab->compunit ()->locations_valid () || sal.symtab->language () =3D=3D language_asm)) { struct gdbarch *gdbarch =3D sal.symtab->compunit ()->objfile ()- >arch (); sal.pc =3D func_addr; if (gdbarch_skip_entrypoint_p (gdbarch)) sal.pc =3D gdbarch_skip_entrypoint (gdbarch, sal.pc); return sal; } thus returning early. I've checked and gdb_arch_skip_entrypoint_p() returns null so gdbarch_skip_entrypoint() is not called. I've also verified that all other aspects of the above if-statement (funfirstline and sal.symtab->language()) are the same (1 and 4) between the good and bad calls. The difference appears to be the return code of locations_valid(). Looking into this it appears to be something set for the entire binary, differently between the "good" and "bad" binary. In the "good" binary we enter read.c:process_full_comp_unit() the passed-in dwarf2_cu value of has_loclist is false. Because of that, this is not called: if (cu->has_loclist && gcc_4_minor >=3D 5) cust->set_locations_valid (true); and because this is not called, the locations_valid() return above is false. In the "bad" binary when we enter process_full_comp_unit(), the value of has_loclist is true. Because of this we call cust- >set_locations_valid(true) above, and this means locations_valid() returns true and we follow the alternate path when skip_prologue_sal() is called. I have to stop here for today but maybe I'll have more time later this weekend. If anyone has hints on how to determine why the settings of struct dwarf2_cu is different let me know. Cheers!