From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22696 invoked by alias); 8 May 2009 05:43:29 -0000 Received: (qmail 22684 invoked by uid 22791); 8 May 2009 05:43:28 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_44,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 May 2009 05:43:22 +0000 Received: from wpaz37.hot.corp.google.com (wpaz37.hot.corp.google.com [172.24.198.101]) by smtp-out.google.com with ESMTP id n485hKlo006420 for ; Thu, 7 May 2009 22:43:20 -0700 Received: from yx-out-2324.google.com (yxg8.prod.google.com [10.190.2.136]) by wpaz37.hot.corp.google.com with ESMTP id n485gZ92002363 for ; Thu, 7 May 2009 22:43:19 -0700 Received: by yx-out-2324.google.com with SMTP id 8so623569yxg.23 for ; Thu, 07 May 2009 22:43:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.90.113.11 with SMTP id l11mr2763019agc.117.1241761398571; Thu, 07 May 2009 22:43:18 -0700 (PDT) In-Reply-To: <20090406033300.GA31715@caradoc.them.org> References: <20090404184604.8524C1C759C@localhost> <200904041904.n34J4UXV013513@brahms.sibelius.xs4all.nl> <20090404192132.GA28232@caradoc.them.org> <20090406033300.GA31715@caradoc.them.org> Date: Fri, 08 May 2009 05:43:00 -0000 Message-ID: Subject: Re: improved thread id reporting From: Doug Evans To: gdb@sourceware.org Content-Type: multipart/mixed; boundary=0016361e86c00ec6840469601bc8 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00038.txt.bz2 --0016361e86c00ec6840469601bc8 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1454 On Sun, Apr 5, 2009 at 8:33 PM, Daniel Jacobowitz wrote: > On Sun, Apr 05, 2009 at 01:36:06PM -0700, Doug Evans wrote: >> Attached is a simplistic patch to help illustrate the challenge. >> >> Here is an example session that prints from/to and the thread number >> in "[New ...", "[Switching ...", etc. messages. >> I can think of two issues with the patch: >> 1) Printing "[tT]hread" twice in one line is a bit annoying. >> 2) Spreading from/to over two lines is a bit annoying. > > What do you think of this? =A0On the theory that you can go look up > thread #2, either in 'info threads' or in a previous notification: > > [Switching from thread #2 to thread #3, Thread 0x41001960 (LWP 14407)] "works for me" > Or, migrating the "Thread" out: > > [Switching from thread #2 to thread #3, 0x41001960 (LWP 14407)] > > But that might be tricky with multi-process, some ptid_t's are not > threads. It's not clear how multi-process is going to work yet (or more likely I've forgotten). I played with attaching and running several processes via gdbserver and all processes appear in "info threads". [sidebar: I wouldn't mind "info threads" just showing the threads of the current process, otherwise it might get confusing. And given that "info inferiors" is used to show all the processes IWBN if "inferior N" switched to the specified process; a straightforward and intuitive mapping from "info threads" + "thread N".] How about this? --0016361e86c00ec6840469601bc8 Content-Type: text/plain; charset=US-ASCII; name="gdb-090507-thread-id-1.patch.txt" Content-Disposition: attachment; filename="gdb-090507-thread-id-1.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fuggnhc00 Content-length: 6584 MjAwOS0wNS0wNyAgRG91ZyBFdmFucyAgPGRqZUBnb29nbGUuY29tPgoKCSog aW5mcnVuLmMgKG5vcm1hbF9zdG9wKTogUHJpbnQgZ2RiIHRocmVhZCBudW1i ZXIgb2YgdGhyZWFkIGJlaW5nCglzd2l0Y2hlZCBhd2F5IGZyb20gYW5kIHRv LgoJKiBpbmYtdHRyYWNlLmMgKGluZl90dHJhY2Vfd2FpdCk6IEluY2x1ZGUg Z2RiIHRocmVhZCBudW1iZXIgaW4KCXRocmVhZCBldmVudCBtZXNzYWdlcy4K CSogbGludXgtbmF0LmMgKGV4aXRfbHdwKTogRGl0dG8uCgkqIHByb2Nmcy5j IChwcm9jZnNfd2FpdCk6IERpdHRvLgoJKiB0aHJlYWQuYyAoYWRkX3RocmVh ZF93aXRoX2luZm8pOiBEaXR0by4KCkluZGV4OiBpbmYtdHRyYWNlLmMKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL2dk Yi9pbmYtdHRyYWNlLmMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNDQKZGlm ZiAtdSAtcCAtcjEuNDQgaW5mLXR0cmFjZS5jCi0tLSBpbmYtdHRyYWNlLmMJ MTcgTWFyIDIwMDkgMTk6Mjg6MDkgLTAwMDAJMS40NAorKysgaW5mLXR0cmFj ZS5jCTggTWF5IDIwMDkgMDQ6NTM6MzkgLTAwMDAKQEAgLTEwODEsMTAgKzEw ODEsMTEgQEAgaW5mX3R0cmFjZV93YWl0IChzdHJ1Y3QgdGFyZ2V0X29wcyAq b3BzLAogICAgICAgcmV0dXJuIHB0aWQ7CiAKICAgICBjYXNlIFRURVZUX0xX UF9FWElUOgotICAgICAgaWYgKHByaW50X3RocmVhZF9ldmVudHMpCi0JcHJp bnRmX3VuZmlsdGVyZWQgKF8oIlslcyBleGl0ZWRdXG4iKSwgdGFyZ2V0X3Bp ZF90b19zdHIgKHB0aWQpKTsKICAgICAgIHRpID0gZmluZF90aHJlYWRfcGlk IChwdGlkKTsKICAgICAgIGdkYl9hc3NlcnQgKHRpICE9IE5VTEwpOworICAg ICAgaWYgKHByaW50X3RocmVhZF9ldmVudHMpCisJcHJpbnRmX3VuZmlsdGVy ZWQgKF8oIltUaHJlYWQgIyVkLCAlcyBleGl0ZWRdXG4iKSwKKwkJCSAgIHRp LT5udW0sIHRhcmdldF9waWRfdG9fc3RyIChwdGlkKSk7CiAgICAgICAoKHN0 cnVjdCBpbmZfdHRyYWNlX3ByaXZhdGVfdGhyZWFkX2luZm8gKil0aS0+cHJp dmF0ZSktPmR5aW5nID0gMTsKICAgICAgIGluZl90dHJhY2VfbnVtX2x3cHMt LTsKICAgICAgIC8qIExldCB0aGUgdGhyZWFkIHJlYWxseSBleGl0LiAgKi8K QEAgLTEwOTcsMTEgKzEwOTgsMTEgQEAgaW5mX3R0cmFjZV93YWl0IChzdHJ1 Y3QgdGFyZ2V0X29wcyAqb3BzLAogICAgIGNhc2UgVFRFVlRfTFdQX1RFUk1J TkFURToKICAgICAgIGx3cGlkID0gdHRzLnR0c191LnR0c190aHJlYWQudHRz X3RhcmdldF9sd3BpZDsKICAgICAgIHB0aWQgPSBwdGlkX2J1aWxkICh0dHMu dHRzX3BpZCwgbHdwaWQsIDApOwotICAgICAgaWYgKHByaW50X3RocmVhZF9l dmVudHMpCi0JcHJpbnRmX3VuZmlsdGVyZWQoXygiWyVzIGhhcyBiZWVuIHRl cm1pbmF0ZWRdXG4iKSwKLQkJCSAgdGFyZ2V0X3BpZF90b19zdHIgKHB0aWQp KTsKICAgICAgIHRpID0gZmluZF90aHJlYWRfcGlkIChwdGlkKTsKICAgICAg IGdkYl9hc3NlcnQgKHRpICE9IE5VTEwpOworICAgICAgaWYgKHByaW50X3Ro cmVhZF9ldmVudHMpCisJcHJpbnRmX3VuZmlsdGVyZWQgKF8oIltUaHJlYWQg IyVkLCAlcyBoYXMgYmVlbiB0ZXJtaW5hdGVkXVxuIiksCisJCQkgICB0aS0+ bnVtLCB0YXJnZXRfcGlkX3RvX3N0ciAocHRpZCkpOwogICAgICAgKChzdHJ1 Y3QgaW5mX3R0cmFjZV9wcml2YXRlX3RocmVhZF9pbmZvICopdGktPnByaXZh dGUpLT5keWluZyA9IDE7CiAgICAgICBpbmZfdHRyYWNlX251bV9sd3BzLS07 CiAKSW5kZXg6IGluZnJ1bi5jCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNT IGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvaW5mcnVuLmMsdgpyZXRyaWV2aW5n IHJldmlzaW9uIDEuMzcxCmRpZmYgLXUgLXAgLXIxLjM3MSBpbmZydW4uYwot LS0gaW5mcnVuLmMJNSBNYXkgMjAwOSAxMzoyNDo0OCAtMDAwMAkxLjM3MQor KysgaW5mcnVuLmMJOCBNYXkgMjAwOSAwNDo1MzozOSAtMDAwMApAQCAtNDI5 OSw3ICs0Mjk5LDExIEBAIG5vcm1hbF9zdG9wICh2b2lkKQogICAgICAgJiYg bGFzdC5raW5kICE9IFRBUkdFVF9XQUlUS0lORF9FWElURUQpCiAgICAgewog ICAgICAgdGFyZ2V0X3Rlcm1pbmFsX291cnNfZm9yX291dHB1dCAoKTsKLSAg ICAgIHByaW50Zl9maWx0ZXJlZCAoXygiW1N3aXRjaGluZyB0byAlc11cbiIp LAorICAgICAgLyogSXQgaXMgdXNlZnVsIHRvIHRoZSB1c2VyIHRvIHByaW50 IHRoZSBnZGIgdGhyZWFkIG51bWJlcnMgd2UncmUKKwkgc3dpdGNoaW5nIGF3 YXkgZnJvbSBhbmQgdG8uICAqLworICAgICAgcHJpbnRmX2ZpbHRlcmVkIChf KCJbU3dpdGNoaW5nIGZyb20gdGhyZWFkICMlZCB0byB0aHJlYWQgIyVkLCAl c11cbiIpLAorCQkgICAgICAgcGlkX3RvX3RocmVhZF9pZCAocHJldmlvdXNf aW5mZXJpb3JfcHRpZCksCisJCSAgICAgICBwaWRfdG9fdGhyZWFkX2lkIChp bmZlcmlvcl9wdGlkKSwKIAkJICAgICAgIHRhcmdldF9waWRfdG9fc3RyIChp bmZlcmlvcl9wdGlkKSk7CiAgICAgICBhbm5vdGF0ZV90aHJlYWRfY2hhbmdl ZCAoKTsKICAgICAgIHByZXZpb3VzX2luZmVyaW9yX3B0aWQgPSBpbmZlcmlv cl9wdGlkOwpJbmRleDogbGludXgtbmF0LmMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9saW51eC1uYXQuYyx2 CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xMjgKZGlmZiAtdSAtcCAtcjEuMTI4 IGxpbnV4LW5hdC5jCi0tLSBsaW51eC1uYXQuYwkxIEFwciAyMDA5IDE5OjA3 OjUwIC0wMDAwCTEuMTI4CisrKyBsaW51eC1uYXQuYwk4IE1heSAyMDA5IDA0 OjUzOjQwIC0wMDAwCkBAIC0xMTU5LDcgKzExNTksOCBAQCBleGl0X2x3cCAo c3RydWN0IGx3cF9pbmZvICpscCkKICAgaWYgKHRoKQogICAgIHsKICAgICAg IGlmIChwcmludF90aHJlYWRfZXZlbnRzKQotCXByaW50Zl91bmZpbHRlcmVk IChfKCJbJXMgZXhpdGVkXVxuIiksIHRhcmdldF9waWRfdG9fc3RyIChscC0+ cHRpZCkpOworCXByaW50Zl91bmZpbHRlcmVkIChfKCJbVGhyZWFkICMlZCwg JXMgZXhpdGVkXVxuIiksCisJCQkgICB0aC0+bnVtLCB0YXJnZXRfcGlkX3Rv X3N0ciAobHAtPnB0aWQpKTsKIAogICAgICAgZGVsZXRlX3RocmVhZCAobHAt PnB0aWQpOwogICAgIH0KSW5kZXg6IHByb2Nmcy5jCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvcHJvY2ZzLmMs dgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTA2CmRpZmYgLXUgLXAgLXIxLjEw NiBwcm9jZnMuYwotLS0gcHJvY2ZzLmMJNiBNYXkgMjAwOSAxNzoxODo1MiAt MDAwMAkxLjEwNgorKysgcHJvY2ZzLmMJOCBNYXkgMjAwOSAwNDo1Mzo0MCAt MDAwMApAQCAtNDA0Niw3ICs0MDQ2LDggQEAgd2FpdF9hZ2FpbjoKIAkJaWYg KHN5c2NhbGxfaXNfbHdwX2V4aXQgKHBpLCB3aGF0KSkKIAkJICB7CiAJCSAg ICBpZiAocHJpbnRfdGhyZWFkX2V2ZW50cykKLQkJICAgICAgcHJpbnRmX3Vu ZmlsdGVyZWQgKF8oIlslcyBleGl0ZWRdXG4iKSwKKwkJICAgICAgcHJpbnRm X3VuZmlsdGVyZWQgKF8oIltUaHJlYWQgIyVkLCAlcyBleGl0ZWRdXG4iKSwK KwkJCQkJIHBpZF90b190aHJlYWRfaWQgKHJldHZhbCksCiAJCQkJCSB0YXJn ZXRfcGlkX3RvX3N0ciAocmV0dmFsKSk7CiAJCSAgICBkZWxldGVfdGhyZWFk IChyZXR2YWwpOwogCQkgICAgc3RhdHVzLT5raW5kID0gVEFSR0VUX1dBSVRL SU5EX1NQVVJJT1VTOwpAQCAtNDE4Miw3ICs0MTgzLDggQEAgd2FpdF9hZ2Fp bjoKIAkJZWxzZSBpZiAoc3lzY2FsbF9pc19sd3BfZXhpdCAocGksIHdoYXQp KQogCQkgIHsKIAkJICAgIGlmIChwcmludF90aHJlYWRfZXZlbnRzKQotCQkg ICAgICBwcmludGZfdW5maWx0ZXJlZCAoXygiWyVzIGV4aXRlZF1cbiIpLAor CQkgICAgICBwcmludGZfdW5maWx0ZXJlZCAoXygiW1RocmVhZCAjJWQsICVz IGV4aXRlZF1cbiIpLAorCQkJCQkgcGlkX3RvX3RocmVhZF9pZCAocmV0dmFs KSwKIAkJCQkJIHRhcmdldF9waWRfdG9fc3RyIChyZXR2YWwpKTsKIAkJICAg IGRlbGV0ZV90aHJlYWQgKHJldHZhbCk7CiAJCSAgICBzdGF0dXMtPmtpbmQg PSBUQVJHRVRfV0FJVEtJTkRfU1BVUklPVVM7CkluZGV4OiB0aHJlYWQuYwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMv Z2RiL3RocmVhZC5jLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjExMApkaWZm IC11IC1wIC1yMS4xMTAgdGhyZWFkLmMKLS0tIHRocmVhZC5jCTUgTWF5IDIw MDkgMTM6MjQ6NDkgLTAwMDAJMS4xMTAKKysrIHRocmVhZC5jCTggTWF5IDIw MDkgMDQ6NTM6NDAgLTAwMDAKQEAgLTIxMSw3ICsyMTEsOCBAQCBhZGRfdGhy ZWFkX3dpdGhfaW5mbyAocHRpZF90IHB0aWQsIHN0cnVjCiAgIHJlc3VsdC0+ cHJpdmF0ZSA9IHByaXZhdGU7CiAKICAgaWYgKHByaW50X3RocmVhZF9ldmVu dHMpCi0gICAgcHJpbnRmX3VuZmlsdGVyZWQgKF8oIltOZXcgJXNdXG4iKSwg dGFyZ2V0X3BpZF90b19zdHIgKHB0aWQpKTsKKyAgICBwcmludGZfdW5maWx0 ZXJlZCAoXygiW05ldyB0aHJlYWQgIyVkLCAlc11cbiIpLAorCQkgICAgICAg cmVzdWx0LT5udW0sIHRhcmdldF9waWRfdG9fc3RyIChwdGlkKSk7CiAKICAg YW5ub3RhdGVfbmV3X3RocmVhZCAoKTsKICAgcmV0dXJuIHJlc3VsdDsK --0016361e86c00ec6840469601bc8--