Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: gdb@sourceware.org
Subject: Re: linux-low.c: stop_all_processes vs longjmp snafu?
Date: Sat, 13 Dec 2008 19:24:00 -0000	[thread overview]
Message-ID: <e394668d0812131123k3b83077y60692d062f0c8e2f@mail.gmail.com> (raw)
In-Reply-To: <20081213001325.F05871C7A79@localhost>

On Fri, Dec 12, 2008 at 4:13 PM, Doug Evans <dje@google.com> wrote:
> linux-low.c:stop_all_processes is the only place that sets stopping_threads:
>
> static void
> stop_all_processes (void)
> {
>  stopping_threads = 1;
>  for_each_inferior (&all_processes, send_sigstop);
>  for_each_inferior (&all_processes, wait_for_sigstop);
>  stopping_threads = 0;
> }
>
> and all functions that test stopping_threads can throw an error
> (call longjmp).
>
> I'm guessing fixing this is waiting on someone to remove stopping_threads,
> right?

I was thinking that we don't want to support nested setjmps.  But in a
case like this do we want to continue to try to stop all processes
even if stopping one of them throws an error?  [assuming we're keeping
setjmp and not rewriting gdbserver in c++ ...]


  reply	other threads:[~2008-12-13 19:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-13  0:14 Doug Evans
2008-12-13 19:24 ` Doug Evans [this message]
2008-12-14 18:32   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e394668d0812131123k3b83077y60692d062f0c8e2f@mail.gmail.com \
    --to=dje@google.com \
    --cc=gdb@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox