RE: exec-file-mismatch and native-gdbserver testing

Metzger, Markus T
2020-04-09T06:30:56Z

Hello Philippe,

> > In exec.c:validate_exec_file (), we check the filenames and, if they differ, print
> a warning and re-load the symbol file.
> >
> > Should validate_exec_file () check more than just the filenames?
> You mean: if the filenames differs, gdb could compare the contents of files and if
> equal,
> not ask the question, considering there is no mismatch ?

It could compare build-ids, for example.

If there are no build-ids, it may fall back to comparing file contents as you
suggested.

> > Should gdb_simple_compile use standard_output_file instead of
> standard_temp_file?
>
> Alternatively, set the value of exec-file-mismatch to warn ?

That would work, too.

I didn't want to suggest turning off or ignoring warnings in our test
suite, though. I don't think that's generally a good idea.

I'd rather make gdb_simple_compile use standard_output_file if we agree
that exec-file-mismatch shouldn't be changed and that this should be handled
in the test suite.

Regards,
Markus.

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928