From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3115 invoked by alias); 3 Apr 2018 12:23:43 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 3098 invoked by uid 89); 3 Apr 2018 12:23:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Apr 2018 12:23:41 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w33CNYI6020779 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 3 Apr 2018 08:23:39 -0400 Received: by simark.ca (Postfix, from userid 112) id 5EC091E77E; Tue, 3 Apr 2018 08:23:34 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 051B11E073; Tue, 3 Apr 2018 08:23:33 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 03 Apr 2018 12:23:00 -0000 From: Simon Marchi To: Dmitry Antipov Cc: GDB Development , Yao Qi Subject: Re: aarch64-tdep.c:379: internal-error: CORE_ADDR aarch64_analyze_prologue(gdbarch*, CORE_ADDR, CORE_ADDR, aarch64_prologue_cache*, {anonymous}::abstract_instruction_reader&): Assertion `inst.operands[0].qualifier == AARCH64_OPND_QLF_S_D' failed In-Reply-To: <64710bf6-a3e7-cb32-94df-0337f09fd944@nvidia.com> References: <72908568cb161628681345981f5c0b87@polymtl.ca> <64710bf6-a3e7-cb32-94df-0337f09fd944@nvidia.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.4 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 3 Apr 2018 12:23:34 +0000 X-IsSubscribed: yes X-SW-Source: 2018-04/txt/msg00003.txt.bz2 On 2018-04-03 06:01, Dmitry Antipov wrote: > On 04/03/2018 04:35 AM, Simon Marchi wrote: > >> So it looks like the GDB code assumes that no-one would ever save the >> whole registers, because it is not necessary.  GDB should not use >> gdb_assert and crash on bad input.  I don't know what it should do >> instead in that specific case, that's the part that takes more time to >> think about :). > > I think that "ABI violation" is not always a synonym for "bad input" > :-), and we definitely don't want the debugger to crash on some > handwritten > inline assembler trick, for example. BTW, LLVM project debugger lldb > seems uses more relaxed approach and allows STP with FP quadword > operands in > function prologues, see > https://github.com/llvm-mirror/lldb/blob/master/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp. > > Dmitry I agree. Simon