From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id TVwVFyIWhGbmkhgAWB0awg (envelope-from ) for ; Tue, 02 Jul 2024 11:00:50 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=GDwNlLz6; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5342B1E0C3; Tue, 2 Jul 2024 11:00:50 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 44B741E030 for ; Tue, 2 Jul 2024 11:00:48 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 81C0D3882672 for ; Tue, 2 Jul 2024 15:00:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 81C0D3882672 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1719932447; bh=+War4ldBsT23ZOAR5upHYQ8HLYbYj9q0qs7JS2ghS8k=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=GDwNlLz6iKfz6c8eMDuzylJ04GhPbKQ286aIkNFI9MmWB47qPBHKLZVUIwyCFh894 SAgtma7NfLH9BwYQtMXoHU3ZBxi8+LAeedtqMLY/18wtZmbduCv8OiD0jDLkQYRvkh m+dawiQ0oAe2puejkPPldliB/sFUOQvXYZPhQJZI= Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id 0410A38708D1; Tue, 2 Jul 2024 15:00:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0410A38708D1 ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0410A38708D1 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1719932404; cv=pass; b=o0vfiI1I78GkjtYyuOSoeW5jC3oM95T+yzOlF25TgVp9y/oZHOKMHQVzpsUoqw4bCqKGCykDaye2sdO60USWTRvAYqRheMVg3HI/vnHFaEDj9qfNkymqADqzioYLemLG/NlwAeMcO6+8KSbxyxer+UzoZFBHQPPe5lov6GBC02U= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1719932404; c=relaxed/simple; bh=wWph9ennV8PeaiiIuHzjKsI3+aC/lL++ctUE+pBXj9Q=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Cr4xAYGzksPb1GE5z6xRTp4NQBgL85haPOZuIqdX5azmEG+U4DgHRUV7xbzL1DoIn76ka/8cZeW/Up84Jmq3uZOfSG/4jrtK9wJ7D3NbB8XaoJa3ZRxqPJtryep24j4n/sfqkIyEO5Ne0hIYsnLujOTokQSvPEZH+g+wMTmDDLs= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R10" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4WD5g21kTvz4DdC; Tue, 2 Jul 2024 14:59:58 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WD5g20tWpz41R7; Tue, 2 Jul 2024 14:59:58 +0000 (UTC) (envelope-from jhb@FreeBSD.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1719932398; a=rsa-sha256; cv=none; b=GYLtVgoe1YSH8NAvVMkpBRzW9N1WlAfYGB3tULDlssnQXHvViIHrolqZBUVx/60OrDLnpJ ORgoSgdwGGqYCEphoRxVnj6Mc9fSmrqaZxpTw21By0QzE/mnFCrsQjRfnPVmg7Cm5xK8gB RFjFNO7kiKSDGuht3bXpQaLOly9TSE5A5R0TysMLf9RtGOSjKHXPiBWXG1dblK4OzYwTC8 e22VDJMl68O0YBx+TSDE3KDhKo1b6uXrbrK88PqwZgb8R7VlV/MtNbA0LyUG3uHudI3GuO 1Ld2ZdcFxT8wifiOMFNw1xKFJQ5S48TaLJAPsgT84lN8UB2EsD5lfnilErElTQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1719932398; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+War4ldBsT23ZOAR5upHYQ8HLYbYj9q0qs7JS2ghS8k=; b=YAVGwaF8Lx5d66QTr5lyDxYgSBq9Aw3NiAXgaGw2r7n7RtqquE0ltSG0CsgND0JiMsd+bN caUF7/36Z2vy04c0rsAXQSKtG9+l8xXdVIDFaUwcffYkAj+eRg/I543KxH5is0Ga01fhmM CmmEOcO526PonniMwAqg/iVSg8t+NUbOgxRG06by9ppmPgbdfSkDzdV4lEwGXHiZ9bkkeu Soedap9nr9gCTKQaWJw/w3P7f57dcWDKHiJmOmASdWV+5pxjgJMInB761YiznYtqi6QbKL NmepKuaVDB3+1EvOv3o5WoVqNwT724oKrV5J1/QNQkd+zFhjV1m5KAwbJw3JTg== Received: from [IPV6:2601:5c0:4200:b830:3517:62a3:b646:39a7] (unknown [IPv6:2601:5c0:4200:b830:3517:62a3:b646:39a7]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4WD5g150Bqz16GN; Tue, 2 Jul 2024 14:59:57 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Tue, 2 Jul 2024 10:59:56 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: On automated commits Content-Language: en-US To: Alan Modra , Paul Koning Cc: Joel Brobecker , Tom Tromey , Sam James , binutils@sourceware.org, gdb@sourceware.org, rostiprodev@gmail.com References: <87sex2orqp.fsf@gentoo.org> <87bk3nsisx.fsf@tromey.com> <4A58E493-C4E5-410D-BD88-1B6093884320@comcast.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: John Baldwin via Gdb Reply-To: John Baldwin Errors-To: gdb-bounces~public-inbox=simark.ca@sourceware.org Sender: "Gdb" On 6/27/24 6:43 AM, Alan Modra via Gdb wrote: > On Thu, Jun 27, 2024 at 09:23:20AM -0400, Paul Koning wrote: >> >> >>> On Jun 26, 2024, at 9:32 PM, Alan Modra wrote: >>> >>> On Wed, Jun 26, 2024 at 11:17:04AM -0700, Joel Brobecker wrote: >>>>> I personally have never liked these automated commits, and I can't >>>>> recall ever using the date they provide. >>>>> >>>>> I also don't believe these dates are used here at AdaCore. >>>>> >>>>> So +1 from me for removing these. >>>> >>>> Same here. >>>> >>>> I know that some people found them useful, but I don't remember why >>>> unfortunately. >>> >>> The date is useful when looking at bug reports from people who might >>> be building from development sources. >> >> So why not have the build procedure pick up the last commit date, if building in a Git sandbox? That's easy enough to arrange. Similarly, it could pick up the identifier (SHA hash) of that last commit to make it entirely unambiguous. > > I wasn't saying the way we do things now is the only way, just > explaining why the date is useful. "git show -s --oneline @{u}" or > similar would be good too, but let's make sure we report upstream > commits not local ones. If someone has local commits, it's kind of on them to know what upstream commit those local commits are on top of. In my general experience using the relevant VCS identifier (git hash, svn revision, etc.) is usually the most useful thing to have for tracking down issues. In the case of a regression on trunk it saves you the step of matching a date to a git hash so you can start a bisect. (Also, the date bump commits are indeed noisy, especially on release branches, but there's also probably some way to filter commits shown by git log to avoid them (e.g. omitting commits for the file in question)). -- John Baldwin