From: Jan Vrany via Gdb <gdb@sourceware.org>
To: Tom Tromey <tom@tromey.com>, Simon Marchi <simark@simark.ca>
Cc: GDB Development <gdb@sourceware.org>
Subject: Re: [RFC PATCH 7/8] gdb/ctf: don't use psymtabs, create symtabs directly
Date: Wed, 04 Feb 2026 13:24:40 +0000 [thread overview]
Message-ID: <b9093d6942825354cad1a80557a266c25a70a92e.camel@vrany.io> (raw)
In-Reply-To: <87bji5xwai.fsf@tromey.com>
On Tue, 2026-02-03 at 16:05 -0700, Tom Tromey wrote:
> > > > > > "Simon" == Simon Marchi <simark@simark.ca> writes:
>
> Simon> I think it would be safer for each quick_symbol_functions to search its
> Simon> own stuff only. What I'm thinking is that the
> Simon> expanded_symbols_functions can hold a vector<compunit_symtab *>,
> Simon> containing the compunit_symtabs created by this reader. The search
> Simon> method of expanded_symbols_functions would search those compunits. If
> Simon> you have both the JIT reader and the CTF reader active, then they would
> Simon> both push there own expanded_symbols_functions instance, with their own
> Simon> list of compunit_symtabs.
>
> This would be totally fine and might help us get rid of the last things
> that iterate over all compunits. Aside from genuine needs -- "maint"
> commands and relocation -- I tend to think this should not be done.
>
Okay, it seems that there's an agreement this is the way to go.
UUIC this means that:
1) there can be multiple compunit_symtabs for the same code
(say you have both CTF and DWARF debug info so each will have its
own compunit_symtab with its own, possibly different, symbols).
2) Given a compunit_symtab, it can only contain data from one reader.
In another words, (Python) JIT reader may not be able to add symbols
to compunit_symtab created by DWARF reader.
Jan
next prev parent reply other threads:[~2026-02-04 13:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2e8e28fbfa4894f3f28fe86f698406c4e880753f.camel@vrany.io>
2026-02-03 14:35 ` Tom Tromey
2026-02-03 15:14 ` Jan Vrany via Gdb
2026-02-03 17:06 ` Simon Marchi via Gdb
2026-02-03 23:05 ` Tom Tromey
2026-02-04 13:24 ` Jan Vrany via Gdb [this message]
2026-02-03 23:04 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9093d6942825354cad1a80557a266c25a70a92e.camel@vrany.io \
--to=gdb@sourceware.org \
--cc=jan@vrany.io \
--cc=simark@simark.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox