From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58904 invoked by alias); 22 Sep 2017 13:59:47 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 58127 invoked by uid 89); 22 Sep 2017 13:59:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1132 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Sep 2017 13:59:45 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D00F67E43E; Fri, 22 Sep 2017 13:59:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D00F67E43E Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id C1DF75D9CD; Fri, 22 Sep 2017 13:59:20 +0000 (UTC) Subject: Re: [PATCH] bfd/version.h: Add rationale for BFD_VERSION_DATE (Re: meaning of "Automatic date update in version.in" commits) To: Joel Brobecker , Alan Modra References: <20170921184615.6b1e5d44@void-ptr.info> <426b9fdf-a854-6d5f-b296-df71ad0c1561@ubuntu.com> <20170921192619.412ff148@void-ptr.info> <20170921163358.twez7kbewucjalwi@adacore.com> <20170921195153.4ed9f319@void-ptr.info> <20170921170031.czr6to24sarve2or@adacore.com> <20170921203857.06810b63@void-ptr.info> <20170921235936.GB25070@bubble.grove.modra.org> <0f7c205c-7ecb-bc49-bf15-c753e576cdc0@redhat.com> <20170922133806.GH25070@bubble.grove.modra.org> <20170922134732.tjihu4yvdeoltczv@adacore.com> Cc: Petr Ovtchenkov , Matthias Klose , Simon Marchi , Matt Rice , Fiodar Stryzhniou , Andreas Schwab , Binutils , GDB From: Pedro Alves Message-ID: Date: Fri, 22 Sep 2017 13:59:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170922134732.tjihu4yvdeoltczv@adacore.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00108.txt.bz2 On 09/22/2017 02:47 PM, Joel Brobecker wrote: >>> I assume that the bot is just replacing the line with >>> BFD_VERSION_DATE instead of regenerating the whole file from >>> scratch, but that's just guessing. (I don't have sourceware >>> shell access; I have no idea how the auto updater is implemented.) >> >> Back when I ran the cron job on my home machine, it did >> sed -e 's/20[0-9]*/'`date +%Y%m%d`/ < bfd/version.h > bfd/version.h.new >> >> I'm not sure what is done nowadays. You could always commit the patch >> and see what happens. :) :-) > > It should work no problem, as long as there is no date in the comment. > The script that we run nightly on sourceware.org (update-git-version) > does pretty much the same as what you were doing: > > sed \ > -e 's/[Y0-9][Y0-9][Y0-9][Y0-9]-[M0-9][M0-9]-[D0-9][D0-9]/'$date'/' \ > -e 's/[Y0-9][Y0-9][Y0-9][Y0-9][M0-9][M0-9][D0-9][D0-9]/'$DATE'/' \ > < ${file} > ${file}.new > Alright, thanks for confirming! I pushed the patch in. Thanks, Pedro Alves