Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: "Joseph S. Myers" <joseph@codesourcery.com>
To: DJ Delorie <dj@redhat.com>
Cc: gcc@gcc.gnu.org, binutils@sourceware.org, gdb@sourceware.org,
	    newlib@sourceware.org
Subject: Re: On the toplevel configure and build system
Date: Tue, 29 Mar 2011 23:29:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.64.1103292321200.2595@digraph.polyomino.org.uk> (raw)
In-Reply-To: <201103292228.p2TMSAPB006048@greed.delorie.com>

On Tue, 29 Mar 2011, DJ Delorie wrote:

> > 2. If you put directories from the GCC repository into your build, you 
> > should expect GCC and its libraries to be built; toplevel should not 
> > disable GCC on the grounds that GCC does not support a given target.  
> 
> I disagree.  We have a single combined gcc+binutils+etc internal tree
> that's used for many targets; some support gcc, some do not.  I added
> another "don't build gcc for this" just last week.

Well, disabling gcc for targets where it is unsupported is hardly 
consistent existing practice in the FSF tree; before my patch 
<http://gcc.gnu.org/ml/gcc-patches/2011-03/msg02027.html> there were just 
two targets (c54x*-*-* | tic54x-*-*, v810-*-*) disabling the gcc 
directory, so that patch makes things consistent with the normal practice 
for non-gcc-supporting targets by removing those special cases.

I don't however object much to toplevel disabling gcc on targets without 
support (if you have a GCC-only tree, it *does* seem unfortunate for 
configuring it for an unsupported target to quietly build nothing and exit 
with status 0, instead of exiting with error status), as long as it is 
done consistently in accordance with principle 4: that is, through 
config.gcc being adapted so toplevel configure.ac can use it to get 
positive information from the gcc/ directory about supported targets, 
rather than through negative declarations at toplevel for unsupported 
targets.  And much the same applies to other components in a unified tree: 
negative declarations that something is unsupported are much worse than 
positive information from a subdirectory about what is supported there, 
and it would be good for one-component-only trees to be able to give 
meaningful errors if nothing useful gets built - maybe some check is 
needed to give errors if no installed host tool or target library would be 
built.

-- 
Joseph S. Myers
joseph@codesourcery.com


  reply	other threads:[~2011-03-29 23:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-29 21:52 Joseph S. Myers
2011-03-29 22:28 ` DJ Delorie
2011-03-29 23:29   ` Joseph S. Myers [this message]
2011-03-29 23:41   ` Frank Ch. Eigler
2011-03-29 23:48     ` DJ Delorie
2011-03-29 23:52     ` Joseph S. Myers
2011-03-29 22:50 ` Geoffrey Keating
2011-03-30  0:07 ` Ian Lance Taylor
2011-03-29 23:45   ` Joseph S. Myers
2011-03-30 13:37 ` Tom Tromey
2011-03-30 15:16 ` Joseph S. Myers
2011-03-30 15:34   ` DJ Delorie
2011-03-30 15:54     ` Joseph S. Myers
2011-03-31  7:44       ` Paolo Bonzini
2011-03-31 12:09         ` Joseph S. Myers
2011-03-31  7:46   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1103292321200.2595@digraph.polyomino.org.uk \
    --to=joseph@codesourcery.com \
    --cc=binutils@sourceware.org \
    --cc=dj@redhat.com \
    --cc=gcc@gcc.gnu.org \
    --cc=gdb@sourceware.org \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox