Re: gdb.mi/mi-cli.exp failures

Hans-Peter Nilsson
2003-04-01T01:09:46Z

On Mon, 31 Mar 2003, Andrew Cagney wrote:
> And this:
>
> > - return concat (filename);
> > + return filename;
>
> (remembering that the patch is backwards) doesn't look so good. It
> should be:
>
> concat (filename, NULL);
>
> perhaps
>
> xstrdup (filename)
>
> would be easier to read :-)

\begin{chant} There must be no xstrdup calls in bfd. BFD must
not abort; it's a library and the caller must handle allocation
failures. There may be xstrdup calls in bfd already, but please
don't add new ones. \end{chant}

brgds, H-P