From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-13268-listarch-gdb=sources.redhat.com@sources.redhat.com>
Received: (qmail 2259 invoked by alias); 1 Apr 2003 01:09:46 -0000
Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb/>
List-Post: <mailto:gdb@sources.redhat.com>
List-Help: <mailto:gdb-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-owner@sources.redhat.com
Received: (qmail 2224 invoked from network); 1 Apr 2003 01:09:44 -0000
Received: from unknown (HELO dair.pair.com) (209.68.1.49)
  by sources.redhat.com with SMTP; 1 Apr 2003 01:09:44 -0000
Received: (qmail 74293 invoked by uid 20157); 1 Apr 2003 01:09:39 -0000
Received: from localhost (sendmail-bs@127.0.0.1)
  by localhost with SMTP; 1 Apr 2003 01:09:39 -0000
Date: Tue, 01 Apr 2003 01:09:00 -0000
From: Hans-Peter Nilsson <hp@bitrange.com>
X-X-Sender: hp@dair.pair.com
To: Andrew Cagney <ac131313@redhat.com>
cc: David Carlton <carlton@math.stanford.edu>, gdb <gdb@sources.redhat.com>, 
     <binutils@sources.redhat.com>
Subject: Re: gdb.mi/mi-cli.exp failures
In-Reply-To: <3E88B12C.6070609@redhat.com>
Message-ID: <Pine.BSF.4.44.0303312003040.58143-100000@dair.pair.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-SW-Source: 2003-04/txt/msg00000.txt.bz2

On Mon, 31 Mar 2003, Andrew Cagney wrote:
> And this:
>
> > -	return concat (filename);
> > +	return filename;
>
> (remembering that the patch is backwards) doesn't look so good.  It
> should be:
>
> 	concat (filename, NULL);
>
> perhaps
>
> 	xstrdup (filename)
>
> would be easier to read :-)

\begin{chant} There must be no xstrdup calls in bfd.  BFD must
not abort; it's a library and the caller must handle allocation
failures.  There may be xstrdup calls in bfd already, but please
don't add new ones. \end{chant}

brgds, H-P