From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-37247-listarch-gdb=sources.redhat.com@sourceware.org>
Received: (qmail 3346 invoked by alias); 16 Apr 2010 14:32:06 -0000
Received: (qmail 3284 invoked by uid 22791); 16 Apr 2010 14:32:05 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 	tests=BAYES_00
X-Spam-Check-By: sourceware.org
Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (212.99.106.210)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Apr 2010 14:31:58 +0000
Received: from localhost (localhost [127.0.0.1]) 	by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id F1ECDCB02AB; 	Fri, 16 Apr 2010 16:31:55 +0200 (CEST)
Received: from mel.act-europe.fr ([127.0.0.1]) 	by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) 	with ESMTP id Pj9KnhQ9qeu4; Fri, 16 Apr 2010 16:31:55 +0200 (CEST)
Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67]) 	(using TLSv1 with cipher AES128-SHA (128/128 bits)) 	(No client certificate requested) 	by mel.act-europe.fr (Postfix) with ESMTP id DC6C7CB02A2; 	Fri, 16 Apr 2010 16:31:55 +0200 (CEST)
Subject: Re: Multi-gdb build failure
Mime-Version: 1.0 (Apple Message framework v1078)
Content-Type: text/plain; charset=us-ascii
From: Tristan Gingold <gingold@adacore.com>
In-Reply-To: <m38w8nok8r.fsf@hase.home>
Date: Fri, 16 Apr 2010 14:32:00 -0000
Cc: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>,   <gdb@sourceware.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <FEEAC286-40B4-4829-BDF7-666C276E03B4@adacore.com>
References: <27531.5651590519$1271404881@news.gmane.org> <m38w8nok8r.fsf@hase.home>
To: Andreas Schwab <schwab@redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb.sourceware.org>
List-Subscribe: <mailto:gdb-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00050.txt.bz2


On Apr 16, 2010, at 10:49 AM, Andreas Schwab wrote:

> "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr> writes:
>=20
>> ../../src/bfd/vms-alpha.c: In function `alpha_vms_link_add_object_symbol=
s':
>> ../../src/bfd/vms-alpha.c:7997: warning: dereferencing type-punned point=
er
>> will
>> break strict-aliasing rules
>> make[3]: *** [vms-alpha.lo] Error 1
>>=20
>>  Is there a fix to this?
>=20
> --- vms-alpha.c.~1.1.~	2010-04-14 11:24:59.000000000 +0200
> +++ vms-alpha.c	2010-04-16 10:46:19.000000000 +0200
> @@ -7975,6 +7975,7 @@ alpha_vms_link_add_object_symbols (bfd *
>     {
>       struct vms_symbol_entry *e =3D PRIV (syms)[i];
>       struct alpha_vms_link_hash_entry *h;
> +      struct bfd_link_hash_entry *h_root;
>       asymbol sym;
>=20
>       if (!alpha_vms_convert_symbol (abfd, e, &sym))
> @@ -7992,10 +7993,12 @@ alpha_vms_link_add_object_symbols (bfd *
>       else
>         h =3D NULL;
>=20
> +      h_root =3D (struct bfd_link_hash_entry *) h;
>       if (_bfd_generic_link_add_one_symbol
>           (info, abfd, sym.name, sym.flags, sym.section, sym.value,
> -           NULL, FALSE, FALSE, (struct bfd_link_hash_entry **)&h) =3D=3D=
 FALSE)
> +           NULL, FALSE, FALSE, &h_root) =3D=3D FALSE)
>         return FALSE;
> +      h =3D (struct alpha_vms_link_hash_entry *) h_root;
>=20
>       if ((e->flags & EGSY__V_DEF)
>           && h->sym =3D=3D NULL

That's look fine.  I will commit that now.

Thank you for catching that,
Tristan.