From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18930 invoked by alias); 7 Jun 2004 21:37:59 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 18919 invoked from network); 7 Jun 2004 21:37:58 -0000 Received: from unknown (HELO mail-out3.apple.com) (17.254.13.22) by sourceware.org with SMTP; 7 Jun 2004 21:37:58 -0000 Received: from mailgate2.apple.com (a17-128-100-204.apple.com [17.128.100.204]) by mail-out3.apple.com (8.12.11/8.12.11) with ESMTP id i57Lbwfo017937 for ; Mon, 7 Jun 2004 14:37:58 -0700 (PDT) Received: from relay4.apple.com (relay4.apple.com) by mailgate2.apple.com (Content Technologies SMTPRS 4.3.6) with ESMTP id for ; Mon, 7 Jun 2004 14:37:57 -0700 Received: from [17.201.22.240] (inghji.apple.com [17.201.22.240]) by relay4.apple.com (8.12.11/8.12.11) with ESMTP id i57LbtvB006242 for ; Mon, 7 Jun 2004 14:37:56 -0700 (PDT) Mime-Version: 1.0 (Apple Message framework v660) In-Reply-To: <1086598259.8126.ezmlm@sources.redhat.com> References: <1086598259.8126.ezmlm@sources.redhat.com> Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Jim Ingham Subject: Re: [Gdb] removing src/dejagnu, src/expect Date: Mon, 07 Jun 2004 21:37:00 -0000 To: gdb@sources.redhat.com X-SW-Source: 2004-06/txt/msg00044.txt.bz2 Note, there are some local patches to Expect to switch the regular expression engine that Expect uses from the new Unicode aware version back to the original Henry Spencer one that shipped with Tcl 7.x. A copy of the old Tcl regexp code was pulled into the src/ version of Expect. This was done because the new regular expression engine was subtly different from the old one, this might cause spurious testsuite failures. The ChangeLog for this is: 2001-07-09 Ian Roxborough * tclParse-compat.c: New file. * tcl_regexp.c: * tcl_regexp.h: New file. Contains Tcl8.0's regexp. * Makefile.in: Added new files to be compiled and linked. * exp_clib.c (exp_expectl, exp_fexpectl): * exp_inter.c (in_keymap, Exp_InteractCmd ): * exp_regexp.c (regtry, regdump, regprop): * expect.c (parse_expect_args, eval_case_string, exp_background_filehandler, Exp_ExpectCmd): * expect.h: * expect_comm.h: * Dbg.c (breakpoint_test, cmdBreak): Use newly built in regexp, not external Tcl regexp. * exp_tty.c (exec_stty): * exp_command.c (Exp_CloseCmd, Tcl_CloseCmd): Handle Tcl API changes in Tcl8.3. I just reran the gdb testsuite - on the Apple gdb but this shouldn't make much difference - with the Expect 5.38 from the SourceForge sources, and with Tcl 8.4.4, also from SourceForge, and I didn't see any new failures compared with the expect & tcl from src/. But this ought to be more broadly tested - and particularly with the gcc testsuite, before you do this switch. Needless to say, the Expect folks are not very likely to take Ian's patch, since all it does is downgrades the regexp engine - sticking a second copy in the Expect sources... So if there are new failures, then somebody is going to have to go through and clean up the testsuite. Jim On Jun 7, 2004, at 1:50 AM, gdb-digest-help@sources.redhat.com wrote: > > > On Sat, Jun 05, 2004 at 10:39:42AM -0400, Michael Chastain wrote: >>> At yesterday's GCC Summit testing BOF, there was a strong concensus >>> that these directories should be removed from the src tree and that >>> developers should install the latest releases of Expect and Dejagnu >>> from their distribution/packaging system or from a source tarball at >>> ftp.gnu.org. >> >> Err, I'm kinda surprised that the "GCC Summit" has enough src/ >> people to make decisions about src/. Are Andrew Cagney (gdb) >> and Daniel Jacobowitz (binutils) there? > > Yes (although I skipped the testing BOF out of sleepiness :). > > I'm redirecting this to the main GDB list. > > -- > Daniel Jacobowitz