From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-31069-listarch-gdb=sources.redhat.com@sourceware.org>
Received: (qmail 11706 invoked by alias); 17 Feb 2008 14:13:01 -0000
Received: (qmail 11646 invoked by uid 22791); 17 Feb 2008 14:13:00 -0000
X-Spam-Check-By: sourceware.org
Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 17 Feb 2008 14:12:41 +0000
Received: from eliz by fencepost.gnu.org with local (Exim 4.67) 	(envelope-from <eliz@gnu.org>) 	id 1JQkG0-0005DD-0k; Sun, 17 Feb 2008 09:12:40 -0500
From: Eli Zaretskii <eliz@gnu.org>
To: "Bin Chen" <binary.chen@gmail.com>
CC: gdb@sourceware.org
In-reply-to: <5800c1cc0802162157g3ac31acas4ae95585b9b2e263@mail.gmail.com> 	(binary.chen@gmail.com)
Subject: Re: (len % 1) != 0
Reply-to: Eli Zaretskii <eliz@gnu.org>
References:  <5800c1cc0802162157g3ac31acas4ae95585b9b2e263@mail.gmail.com>
Message-Id: <E1JQkG0-0005DD-0k@fencepost.gnu.org>
Date: Sun, 17 Feb 2008 14:13:00 -0000
X-IsSubscribed: yes
Mailing-List: contact gdb-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb.sourceware.org>
List-Subscribe: <mailto:gdb-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-owner@sourceware.org
X-SW-Source: 2008-02/txt/msg00115.txt.bz2

> Date: Sun, 17 Feb 2008 13:57:31 +0800
> From: "Bin Chen" <binary.chen@gmail.com>
> 
> Hello,
> 
> In gdb/gdbserver/server.c,
> 
> there is a line:
> 
> if ((len % 1) != 0 || unhexify (mon, own_buf + 6, len / 2) != len / 2)
> 
> I am curious that (len % 1) != 0 is always false, why put here?

It's probably a bug: they meant len % 2.