From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id zMeaB8D48GHSFgAAWB0awg (envelope-from ) for ; Wed, 26 Jan 2022 02:31:12 -0500 Received: by simark.ca (Postfix, from userid 112) id 0D0891F3B6; Wed, 26 Jan 2022 02:31:12 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 950C71EA69 for ; Wed, 26 Jan 2022 02:31:11 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D52C138515E8 for ; Wed, 26 Jan 2022 07:31:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D52C138515E8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1643182270; bh=angZsSjZw45kLyG1N7E8qtRp20f374rtJzWrD+wESB8=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=OnUH2Vu+BrkSiiE2uO544XvtH00pgA6m20s6pjSnTiR7VJm4Tdg2uo986YAMi78Ra v2nJ9j2Cp4eWIlwaOcGgERU+VaAgZsmXYYTr/7Z8RyPLzHf8uoBA3wzuYtHyelJSkx c5810yGX3nCdMVzlHqSrHMg5vAzMC+a2GWuG9xv0= Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id D7F3B385EC44 for ; Wed, 26 Jan 2022 07:30:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D7F3B385EC44 Received: by mail-pl1-x635.google.com with SMTP id y17so11256254plg.7 for ; Tue, 25 Jan 2022 23:30:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=angZsSjZw45kLyG1N7E8qtRp20f374rtJzWrD+wESB8=; b=qFNc0B5RWbKFQAeERba+dn10/al2wtsdr/Aj/sroUG19MvMmlO5zPaiGlp7PzKeevc eLCEwNTvQuNUMkQIfcbY62Q7UHhKH8I6GzNs/MlOw3Nc4qsDZKSmvZsgvlTjltmryOmE /M0ePb9nxpHgvGmcZfZU20Rz5aGF8bFG8YTNt9Maa4RejBKTOd8U1CkYP1F0cdqAzAnH rBz0aGfw/JgBsWxY8xf97pPYHomILjkXESDd0gFxFYSAyWcB9vrnqqZxlUgB09J5AtUr iiD6ZpaReQPr45lsWOGUkg6OIuuwSP+Zxj474vHzsYQ9h9K6nSrtKyuTySr+KxvsGzFv fH4g== X-Gm-Message-State: AOAM530DYhNsKDRlbiMUlnAwArmcOxu4o0jYDpQEATp53VRdY4NRHqZf H0YYnDy6k/+JuDPBsioz2oRotZ2j5tHlEsXQ2zgqKBPd8BM= X-Google-Smtp-Source: ABdhPJwKbifY2Zfz6qZL9vgcyxASMz02RRq4g5Iwtly3kcVCmL3z+6eSnvuvSUUoO+cma1KRneMP35ho86ND5YVKAVA= X-Received: by 2002:a17:90b:17c7:: with SMTP id me7mr7428454pjb.166.1643182244767; Tue, 25 Jan 2022 23:30:44 -0800 (PST) MIME-Version: 1.0 Date: Wed, 26 Jan 2022 10:30:33 +0300 Message-ID: Subject: tdesc_get_features_xml() logic To: gdb@sourceware.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Nicholas Kulikov via Gdb Reply-To: Nicholas Kulikov Errors-To: gdb-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb" Hello, What is the idea to check the precondition `tdesc->xmltarget != NULL` in assert while there is (the code below) conditional logic which handles this case? Do I miss something or there is a flaw in assert logic? gdbserver/tdesc.cc: const char * tdesc_get_features_xml (const target_desc *tdesc) { /* Either .xmltarget or .features is not NULL. */ gdb_assert (tdesc->xmltarget != NULL || (!tdesc->features.empty () && tdesc->arch != NULL)); if (tdesc->xmltarget == NULL) { std::string buffer ("@"); print_xml_feature v (&buffer); tdesc->accept (v); tdesc->xmltarget = xstrdup (buffer.c_str ()); } return tdesc->xmltarget; } This assert triggered at first call of tdesc_get_features_xml() when tdesc->xmltarget is NULL.