From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YRcaBTtj3WjRbhsAWB0awg (envelope-from ) for ; Wed, 01 Oct 2025 13:22:03 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=edFL3GVk; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0A06E1E0B6; Wed, 01 Oct 2025 13:22:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 91A311E047 for ; Wed, 01 Oct 2025 13:22:02 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 379803858409 for ; Wed, 1 Oct 2025 17:22:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 379803858409 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1759339322; bh=6ohFAw9YQzjFWGgaJbjt0nXf6CcTU4ahAMEnxN/vzvY=; h=References:In-Reply-To:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=edFL3GVkFVbIrUOXCq/MoL1Tqc/QdIkGZyGqbji+X0ShSJqKV13JFgbtVtGM6Hr1j 3JpInMr3HOR4mclsF/c3sAbNzHBYDWCcGJwc0zuv8TE9ZUFCifOCHXH/Ut4ADT5hJp lSribNaqc/6FqKi7CWiH4k6+gNnTD/P3TBX/G2ks= Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by sourceware.org (Postfix) with ESMTPS id 8866C3858427 for ; Wed, 1 Oct 2025 17:17:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8866C3858427 ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8866C3858427 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759339038; cv=none; b=EcjKiHYUwzKGazp/qNQiFkKRNUh4fesDK+oe8+uoILxFqzCH271ipqEhCpOQNf1ltL4R6tbBj6hV+P1ATBKVAu/GqAFwoCUTmh+hQwkPSotgScD8IIwjdI6oC8hlltarUJ660rMCYl6FKzKfxfpBQTBaHJBWXejjggEKAsQIfdg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759339038; c=relaxed/simple; bh=Ms306PZRtDtk1JtAxWqb67JYdb6n5h/qkmCU5RGXzqc=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=NZr9Y9az5olId2N7Zj4MAECYrO1yywM6p7X84YuRiMbVjcHwLyjOvDWNw2/9a1tMf3Iofth8iLRFJjl0kAQtzUHkOBIQe5gYNA+0j8IbmGn37aoCRRN1J73gOzJ6Z8YnqBnNm7kwprLenzaEZKZ3TlwOmGu2xtvE6sP+pDFbvB0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8866C3858427 Received: by mail-oi1-x230.google.com with SMTP id 5614622812f47-43f67a9ba58so52336b6e.3 for ; Wed, 01 Oct 2025 10:17:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759339038; x=1759943838; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=27cxQqJ9aH7ra/9Ee5+x2YNUzQtEIvG+sl3+vsc7DeQ=; b=tMDBMOxhRg4yBL36XWvPSIOz8j8qoke2Eg4N88eEgudKQJhm0WbHi/q/sTACptd5gv K+YLHp5JEjjb23YID8vAAXWxorDbM2qYh1PIN0FwzZHIzQ7qPmhCvojNv6MRhd8se3x4 +0dY5n+Xqr/bvMXsEiRw4ngOVaf+CuZ9U5H5JQMSLtTbieXNEwIr/HV2BVk6/7rfWSaS v5q1CFd7sAIGhV6leMLTi6tKen8QwR9D6k94TWj/VjulVhEhHnQy0p5F76mJ3Q/i8C/Z QlsetgTlc4v77N1jGw/skLIUj2BsGNnDnZM4zHOz05eDTNYEZF4C89B6ywQo2RcvBp+O QwVw== X-Forwarded-Encrypted: i=1; AJvYcCX3EwEOg4AInyq0qnicxNQrwPLkUorzaRD6i31mvFx6CW8s4QAD1wM7F9CdCKSAo8ArqJw=@sourceware.org X-Gm-Message-State: AOJu0Yx+jY8GaCqQVEiALfIxrWPYDIaxVXYjvUu1EV3YeU6h+H6lv71T i2fPpdE/F5CSrDMki/dt+a678Iik9Q9wM8RskrjYyEI1Npo4gW9T1WmkBFRdj7du4J0AkF2dGMG sqTE4qKQfrR3h03WciRTUCqlvI1bwA2lFNbrP X-Gm-Gg: ASbGncvUUfHH/Na0rm+vWiceZT/yE1nOzYpmN65XqwNTy1jVWmHbkJ7Sn8C2/QADT+3 TO0NEFxgzByf/SfrbmoanBroIdpNXPci6qE68brk7hTz515lBuUVSaOLOgpm7fiGa09X5SuLPSb 7+R32FLFNrO/szQbj+2A9niZTNtevI8FIQsF9n1O5xs27hE56X0h2wUG1YMoeDbcG1wB0tPjJld FyttWlql/HwgkfF7gQAKWw2ZU1iV7aopbV8r0Ogdg== X-Google-Smtp-Source: AGHT+IHDpqqyJ+rIBVKtRRnMRpXDxwugmAjQmUt3cj3aX+XW50MCS8i12urlrU+ljcTk1keCp5zcMYUS6iqIt36WCp0= X-Received: by 2002:a05:6808:190c:b0:439:af0a:dc8d with SMTP id 5614622812f47-43fa4325215mr2145651b6e.38.1759339037693; Wed, 01 Oct 2025 10:17:17 -0700 (PDT) MIME-Version: 1.0 References: <47a36f1e-28e8-4cde-92fa-adf255247f70@suse.de> In-Reply-To: <47a36f1e-28e8-4cde-92fa-adf255247f70@suse.de> Date: Wed, 1 Oct 2025 18:17:07 +0100 X-Gm-Features: AS18NWARIcHDFbSD2Wl6UmqiCpr9QqwPYUAQpuhtgYLadlysX3MAK11QKXZ3a2Q Message-ID: Subject: Re: tclint, pre-commit and patch submissions To: Tom de Vries Cc: gdb-patches , gdb@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.30 X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis via Gdb Reply-To: Luis Errors-To: gdb-bounces~public-inbox=simark.ca@sourceware.org Sender: "Gdb" Hi Tom, I'm in favor o enforcing clean commits. If we are using a linter for TCL, then I'd personally go with this option: - we make the repo refuse commits that are not pre-commit clean Or a pre-commit checker that we carry on our repo that gets run automatically. On Wed, Oct 1, 2025, 12:55 Tom de Vries wrote: > Hi, > > I've recently added a tclint pre-commit hook, and started cleaning the > testsuite. > > The current status is that all gdb.* dirs are done, with the exception > of gdb.stabs (which is going to be removed, so I skipped it). > > My question is what to do with patches adding new test-cases or > modifying existing test-cases. > > If these patches are not tclint-clean, then after commit this command: > ... > $ pre-commit run tclint --all-files > ... > will start showing new tclint errors. > > One thing that could be done at that point is to ask the > submitter/committer to fix the tclint errors. > > But there's no formal agreement atm that this need to be fixed. I've > proposed the hook, and Tom Tromey approved it, but that's just two > maintainers. > > So I'd like to know the opinion of other maintainers. > > Possible outcomes of this discussion could be that: > - we get rid of tclint in pre-commit and forget about it > - we drop one or more error categories in gdb/tclint.toml > - we require submitters to run pre-commit before submission > - we make the repo refuse commits that are not pre-commit clean > - nothing changes, and submitters can use all/some/no pre-commit hooks > for their own submissions > > Thanks, > - Tom >