From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124464 invoked by alias); 24 Feb 2017 19:01:11 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 122314 invoked by uid 89); 24 Feb 2017 19:01:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-23.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_STOCKGEN,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=sendmail X-HELO: mail-qt0-f194.google.com Received: from mail-qt0-f194.google.com (HELO mail-qt0-f194.google.com) (209.85.216.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Feb 2017 19:01:08 +0000 Received: by mail-qt0-f194.google.com with SMTP id b16so3665378qte.2 for ; Fri, 24 Feb 2017 11:01:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=WqTqdnfm7WyiT5Ys6kZkJ3hbW9+w5PvvH+ltWfmtoj8=; b=GNecOGqBmu4bR+JIOkD92FUzo8rh+1iZHbwSj4Fj4Xg/z5QXiTLsQRxYVldUgPcYIR 2eJtNWgPiyBIOmhdaGrrW9a8mJCPLozzyLU+wQWuWXmTJXalm/30V3kaIJn6NvolM3S6 FfXNmzoAP1L45zOW302QHsOpvWwy6RgeBiKWTUKOURZfzqrqITLjMn1eqvPSHGGhY9+e DfzTpFqYPevbDbRzw9k4lW4Qjkv9JGIjdTBCzSGaJNYWHgHu9JKlzX+NqG1VWg0aibfA qiRoaxZQVgxRq+LF679K2RvglmbdZYUxmTkFnsSZ9tAIHEu4wzZTUeI56HfCzJT2bhuD 4sQw== X-Gm-Message-State: AMke39lr49wXlcdQPREC7MXLd9MRwRNWAFOltw+2otzgejlEe8i5YUzyjl/vJPkKUJ9NfLTzaWOxtRA1O0jcOQ== X-Received: by 10.200.55.115 with SMTP id p48mr4142538qtb.209.1487962866830; Fri, 24 Feb 2017 11:01:06 -0800 (PST) MIME-Version: 1.0 Received: by 10.55.116.198 with HTTP; Fri, 24 Feb 2017 11:00:46 -0800 (PST) In-Reply-To: References: <20170126202406.32412-1-yyc1992@gmail.com> From: Yichao Yu Date: Fri, 24 Feb 2017 19:01:00 -0000 Message-ID: Subject: Re: [PATCH] Lookup the JIT descriptor symbol first to avoid finding the PLT entry of the breakpoint in the wrong object file. To: gdb@sourceware.org Cc: Yichao Yu Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00050.txt.bz2 Ping again. On Sun, Feb 5, 2017 at 7:46 PM, Yichao Yu wrote: > Ping. Can anyone please review this? Or is there a better place to post this? > > On Thu, Jan 26, 2017 at 3:31 PM, Yichao Yu wrote: >> On Thu, Jan 26, 2017 at 3:24 PM, Yichao Yu wrote: >>> Fix 20633 >> >> >> ..... I don't use git send-mail very often and missed the chance to >> type more comments.... >> >> The link to the bug report is >> https://sourceware.org/bugzilla/show_bug.cgi?id=20633 . I think >> ideally the interface should find all the global and local symbols and >> breakpoint on all of them since there isn't an agreement on who will >> provide it AFAICT (and for example,a process can load multiple copies >> of statically linked LLVM each providing a jit debugging interface). >> However, I'm not really sure what's the right function to use for that >> and it'll probably be a much bigger change so I went for this smaller >> change that fixes the original issue. >> >> Not sure how this should be tested....... =( >> >>> --- >>> gdb/jit.c | 17 ++++++++++------- >>> 1 file changed, 10 insertions(+), 7 deletions(-) >>> >>> diff --git a/gdb/jit.c b/gdb/jit.c >>> index 158d6d8..d6eb800 100644 >>> --- a/gdb/jit.c >>> +++ b/gdb/jit.c >>> @@ -1051,18 +1051,21 @@ jit_breakpoint_re_set_internal (struct gdbarch *gdbarch, >>> if (ps_data->objfile == NULL) >>> { >>> /* Lookup the registration symbol. If it is missing, then we >>> - assume we are not attached to a JIT. */ >>> - reg_symbol = lookup_minimal_symbol_and_objfile (jit_break_name); >>> - if (reg_symbol.minsym == NULL >>> - || BMSYMBOL_VALUE_ADDRESS (reg_symbol) == 0) >>> - return 1; >>> + assume we are not attached to a JIT. >>> + Lookup the descriptor first since looking up the breakpoint might >>> + return a PLT entry in the wrong file. */ >>> >>> - desc_symbol = lookup_minimal_symbol (jit_descriptor_name, NULL, >>> - reg_symbol.objfile); >>> + desc_symbol = lookup_minimal_symbol_and_objfile (jit_descriptor_name); >>> if (desc_symbol.minsym == NULL >>> || BMSYMBOL_VALUE_ADDRESS (desc_symbol) == 0) >>> return 1; >>> >>> + reg_symbol = lookup_minimal_symbol (jit_break_name, NULL, >>> + desc_symbol.objfile); >>> + if (reg_symbol.minsym == NULL >>> + || BMSYMBOL_VALUE_ADDRESS (reg_symbol) == 0) >>> + return 1; >>> + >>> objf_data = get_jit_objfile_data (reg_symbol.objfile); >>> objf_data->register_code = reg_symbol.minsym; >>> objf_data->descriptor = desc_symbol.minsym; >>> -- >>> 2.10.2 >>>