From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111379 invoked by alias); 17 Apr 2015 12:50:36 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 111356 invoked by uid 89); 17 Apr 2015 12:50:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,FROM_LOCAL_NOVOWEL,HK_RANDOM_ENVFROM,HK_RANDOM_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f178.google.com Received: from mail-ob0-f178.google.com (HELO mail-ob0-f178.google.com) (209.85.214.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 17 Apr 2015 12:50:33 +0000 Received: by obbeb7 with SMTP id eb7so69769470obb.3 for ; Fri, 17 Apr 2015 05:50:30 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.202.195.23 with SMTP id t23mr2602694oif.117.1429275030672; Fri, 17 Apr 2015 05:50:30 -0700 (PDT) Received: by 10.76.26.178 with HTTP; Fri, 17 Apr 2015 05:50:30 -0700 (PDT) In-Reply-To: <5530EEA3.2040809@redhat.com> References: <1429233286-6240-1-git-send-email-jcmvbkbc@gmail.com> <1429233286-6240-3-git-send-email-jcmvbkbc@gmail.com> <5530EEA3.2040809@redhat.com> Date: Fri, 17 Apr 2015 12:50:00 -0000 Message-ID: Subject: Re: [PATCH 2/2] gdbserver/xtensa: fix typo in XCHAL_HAVE_LOOPS From: Max Filippov To: Pedro Alves Cc: "gdb@sourceware.org" , Maxim Grigoriev , Woody LaRue , Marc Gauthier , "linux-xtensa@linux-xtensa.org" , Daniel Jacobowitz Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00035.txt.bz2 On Fri, Apr 17, 2015 at 2:29 PM, Pedro Alves wrote: > On 04/17/2015 02:14 AM, Max Filippov wrote: >> This fixes lbeg/lend/lcount registers handling through gdbserver. >> >> 2015-04-17 Max Filippov >> gdb/gdbserver/ >> * linux-xtensa-low.c (xtensa_fill_gregset, >> xtensa_store_gregset): fix typo in XCHAL_HAVE_LOOPS > > I was curious on whether it might have been that XCHAL_HAVE_LOOP > used to exist and was later renamed ("as in, how did this ever work It did work, only these three registers were inaccessible. > then?"), but googling around, it doesn't seem have ever existed > indeed. > > Write instead: > > 2015-04-17 Max Filippov > gdb/gdbserver/ > * linux-xtensa-low.c (xtensa_fill_gregset) > (xtensa_store_gregset): Check XCHAL_HAVE_LOOPS instead > of XCHAL_HAVE_LOOP. > > OK with that change. Ok. Can I check it in (I have write-after-approval access to binutils), or do I need to request such access to gdb separately? -- Thanks. -- Max