From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86433 invoked by alias); 26 Oct 2016 15:02:19 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 86380 invoked by uid 89); 26 Oct 2016 15:02:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=our X-HELO: mail-yb0-f181.google.com Received: from mail-yb0-f181.google.com (HELO mail-yb0-f181.google.com) (209.85.213.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Oct 2016 15:02:15 +0000 Received: by mail-yb0-f181.google.com with SMTP id 205so2399444ybg.4 for ; Wed, 26 Oct 2016 08:02:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=y4AXOr4maq+Qd0bjLpQBlFL48uNwWnQsue2prExMLlk=; b=m8qUNda+3nFMFTKjQXLME9RqDlb7XYq6GrvnQTyNJedK23o+RnC2FzJ3XYCRMvA1b2 n99lbb9U6UTxYZzTBSP6CVsNDAlZL+/zdjgYRQA6AIGLOXWW1r2Mi7TX33oFHAptF4h5 k6mFHxeuwfG6+TrNWhFK88HFovcvSj7LARWdlbLNjuwIWPHS57TVV39ZbnsqzUO7Hnvd AwU3Efp92ewmFdbxK10hITO3ikwgwXTiZGgqim6iXEr/cyqaaCK7i05tzOXilN+agwzK zUx6FGllIdg6edCGK46vlJAkrCmDMzAEVWZKK9249Xdk/xB6btxNHgyau5N2AE4SoInQ D6WQ== X-Gm-Message-State: ABUngveREWzJw8MX8+QFIrTbCtSA6okc+gyz542nYxCk8s5bKc3sQYSQu4IQx0zJVAVZH8692/Ij2MHWQ0O/OQ== X-Received: by 10.36.17.84 with SMTP id 81mr3752195itf.4.1477494134044; Wed, 26 Oct 2016 08:02:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.174.16 with HTTP; Wed, 26 Oct 2016 08:02:13 -0700 (PDT) In-Reply-To: <0c2c2c0f-bb51-7124-8a6d-d3d633788471@redhat.com> References: <651566f6-e57a-f816-8012-4080d7bc865c@redhat.com> <0c2c2c0f-bb51-7124-8a6d-d3d633788471@redhat.com> From: Ofir Cohen Date: Wed, 26 Oct 2016 15:02:00 -0000 Message-ID: Subject: Re: False positive permanent breakpoints To: Pedro Alves Cc: "gdb@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00051.txt.bz2 > I'd rather that upstreaming that bit was done when the > rest of the port is submitted as well. Alright, will do. As a temporary mitigation, Is it OK for the target to return NULL from gdbarch_breakpoint_from_pc to state that it doesn't support software breakpoints ? There are some places that check that return value, like: /* Software breakpoints unsupported? */ if (bpoint == NULL) return 0; in bp_loc_is_permanent(), and others that don't, like breakpoint_xfer_memory(). Furthermore, it performs pointer arithmetic based on the returned value. Currently the tests we have pass, but I'm concerned about other corner cases are not covered that might pop up as a result of this change. Thanks, Ofir On 26 October 2016 at 17:50, Pedro Alves wrote: > On 10/26/2016 03:42 PM, Ofir Cohen wrote: >> Hi Pedro, >> Thanks for the reply. >> Let me provide some clarifications :-). >> >> 1) The product is part of the "Intel SDK for OpenCL" [1] for Windows and Linux. >> You can see how it looks in [2]. > > Ah, OK. > >> >> 2) iGPU - Yes, Integrated GPU >> >> 3) Upstream is in our plans and actually we are preparing a clean >> series of patches on top of 7.12 (currently we are rebased on top >> of 7.6, yeah I know...). > > Nice! > > (FAOD, for upstream you'll need to rebase on master.) > >> >> 4) Software breakpoints are officially supported by the HW, but >> haven't been tested and used yet, so we're OK with them being >> "disabled" at the moment. >> >> The sources for gdb (as well as other components) are provided with >> the installer script, >> which can be downloaded _free of charge_ via [1] --> "Download" . >> >> Is that good enough for making an upstream change? >> >> I can try and prepare a small patch. > > I'd rather that upstreaming that bit was done when the > rest of the port is submitted as well. > > Thanks, > Pedro Alves >