Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Jim Wilson <jimw@sifive.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb@sourceware.org
Subject: Re: contributing the RISC-V linux native port
Date: Tue, 07 Aug 2018 16:14:00 -0000	[thread overview]
Message-ID: <CAFyWVaYJ5_FjEewyu4V2_ckpvs8RYN5REv2u9eXG7yXBSqewEw@mail.gmail.com> (raw)
In-Reply-To: <20180807130122.GI2432@adacore.com>

On Tue, Aug 7, 2018 at 6:01 AM, Joel Brobecker <brobecker@adacore.com> wrote:
> I don't think we have a specific guideline for this; my opinion is
> that you don't have to wait for something to be perfect before you
> can submit it for inclusion. What you want to ask yourself is,
> assuming your patch is improving things already (and therefore
> being helpful to you and probably others), does it have a cost
> elsewhere? For instance, will it make harder to fix something later,
> or does it break something else, etc? If, as is often the case,
> you find that the code is self contained and doesn't hurt anything
> else, why not submit it already, so others can benefit from it?
> As long as the code passes the coding standards, I don't see how
> it could hurt.

I don't expect that my patches will cause any problems.  My patch is
improving things for me already.  I've been able to use gdb to debug
binutils, gcc, and gdb issues.  But I'm a command line guy, and don't
use any fancy gdb features, so I'm not sure how it will work for
others.

I've been advertising my personal github tree on riscv mailing lists
and irc, but haven't gotten any direct feedback yet.  I did get some
indirect feedback in the form of a glibc patch from Andreas Schwab so
I suspect that he has tried it.  My tree is at
    https://github.com/jim-wilson/riscv-linux-native-gdb
if anyone wants to look at it.  See the README.md file.

I'll work on a patch set for submission.

Jim


  reply	other threads:[~2018-08-07 16:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-07  2:22 Jim Wilson
2018-08-07  6:27 ` Palmer Dabbelt
2018-08-07 13:01 ` Joel Brobecker
2018-08-07 16:14   ` Jim Wilson [this message]
2018-08-07 16:27     ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFyWVaYJ5_FjEewyu4V2_ckpvs8RYN5REv2u9eXG7yXBSqewEw@mail.gmail.com \
    --to=jimw@sifive.com \
    --cc=brobecker@adacore.com \
    --cc=gdb@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox