From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id BXHfAZoHD2S/BQ4AWB0awg (envelope-from ) for ; Mon, 13 Mar 2023 07:23:06 -0400 Received: by simark.ca (Postfix, from userid 112) id EFBDB1E223; Mon, 13 Mar 2023 07:23:05 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=ndm8lx6u; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9DB921E0D2 for ; Mon, 13 Mar 2023 07:23:05 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A243B3858436 for ; Mon, 13 Mar 2023 11:23:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A243B3858436 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1678706584; bh=4Jjp0IPjDVjgkZ8bmvKpZIv0/9hsebzJcUCPvBP48yQ=; h=References:In-Reply-To:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=ndm8lx6uE0KGKn32t0cLiDFXHPqDcMuQxSSh+EhMffw9vafQ6gJrcQC4WJdHlFfgJ AezwGaSPpYwEbCkKn9L4m2O8JSP/+qYI8H/sRChUbkFIgC01J4ixHXdHfpqLXG9N+E GDEtB4tvH3R3h3xUZ9Pf+IPQEzbE2dRk8Gchksys= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 3BBFD3858D32 for ; Mon, 13 Mar 2023 11:22:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3BBFD3858D32 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pbgG9-0008NL-6V for gdb@gnu.org; Mon, 13 Mar 2023 07:22:34 -0400 Received: by mail-pl1-x635.google.com with SMTP id ja10so2873607plb.5 for ; Mon, 13 Mar 2023 04:22:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678706551; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4Jjp0IPjDVjgkZ8bmvKpZIv0/9hsebzJcUCPvBP48yQ=; b=6ldSrGET+oTQAbKl9Tbe0KBIgMF/yKW0hXf6SDAcU3pIfFgS9zntCsZaIBLCRu7NZv 2LzfAbmlcpyIMfi/J0Cfp/0mRISIxyFf6CYp91M05eX1UK+upE8VUpbY6g9muFN03h88 KSBsI9Vr7N2EWT5bEP4L8RmCUnVtSGZWCxtrG49sqaw/Ab+wrJbLpJ11XZfdm7e+9ifk qS03nj6UAXY9lwpwQ26T4qZSXy0SABzlr/28msItvVJ+Joy5nokiXyscLyqA0MT1Zd5G AEEyBynqxfyh9g3zG659SW6PkQ3O4XX20NZZAyVLXU8WOa/qfosIUOUPWaKJzjSXI1d9 juEQ== X-Gm-Message-State: AO0yUKV03uCK6IxgQ/X7yVZuFUfH6U9DnZvTQN0i3oFeUrw+L+k7jDB6 hzYQnnTNRVe4UND1GA3CfNEbcIPNX3KxBqN7ZK9djw== X-Google-Smtp-Source: AK7set/68yCaI9xux4n/yisEv3YmWfA8kifJI6mmxM/y5Y+d/JTxDSR77mEmBGnxMJqDzra5DCVbwDfKw2iKdfS9rXI= X-Received: by 2002:a17:90b:23d2:b0:23d:20c:2065 with SMTP id md18-20020a17090b23d200b0023d020c2065mr1135077pjb.1.1678706551656; Mon, 13 Mar 2023 04:22:31 -0700 (PDT) MIME-Version: 1.0 References: <20230310103123.2118519-1-alex.bennee@linaro.org> <20230310103123.2118519-10-alex.bennee@linaro.org> <87wn3ocwqz.fsf@suse.de> <87sfeclb8o.fsf@linaro.org> In-Reply-To: <87sfeclb8o.fsf@linaro.org> Date: Mon, 13 Mar 2023 11:22:20 +0000 Message-ID: Subject: Re: [PATCH 09/11] tests/tcg: disable pauth for aarch64 gdb tests To: =?UTF-8?B?QWxleCBCZW5uw6ll?= Cc: Fabiano Rosas , qemu-devel@nongnu.org, David Hildenbrand , Wainer dos Santos Moschetta , Richard Henderson , qemu-arm@nongnu.org, Peter Xu , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Cleber Rosa , Thomas Huth , Paolo Bonzini , Beraldo Leal , gdb , Thiago Jung Bauermann , Omair Javaid Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::635; envelope-from=peter.maydell@linaro.org; helo=mail-pl1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Peter Maydell via Gdb Reply-To: Peter Maydell Errors-To: gdb-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb" On Fri, 10 Mar 2023 at 18:20, Alex Benn=C3=A9e wro= te: > > > (adding some more gdb types to CC) > > Fabiano Rosas writes: > > > Peter Maydell writes: > > > >> On Fri, 10 Mar 2023 at 10:31, Alex Benn=C3=A9e wrote: > >>> > >>> You need a very new gdb to be able to run with pauth support otherwis= e > >>> your likely to hit asserts and aborts. Disable pauth for now until we > >>> can properly probe support in gdb. > >>> > >>> Signed-off-by: Alex Benn=C3=A9e > >> > >> If it makes gdb fall over, then shouldn't we be disabling > >> the pauth gdbstub stuff entirely ? Otherwise even if our > >> tests are fine our users will not be... > >> > > > > Have you seem my message on IRC about changing the feature name in the > > XML? I think the issue is that we're putting the .xml in a "namespace" > > where GDB expects to only find stuff which it has code to > > support. Changing from "org.gnu.gdb.aarch64.pauth" to > > "org.qemu.aarch64.pauth" made it stop crashing and I can read the > > registers just fine. > > That would work, although I would prefer to probe support so we can use > the official namespace. I don't think there's a way to probe for this problem. I spoke to Luis about this, and apparently it's a bug in how gdb handles the pauth XML description (fixed in gdb commit 1ba3a3222039eb25). A gdb without any pauth support at all will be fine; a gdb with the bug will report that it has pauth support but will crash if you feed it the whole set of XML that QEMU has; a gdb with the bug fixed will also report pauth support but won't crash. (The bug only manifests if the full XML includes registers that GDB doesn't care about, like the system registers; if the stub sends only registers GDB knows about then it won't crash.) Luis and I came up with two options: (1) leave QEMU outputting the pauth xml as-is, and tell people whose gdb 12 crashes that they should upgrade to a newer gdb (2) make QEMU output the pauth info under a different XML namespace, and tell people who need backtraces when pauth is enabled that they should upgrade to a newer gdb Neither of these feel great, but on balance I guess 2 is better? Luis: I think that rather than doing (2) with a QEMU namespace, we should define a gdb namespace for this. That makes it clear that this is still a gdb-upstream-sanctioned way of exposing the pauth registers. thanks -- PMM