Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Kai Tietz <ktietz70@googlemail.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb <gdb@sourceware.org>
Subject: Re: [patch gdb]: Fix display for LLP64 target in window-nat.c
Date: Tue, 19 Feb 2013 14:59:00 -0000	[thread overview]
Message-ID: <CAEwic4b5Kg0VUUqt3_0afUdVE5YN8676jubE0zECVVMxE8wuYg@mail.gmail.com> (raw)
In-Reply-To: <20130219145158.GA29938@adacore.com>

2013/2/19 Joel Brobecker <brobecker@adacore.com>:
>> You should use %s & host_address_to_string instead of %p &
>> the various casts. So the following should work:
>>
>>       DEBUG_MEM (("gdb: write target memory, %d bytes at 0x%s\n",
>>                 len, host_address_to_string (memaddr)));
>>
>> OK with that change.
>
> Actually, I was confused. Sorry. Try either core_addr_to_string_nz
> (or core_addr_to_string if you want leading zeros)...
>

Ok, I was now confused too due host_address_to_string is requiring an
pointer as input.

Just re-testing adjusted patch and will commit then.

Thanks,
Kai


  reply	other threads:[~2013-02-19 14:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-19 14:09 Kai Tietz
2013-02-19 14:16 ` Joel Brobecker
2013-02-19 14:52   ` Joel Brobecker
2013-02-19 14:59     ` Kai Tietz [this message]
2013-02-19 16:30 ` Eli Zaretskii
2013-02-19 17:24   ` Kai Tietz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEwic4b5Kg0VUUqt3_0afUdVE5YN8676jubE0zECVVMxE8wuYg@mail.gmail.com \
    --to=ktietz70@googlemail.com \
    --cc=brobecker@adacore.com \
    --cc=gdb@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox