From: Doug Evans <dje@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Phil Muldoon <pmuldoon@redhat.com>, gdb <gdb@sourceware.org>
Subject: Re: Cleanups and Exception handlers
Date: Sat, 04 May 2013 17:52:00 -0000 [thread overview]
Message-ID: <CADPb22SGAWy101PnBR2abWxq=L5r2t8O=FomuhY_xCW+U5_S3A@mail.gmail.com> (raw)
In-Reply-To: <20130501194430.GA16791@host2.jankratochvil.net>
On Wed, May 1, 2013 at 12:44 PM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> On Wed, 01 May 2013 20:46:10 +0200, Phil Muldoon wrote:
>> > It seemed to me that there were too many TRY_CATCH blocks even in cases where
>> > nothing can throw an exception.
>>
>> This is because most (though I have no audited all of them) calls to
>> ui_out_* use *_filtered function calls (at least when the output is
>> directed to the CLI). These can be interrupted from GDB and Python
>> has to handle the resulting GDB generated keyboard interruption
>> exception. It's a massive pain in the neck. ;)
>
> Oops, OK.
A comment in the code explaining why things are the way they are
would be most welcome.
next prev parent reply other threads:[~2013-05-04 17:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 10:28 Phil Muldoon
2013-05-01 15:21 ` Jan Kratochvil
2013-05-01 18:46 ` Phil Muldoon
2013-05-01 19:44 ` Jan Kratochvil
2013-05-04 17:52 ` Doug Evans [this message]
2013-05-06 17:32 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22SGAWy101PnBR2abWxq=L5r2t8O=FomuhY_xCW+U5_S3A@mail.gmail.com' \
--to=dje@google.com \
--cc=gdb@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox