From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5135 invoked by alias); 15 Sep 2014 15:30:29 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 5110 invoked by uid 89); 15 Sep 2014 15:30:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f169.google.com Received: from mail-vc0-f169.google.com (HELO mail-vc0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 15 Sep 2014 15:30:11 +0000 Received: by mail-vc0-f169.google.com with SMTP id ij19so3614333vcb.0 for ; Mon, 15 Sep 2014 08:30:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=kDVzyWFndIHgNyoL2Qr4lM/np0rlHWx5aooB/27xlUA=; b=aXCCeb00QUYY1zAtZ3/9vI0OerBcUErscbCeUBcqFOd3tAaGxherRSmO1+t0sQwzMI SQnSpCcGVIZxZg1Hewt6OlYnNpTHkVyCtuXzPgyK5QDIFJdUAD4NlEkRCjEc7JXkWx7/ p3delKAv34iueKqGjxlXM8hDN5e4lorxGLk0wQ9+ZUQgJ9JCx010Sj9hmiSEE0Bifvyn Ylv0FLVeYzBXN9fSAmYGVX+mttAUgWZ8HwLtV80lhXKmj7vI9r8NNqUyDid4tR7T0ad6 hED9AHetGJp1G9f1Z0tc7h1Ut5GdzwkCGY8csU4u943nftgWEF4x1bDIUx8K4SqywQhK 6ZNA== X-Gm-Message-State: ALoCoQm0fHnM3cBKio0LrN7LbK1NKWZoxY6uDLnC6xEdJyzTu4nPWzhsR/2HrBah+1Riu3SnLmrm MIME-Version: 1.0 X-Received: by 10.52.139.106 with SMTP id qx10mr20075949vdb.1.1410795009289; Mon, 15 Sep 2014 08:30:09 -0700 (PDT) Received: by 10.52.181.65 with HTTP; Mon, 15 Sep 2014 08:30:08 -0700 (PDT) In-Reply-To: <20140915102949.GC13503@blade.nx> References: <20140814083231.GA6283@blade.nx> <20140814125224.GF4924@adacore.com> <54102ED8.7060307@redhat.com> <20140910162853.GT13931@adacore.com> <20140915102949.GC13503@blade.nx> Date: Mon, 15 Sep 2014 15:30:00 -0000 Message-ID: Subject: Re: ChangeLogs in commit messages From: Doug Evans To: Gary Benson Cc: Joel Brobecker , Pedro Alves , gdb , Andreas Arnez Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00056.txt.bz2 On Mon, Sep 15, 2014 at 3:29 AM, Gary Benson wrote: > Joel Brobecker wrote: >> > > E.g., I suspect this patch: >> > > >> > > https://sourceware.org/ml/gdb-patches/2014-08/msg00650.html >> > > >> > > will end up with both Gary's and Tom's name in the ChangeLog, >> > > but that's really just a guess. >> > > >> > > This makes it impossible for someone else to push the patch >> > > other than the submitter, because not all the info is there. >> > > >> > > It's a bigger issue even if someone posts a patch written or >> > > co-written by someone that might not have copyright >> > > assignment in place. >> > > >> > > I think author info must be explicit in patch submissions >> > > somehow. >> >> That's probably the strongest argument in favor of putting >> the full ChangeLog entry in the revision log. I'm just having >> a hard time accepting the fact that we going to include a date >> in the revision log which could be wrong because added by hand. >> And once it's pushed, there is no going back, so no way to fix it. >> >> Recognizing the fact that the majority of patches have one single >> author who is also the submitter, perhaps we could use the no-date/ >> no-author format for those cases, and provide a way to specify >> for those few times where necessary? Seems complicated, perhaps... > > Optional authors lines below "path/to/ChangeLog:"? > > Introduce target/target.h > > This introduces target/target.h. This file declares some functions > that the shared code can use and that clients must implement. It > also changes some shared code to use these functions. > > gdb/ChangeLog: > Tom Tromey > Gary Benson > > * target/target.h: New file. > * Makefile.in (HFILES_NO_SRCDIR): Add target/target.h. > * target.h: Include target/target.h. > ... > > gdb/gdbserver/ChangeLog: > Tom Tromey > Gary Benson > > * target.h: Include target/target.h. > * target.c (target_read_memory, target_read_uint32) > ... > > In terms of parsing, the "/ChangeLog:" marks the start of a ChangeLog > entry, and the blank line marks the end of any optional authors lines. > If no authors lines are present then the committer is the author. There's still something missing (IIUC). One of the problems that needs to be solved is documenting the author in the patch submission (the email that goes to the list). The above convention allows for a default where the absence of a name means author == committer, but we're still not specifying an absolute requirement that the patch author appears in the email sent to the list. Am I missing something?