From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0hWzGTbU7Wb3rjEAWB0awg (envelope-from ) for ; Fri, 20 Sep 2024 15:59:50 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=k/yAY68k; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 131941E353; Fri, 20 Sep 2024 15:59:50 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-11.8 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,URIBL_BLOCKED,URIBL_DBL_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1F2E41E08F for ; Fri, 20 Sep 2024 15:59:49 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9D59F385C6E1 for ; Fri, 20 Sep 2024 19:59:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9D59F385C6E1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1726862388; bh=WrbD0XLWdSrb64MgJZl7c3qJPBHZ0DeXM9Ycpgp8IIc=; h=References:In-Reply-To:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=k/yAY68kQxR2dKcFNGTiGY7/XRz88oh51wrstfmTiXw5D/SGyRkrgckZU7AjY8UXo wTKEBVQIdEfjgIW6RWEny+N5hD4vjwnimCE+vp4GdbaGlUQOPidCRPwqNQbFXsXtoW N7XYtoRHkca/e/6jwEC4ogjqqDzSz7PJ3JnRK3CU= Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 2E1FC385840F; Fri, 20 Sep 2024 19:58:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2E1FC385840F ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2E1FC385840F ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726862319; cv=none; b=QqznEuf+7/GE0ni2bDkFMAL5Doz4yux0CKfVZgsQrrQOy3rLidNSVswzWU6pkY/J2JqfmACEc73QQyFhenMtRnPKKG0y6ubTiePzZfUVZAmWGS/NdYFIsuzx54MRRBlNMrhYQljVhGvgaHLSymj+yn3+sSFfGzEwvgtkhADna5A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726862319; c=relaxed/simple; bh=+KziU1uEvfd6rdkFxi56fXKey3rG2d+pyA0PaEfzNIQ=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=UWJfNfxPSJ5CexaqIAQuuwec9eEbdRkFs/1AvO/zFGjrOnoDZEVpFMQSwRRGnE1lgcN6fytmc2zjASFebEijHjjuLYUexEE1tcOtUciFTtqz1kjofWdU+aOBb62T6q964f5g/O1FnEkxaQFtPo8AKM5+ZGT1qikMuAlxpRaItIU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a8d0d82e76aso316654166b.3; Fri, 20 Sep 2024 12:58:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726862314; x=1727467114; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WrbD0XLWdSrb64MgJZl7c3qJPBHZ0DeXM9Ycpgp8IIc=; b=plAStAy5qhCMm+Dagb7Z3s6rNvWQBfSpWd9ksqDGXdDoYH3y8pUr3WNb13rSUNlxdR JfanzfV4Wxm1yMCHamK5Madm+XV64D1aUJgo2KH1P7vPYZYzAkNTd1wTCdAORxXfGHYd kr3uqfxKlSgrmsoDoW8x7tdCoXzWLLG+lVWgkvCRZHdVbAjCAuEhH0XXZ0+yDMH6rVLI 8dz2vdZT2gBFnOjXttW4ESkx56udrgsDb3SNY83BpOgVmYWzO2XJq7+m3Y0WMvAWwUFs +RUuEq3mBzz+rh9ZgTgkVFbB9aEBsue09vFYpkm6SwL0v6w96MdeCE6VGpVT/HBJFm05 ONuw== X-Forwarded-Encrypted: i=1; AJvYcCU7KvCorSdYIAnkKtraSgI+TEk8nRspJqSq/G8D90Z4EsH0Gb+ALam057VaO6Cqi45ZTIh72D6yFA==@sourceware.org, AJvYcCUB8ep6SQ7Ul/P05yJMsBpz5ZfuOaU/W4zJmijPEPXl2x1/dSkb36LXH6bgy5yUGGb0OQpQ@sourceware.org, AJvYcCXlTeTJWDOu1b8ZEGvwf9ft3g5Eb7XYKxtFP4eny9CUZSUplc8ML0r/C1PGX9+jYw7BuHLl3JzIiJ9k2Q==@sourceware.org X-Gm-Message-State: AOJu0YztBEC8hATRWV+BzYfYH2ndDBNt24zB9h2sYnXPniqxGwfslTjC hr8MPtKxiDHeR/qRhx3cjbuj2mBbhYVb65UOlsnBN/JBF9wrMlozwcOKB5nTFIR616YMi1M5Xyw mcSM2kE7SPB6DvgffJVPfivlRq+8= X-Google-Smtp-Source: AGHT+IHNAQvas9IH7Kv9EfjGUg+IpCzEwdPuHZVFjk3zjt93eRPzl2Tr5TRC2x0G8VsRK8+svzmMRBrxxeSSvvzQTYA= X-Received: by 2002:a17:907:d26:b0:a86:894e:cd09 with SMTP id a640c23a62f3a-a90d55de441mr365726366b.9.1726862313422; Fri, 20 Sep 2024 12:58:33 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Fri, 20 Sep 2024 19:58:21 +0000 Message-ID: Subject: Re: On pull request workflows for the GNU toolchain To: Joseph Myers Cc: gcc@gcc.gnu.org, libc-alpha@sourceware.org, binutils@sourceware.org, gdb@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Matt Rice via Gdb Reply-To: Matt Rice Errors-To: gdb-bounces~public-inbox=simark.ca@sourceware.org Sender: "Gdb" On Thu, Sep 19, 2024 at 3:52=E2=80=AFPM Joseph Myers via Gdb wrote: > > 1. Introduction > > This message expands on my remarks at the Cauldron (especially the > patch review and maintenance BoF, and the Sourceware infrastructure > BoF) regarding desired features for a system providing pull request > functionality (patch submission via creating branches that are then > proposed using some kind of web interface or API, with a central > database then tracking the status of each pull request and review > comments thereon automatically), I wasn't at Cauldron, but I just wanted to say that a lot of the web-based interfaces (git-lab, github, gitea, gogs, etc) for providing pull request functionality pre-date the existence of git-protocol features that also allow you to implement the pull request type behavior, the git proc receive hook https://git-scm.com/docs/githooks#proc-receive can be used to implement a pull-request style workflow without the web interface. This is somewhat going against the grain, and has a less developed ecosystem of clients/servers/hosting resources, I haven't kept up to date with what tools are actually available, last I looked though the only tool I knew of using it was https://git-repo.info/en/ for the client, and I written a prototype implementation using the hook as a server (as far as I know the only other server tools using this are the proprietary codeup.aliyun which might be internal to alibaba?). To me though it is nice being able to edit the PR cover letter directly in the editor, and do the pull-request using command line tools. What draws me to this however, is that it allows me to set up an in-house review process using the same set of tools that eventually feeds into upstream while mirroring the CI architecture locally. That is the dream anyway and in my opinion represents the style of pull request workflow we should be aiming for if we want something ideal. Anyhow, IMO a big reason why all of these workflows are so centralized is just that they are going outside the git protocol. To me the work that has been done seems promising as a proof of concept distributed pull request system, and what it is probably lacking is putting an actual web-based interface on top of the git protocol based design and a lot of spit and polish. At least to me the whole sourceware ecosystem feels like an ideal candidate for this, since it is much more common to have ports in progress to unfinished or unreleased instruction sets, than would happen with almost any other piece of software. So there is some amount of justification for going against the grain of a centralized system imo.