From: Siddhesh Poyarekar <siddhesh.poyarekar@gmail.com>
To: Andreas Jaeger <aj@suse.com>
Cc: Siddhesh Poyarekar <siddhesh@redhat.com>,
GNU C Library <libc-alpha@sourceware.org>,
gdb@sourceware.org, carlos@redhat.com, fche@redhat.com,
gbenson@redhat.com
Subject: Re: patchwork.sourceware.org is live!
Date: Mon, 26 May 2014 07:37:00 -0000 [thread overview]
Message-ID: <CAAHN_R0zVp8B7zXfARzvKvETx9kLZp1FYPN9pUWDwV4cNCjCvA@mail.gmail.com> (raw)
In-Reply-To: <5382E7F2.4020506@suse.com>
On 26 May 2014 12:36, Andreas Jaeger <aj@suse.com> wrote:
> A patch that is merged, should have "Accepted", correct? so, patches
> that are already committed should be changed to have this...
>
> If i just comment on a patch with a "Looks fine", should I say "Under
> Review" - and then the submitter sets this to "Accepted"?
'Under Review' is a transitional state for a reviewer to 'take' a
patch off the queue for review.
We don't differentiate between review completion and commit; I guess
we should since the reviewer is not always responsible for commiting
the change. May I add an additional status 'Committed' to indicate
this? That way a reviewer sets 'Accepted' when the patch looks good
and the committer changes state to 'Committed' when the change is in
git. If the reviewer commits the change herself (i.e. when the
submitter does not have commit access), the former may set status to
'Committed' directly.
Thoughts?
Siddhesh
--
http://siddhesh.in
next prev parent reply other threads:[~2014-05-26 7:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 21:12 Siddhesh Poyarekar
2014-05-24 3:20 ` Siddhesh Poyarekar
2014-05-24 4:02 ` David Miller
2014-05-24 7:28 ` Eli Zaretskii
2014-05-26 7:06 ` Siddhesh Poyarekar
2014-05-26 7:29 ` Andreas Jaeger
2014-05-26 7:37 ` Siddhesh Poyarekar [this message]
2014-05-26 7:52 ` Andreas Jaeger
2014-05-26 8:02 ` Siddhesh Poyarekar
2014-05-26 9:59 ` Andreas Jaeger
2014-05-26 10:41 ` Ondřej Bílka
2014-05-26 11:05 ` Siddhesh Poyarekar
2014-05-26 14:31 ` Ondřej Bílka
2014-05-30 2:59 ` Samuel Bronson
2014-05-30 8:36 ` Siddhesh Poyarekar
2014-05-30 8:45 ` Pedro Alves
2014-05-30 8:55 ` Pedro Alves
2014-05-30 14:38 ` Siddhesh Poyarekar
2014-06-05 11:36 ` Pedro Alves
2014-06-05 11:51 ` Siddhesh Poyarekar
2014-06-04 10:28 ` Ondřej Bílka
2014-05-26 10:21 ` Florian Weimer
2014-05-26 11:18 ` Carlos O'Donell
2014-05-26 15:09 ` Andreas Jaeger
2014-05-27 6:22 ` Carlos O'Donell
2014-05-27 6:27 ` Thomas Schwinge
2014-05-27 6:53 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAHN_R0zVp8B7zXfARzvKvETx9kLZp1FYPN9pUWDwV4cNCjCvA@mail.gmail.com \
--to=siddhesh.poyarekar@gmail.com \
--cc=aj@suse.com \
--cc=carlos@redhat.com \
--cc=fche@redhat.com \
--cc=gbenson@redhat.com \
--cc=gdb@sourceware.org \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox