Re: [PATCH] Debugging Vector Types

[Devang Patel <dpatel@apple.com>]

[-- Attachment #1: Type: text/plain, Size: 784 bytes --]


On Apr 24, 2005, at 3:35 PM, Daniel Jacobowitz wrote:

> On Fri, Apr 22, 2005 at 05:52:14PM -0700, Geoff Keating wrote:
>> I don't think there's any reason to (but if anyone else does,  
>> speak up!)
>
> I agree; please don't make this Darwin-specific.
>
>>>> - You need to update stabs.texi, which I think lives in GDB.  (It's
>>>>  the only stabs documentation we have, so keeping it up-to-date is
>>>>  important!)
>>>
>>> The doc version I have already lists it as an extension.
>>
>> Excellent, then there's no need for any changes there.
>
> Yes, in fact GDB already accepts this attribute for stabs.

OK. I'll check-in this smaller patch tomorrow.

         * dbxout.c (dbxout_type): Emit attribute vector.

         * gcc.dg/stabs-attrib-vect-darwin.c: New test.

-
Devang


[-- Attachment #2: stabs_vector.take2.diff --]
[-- Type: application/octet-stream, Size: 2499 bytes --]

Index: dbxout.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/dbxout.c,v
retrieving revision 1.227
diff -Idpatel.pbxuser -c -3 -p -r1.227 dbxout.c
*** dbxout.c	12 Apr 2005 20:39:04 -0000	1.227
--- dbxout.c	25 Apr 2005 02:11:19 -0000
*************** dbxout_type (tree type, int full)
*** 1652,1662 ****
    tree tem;
    tree main_variant;
    static int anonymous_type_number = 0;
  
    if (TREE_CODE (type) == VECTOR_TYPE)
!     /* The frontend feeds us a representation for the vector as a struct
!        containing an array.  Pull out the array type.  */
!     type = TREE_TYPE (TYPE_FIELDS (TYPE_DEBUG_REPRESENTATION_TYPE (type)));
  
    /* If there was an input error and we don't really have a type,
       avoid crashing and write something that is at least valid
--- 1652,1666 ----
    tree tem;
    tree main_variant;
    static int anonymous_type_number = 0;
+   bool vector_type = false;
  
    if (TREE_CODE (type) == VECTOR_TYPE)
!     {
!       /* The frontend feeds us a representation for the vector as a struct
! 	 containing an array.  Pull out the array type.  */
!       type = TREE_TYPE (TYPE_FIELDS (TYPE_DEBUG_REPRESENTATION_TYPE (type)));
!       vector_type = true;
!     }
  
    /* If there was an input error and we don't really have a type,
       avoid crashing and write something that is at least valid
*************** dbxout_type (tree type, int full)
*** 1991,1996 ****
--- 1995,2006 ----
  	  break;
  	}
  
+       if (vector_type)
+ 	{
+ 	  have_used_extensions = 1;
+ 	  stabstr_S ("@V;");
+ 	}
+ 
        /* Output "a" followed by a range type definition
  	 for the index type of the array
  	 followed by a reference to the target-type.
Index: testsuite/gcc.dg/stabs-attrib-vect-darwin.c
===================================================================
RCS file: testsuite/gcc.dg/stabs-attrib-vect-darwin.c
diff -N testsuite/gcc.dg/stabs-attrib-vect-darwin.c
*** /dev/null	1 Jan 1970 00:00:00 -0000
--- testsuite/gcc.dg/stabs-attrib-vect-darwin.c	25 Apr 2005 02:11:21 -0000
***************
*** 0 ****
--- 1,11 ----
+ /* Test Attribute Vector associated with vectory type stabs.  */
+ /* { dg-do compile { target powerpc*-*-darwin* } } */
+ /* { dg-options "-gstabs -fno-eliminate-unused-debug-types -faltivec" } */
+ 
+ int main ()
+ {
+   vector int vi = { 6,7,8,9 };
+   return 0;
+ }
+ 
+ /* { dg-final { scan-assembler ".stabs.*vi\:\\(0,16\\)=\@V" } } */
Index: testsuite/gcc.dg/stabs-attrib-vect.c

[-- Attachment #3: Type: text/plain, Size: 1 bytes --]