From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id DjRGFevfHmXNrSUAWB0awg (envelope-from ) for ; Thu, 05 Oct 2023 12:10:19 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=DOYpzV7k; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4D6DA1E0C3; Thu, 5 Oct 2023 12:10:19 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 374C91E092 for ; Thu, 5 Oct 2023 12:10:17 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AE7273861912 for ; Thu, 5 Oct 2023 16:10:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AE7273861912 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1696522216; bh=xAS3K6jxX7Pbv4qTR3ozxSGXk3l1nqFnH6a7q8raBOQ=; h=Date:Subject:References:To:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=DOYpzV7kQpAH81Xpe8vLnC8/YONRD8U4lj2+5JDsGmt3YALJOUaczWaKBZ05fX9u8 ItOYxlwf3/LP05hTorVzj5MXEwwaKiBTQnVGq/qdLhmpgxggn0NkI4j+2vIbWp1Ro/ xvyVyM1TB+FmxcOQYg1DX64vwYHbjy2YErj1XHpI= Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by sourceware.org (Postfix) with ESMTPS id 86CD1385842C for ; Thu, 5 Oct 2023 16:09:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 86CD1385842C Received: by mail-io1-xd36.google.com with SMTP id ca18e2360f4ac-79fa7e33573so50487439f.0 for ; Thu, 05 Oct 2023 09:09:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696522186; x=1697126986; h=in-reply-to:from:to:references:content-language:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=xAS3K6jxX7Pbv4qTR3ozxSGXk3l1nqFnH6a7q8raBOQ=; b=jaKqo6l1CXBGb9hRttHianzTjA1oCqkLcbLJYOTRP/xz6NwP6PtuAV9ckcKCw5LLmS PL4B0/tvGrJK+x5DcQ/Lun3cNMjqeLt+KeTSS8lDySMckl+GwHDCysZyZzBAISINLtFX Ls7MWbSYpWZTlaZB18W7PbZO8J6hVcQwhqwQV02SzoT8ciLnQPKuuuiv7/55uOoVrQAS dhGOAJSfp814IBaBf/TnQJoH4kbZlfYxLj0K6aY+Kycz1A3mXEHui5K2nVv1vSehce+O jw6aeFf3saocT938ygpQJPoIz2wUEWycokj1uK55QtM81rmWSqqcCHP6VASAv+XgB9jA Jdpg== X-Gm-Message-State: AOJu0YxaxyBPXEYcPRbI2Bp6r+5NtHoHq7R7zzjdhhjEDSQ2Z1MPL8YG o9WjnXME+QU887qcvjR0Vgd3a5vUi8c= X-Google-Smtp-Source: AGHT+IEl61J9gIvHaNmHK+/aEIWMP51ChGxZdHLycJBPtUHNRuzKatfGXxDLwveYPhrcKmCOWwU2hQ== X-Received: by 2002:a5e:dd0d:0:b0:786:7100:72de with SMTP id t13-20020a5edd0d000000b00786710072demr5777138iop.16.1696522186259; Thu, 05 Oct 2023 09:09:46 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id g21-20020a02cd15000000b0042b37dda71asm22447jaq.136.2023.10.05.09.09.45 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Oct 2023 09:09:45 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------6dvUAzpo3A0GkYUwZYYuOw04" Message-ID: <9f2c4844-c2ef-417b-ba09-9f71c7066759@gmail.com> Date: Thu, 5 Oct 2023 10:09:44 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Fwd: [RFA] Fix for mcore simulator Content-Language: en-US References: <1d854df9-b28c-41eb-af7c-e3a423885558@gmail.com> To: gdb@sourceware.org In-Reply-To: <1d854df9-b28c-41eb-af7c-e3a423885558@gmail.com> X-Forwarded-Message-Id: <1d854df9-b28c-41eb-af7c-e3a423885558@gmail.com> X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Jeff Law via Gdb Reply-To: Jeff Law Errors-To: gdb-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb" This is a multi-part message in MIME format. --------------6dvUAzpo3A0GkYUwZYYuOw04 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Wrongly sent to binutils initially... -------- Forwarded Message -------- Subject: [RFA] Fix for mcore simulator Date: Wed, 4 Oct 2023 16:09:35 -0600 From: Jeff Law To: Binutils I was looking for cases where a GCC patch under evaluation would cause test results to change. Quite surprisingly the mcore-elf port showed test differences. After a fair amount of digging my conclusion was the sequences before/after the patch should have been semantically the same. Of course if the code is supposed to behave the same, then that points to problems elsewhere (assembler, linker, simulator). Sure enough the mcore simulator was mis-handling the sign extension instructions. The simulator implementation of sextb is via paired shift-by-24 operations. Similarly the simulator implements sexth via paired shift-by-16 operations. The temporary holding the value was declared as a "long" thus this approach worked fine for hosts with a 32 bit wide long and failed miserably for hosts with a 64 bit wide long. This patch makes the shift count automatically adjust based on the size of the temporary. It includes a simple test for sextb and sexth. I have _not_ done a full audit of the mcore simulator for more 32->64 bit issues. This also fixes 443 execution tests in the GCC testsuite ;-) OK for the trunk? Thanks, Jeff --------------6dvUAzpo3A0GkYUwZYYuOw04 Content-Type: text/plain; charset=UTF-8; name="mcore-sim.patch" Content-Disposition: attachment; filename="mcore-sim.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL3NpbS9tY29yZS9pbnRlcnAuYyBiL3NpbS9tY29yZS9pbnRlcnAuYwpp bmRleCA1M2NmZGFkMDUwYi4uNDhkOWZmODY0NWEgMTAwNjQ0Ci0tLSBhL3NpbS9tY29yZS9p bnRlcnAuYworKysgYi9zaW0vbWNvcmUvaW50ZXJwLmMKQEAgLTY0MSw4ICs2NDEsOCBAQCBz dGVwX29uY2UgKFNJTV9ERVNDIHNkLCBTSU1fQ1BVICpjcHUpCiAJICAgICAgewogCQlsb25n IHRtcDsKIAkJdG1wID0gZ3JbUkRdOwotCQl0bXAgPDw9IDI0OwotCQl0bXAgPj49IDI0Owor CQl0bXAgPDw9IChzaXplb2YgKHRtcCkgKiA4KSAtIDg7CisJCXRtcCA+Pj0gKHNpemVvZiAo dG1wKSAqIDgpIC0gODsKIAkJZ3JbUkRdID0gdG1wOwogCSAgICAgIH0KIAkgICAgICBicmVh azsKQEAgLTY1Myw4ICs2NTMsOCBAQCBzdGVwX29uY2UgKFNJTV9ERVNDIHNkLCBTSU1fQ1BV ICpjcHUpCiAJICAgICAgewogCQlsb25nIHRtcDsKIAkJdG1wID0gZ3JbUkRdOwotCQl0bXAg PDw9IDE2OwotCQl0bXAgPj49IDE2OworCQl0bXAgPDw9IChzaXplb2YgKHRtcCkgKiA4KSAt IDE2OworCQl0bXAgPj49IChzaXplb2YgKHRtcCkgKiA4KSAtIDE2OwogCQlncltSRF0gPSB0 bXA7CiAJICAgICAgfQogCSAgICAgIGJyZWFrOwpkaWZmIC0tZ2l0IGEvc2ltL3Rlc3RzdWl0 ZS9tY29yZS9zZXh0Yi5zIGIvc2ltL3Rlc3RzdWl0ZS9tY29yZS9zZXh0Yi5zCm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwLi41NTAwZjdhYmU2NwotLS0gL2Rldi9u dWxsCisrKyBiL3NpbS90ZXN0c3VpdGUvbWNvcmUvc2V4dGIucwpAQCAtMCwwICsxLDI1IEBA CisjIGNoZWNrIHRoYXQgc2V4dC5iL3NleHQuaCB3b3JrIGNvcnJlY3RseQorIyBtYWNoOiBt Y29yZQorCisuaW5jbHVkZSAidGVzdHV0aWxzLmluYyIKKworCXN0YXJ0CisJIyBDb25zdHJ1 Y3QgLTEyMCB1c2luZyBiZ2VuaSthZGRpK3NleHQKKwliZ2VuaQlyMiwgNworCWFkZGkJcjIs OAorCXNleHRiCXIyCisKKwkjIENvbnN0cnVjdCAtMTIwIHVzaW5nIG1vdmkrbm90CisJbW92 aQlyNywxMTkKKwlub3QJcjcKKworCSMgQ29tcGFyZSB0aGVtLCB0aGV5IHNob3VsZCBiZSBl cXVhbAorCWNtcG5lCXIyLHI3CisJamJ0CS5MMQorCXBhc3MKKy5MMToKKwlmYWlsCisKKwor CisKZGlmZiAtLWdpdCBhL3NpbS90ZXN0c3VpdGUvbWNvcmUvc2V4dGgucyBiL3NpbS90ZXN0 c3VpdGUvbWNvcmUvc2V4dGgucwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMC4uOTcyNzljNDllZDQKLS0tIC9kZXYvbnVsbAorKysgYi9zaW0vdGVzdHN1aXRlL21j b3JlL3NleHRoLnMKQEAgLTAsMCArMSwyNyBAQAorIyBjaGVjayB0aGF0IHNleHQuYi9zZXh0 Lmggd29yayBjb3JyZWN0bHkKKyMgbWFjaDogbWNvcmUKKworLmluY2x1ZGUgInRlc3R1dGls cy5pbmMiCisKKwlzdGFydAorCSMgQ29uc3RydWN0IC0zMjc2MCB1c2luZyBiZ2VuaSthZGRp K3NleHQKKwliZ2VuaQlyMiwgMTUKKwlhZGRpCXIyLDgKKwlzZXh0aAlyMgorCisJIyBDb25z dHJ1Y3QgLTMyNzYwIHVzaW5nIGJtYXNrK3N1Ymkrbm90CisgICAgICAgIGJtYXNraSAgcjcs MTUKKyAgICAgICAgc3ViaSAgICByNyw4ICAgIC8vIDMyNzU5IDB4N2ZmNworCW5vdAlyNwor CisKKwkjIENvbXBhcmUgdGhlbSwgdGhleSBzaG91bGQgYmUgZXF1YWwKKwljbXBuZQlyMixy NworCWpidAkuTDEKKwlwYXNzCisuTDE6CisJZmFpbAorCisKKworCg== --------------6dvUAzpo3A0GkYUwZYYuOw04--