From: Carlos O'Donell <carlos@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: GNU C Library <libc-alpha@sourceware.org>, gdb@sourceware.org
Subject: Re: PSA: Formalizing the glibc<->gdb probe-based interface.
Date: Wed, 13 Feb 2019 18:47:00 -0000 [thread overview]
Message-ID: <9bab99fb-fe91-f214-ccb6-c16739f8d231@redhat.com> (raw)
In-Reply-To: <87k1i3628v.fsf@tromey.com>
On 2/13/19 12:13 PM, Tom Tromey wrote:
>>>>>> "Carlos" == Carlos O'Donell <carlos@redhat.com> writes:
>
> Carlos> We document *other* probes in manual/probes.texi, but we should
> Carlos> add a section for stable guaranteed probes, and discuss a way
> Carlos> to deprecate the probes should we ever need to do that.
>
> Because probes are introspectable, it's actually better to remove them
> than to change their semantics -- the tools can adapt more easily to
> this. Of course it's good to have a transition period, or at least some
> sort of warning.
>
> As I recall we had some thoughts about ABI compatibility when adding the
> probes; namely that it is ok to add arguments to the end, but not ok to
> remove arguments or to change the meaning of existing arguments.
Agreed.
In general I think the probe name should always change if:
* semantics change.
* # of arguments change.
Then you'll always be safe.
If you can't keep implementing the probe it is safest to remove it.
Talk to the users of the probe first and reach consensus :-)
--
Cheers,
Carlos.
prev parent reply other threads:[~2019-02-13 18:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f73d8f0d-32ac-487d-8f90-fdac7b1be8e8@redhat.com>
2019-02-13 17:13 ` Tom Tromey
2019-02-13 18:47 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bab99fb-fe91-f214-ccb6-c16739f8d231@redhat.com \
--to=carlos@redhat.com \
--cc=gdb@sourceware.org \
--cc=libc-alpha@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox