From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eli Zaretskii" To: drow@mvista.com Cc: gdb@sources.redhat.com Subject: Re: [rfc] Completion tests failing Date: Thu, 27 Sep 2001 01:39:00 -0000 Message-id: <9743-Thu27Sep2001103949+0300-eliz@is.elta.co.il> References: <20010926211336.A31592@nevyn.them.org> X-SW-Source: 2001-09/msg00231.html > Date: Wed, 26 Sep 2001 21:13:36 -0400 > From: Daniel Jacobowitz > > The test failing for me right now is completion for 'p "a'. The > comments, and the testsuite, say that this is a string literal and should > not be completed. This is no longer true, so the test suite should be changed. > The code tries to complete it as a location, though, and > decides to run it through location_completer. make_symbol_completion_list > notices the stray ", and decides not to allow completion; but > make_source_files_completion_list does no such thing. This is intended behavior, I think: source files can have quotes in them. > Which behavior would people prefer? I can update the testsuite to match. > I'd also like to add expressions like: > > -re "^p \"a\[^\"\]*\"$" { fail "complete 'p \"a'" } > > if it is not supposed to complete; that is, if gdb completes it to something > and supplies the trailing quote, fail now, instead of waiting for timeout > and failing the next dozen tests too. Given the recent changes to completion, I really don't see any sense in testing this. I'd suggest to delete the test.