From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id DgKFJkne7WbhtjEAWB0awg (envelope-from ) for ; Fri, 20 Sep 2024 16:42:49 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=gZ1Gzvcf; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5D8411E353; Fri, 20 Sep 2024 16:42:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-11.8 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,URIBL_DBL_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 979D51E08F for ; Fri, 20 Sep 2024 16:42:48 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3877D385B50D for ; Fri, 20 Sep 2024 20:42:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3877D385B50D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1726864968; bh=1vc6QHiNrpNZG8NmiF5SnbBqlbbB2N9wkMmuQrDElt4=; h=Date:To:cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=gZ1GzvcfNW0Vc+8l47qvPkmEwLUJ818b/A6iTpa2Va9bN5Jhp8l89sPTVHkJLFacl 6F08Nui1Uv17q/EEQQtVA2XKx71+8eY/ygdwr4dkX1fX0N26Re1vU/rYj20BWrAJMZ lW5vZGTEEo3N/GrwHjqSpQproZBKG3LfRPYhEFHs= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 540AD3858C98 for ; Fri, 20 Sep 2024 20:41:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 540AD3858C98 ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 540AD3858C98 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726864915; cv=none; b=TOVxLKXriH7BVo89Ee6jzQ5K2Pinnef5kFITYHHhPwkvgABs8Y1u6q0hwwh6tZQPw1zLhxh6GnEt2TFxFcBVheRixp6XuelemOSt8ACggyBMkb1z7e+pR5lAr2P9eMMq+iPgGx1oo11spxCKUjAAMD9yxvbMzXSJzBAIKwikiRQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726864915; c=relaxed/simple; bh=6L2va1hDzBZ0QSLRoJmJ1Z6rdydsNQF0XkwERgL1FVM=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=LgaYFJouCU9j0r9TeoFzwOLEz2NPgAyCTEXwGGu/RqeMOdxjKsuf+lsIP+N8pU88uArG71kzcybHAzCUzTC8aEC6IYVUk4N7m3PsOZf4yziHZuxsbYNlLdc7lGCPRBWsE7XeHcSfp3U6YAx6IF7BdS5t2qf85kKJox9QWzW4NOo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-122-QoPNnw7xMMKnX5plCrZDXQ-1; Fri, 20 Sep 2024 16:41:52 -0400 X-MC-Unique: QoPNnw7xMMKnX5plCrZDXQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-42cb6f3c476so18377935e9.0 for ; Fri, 20 Sep 2024 13:41:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726864911; x=1727469711; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1vc6QHiNrpNZG8NmiF5SnbBqlbbB2N9wkMmuQrDElt4=; b=Bo3wpwdq/9uJTZvn0i1OwiO3hftLBfd9vCVhpdsfOGCjZoP7P9VdWKYJWyXECsoaA/ ZoDjE7LDV5KJIOV3eBbqunf9SZOZQHQJh78O6kHav76NNIhwzszIi05oGJaW2tDlmbbC gOEUpuUoDNuLMYlywcPx71lxIm5GbwaMyLfhKalTLOG6gT0qpEDcQywV/OztAKONF1HB bY/5YZz66DAeYoohiCFEZv8LCsG6pMF4OHOz8MyA5JA7hk0DLCcwLUH7JK3UufpA4BoT qxFrOjBbmTlGOe3VU3YDxeYBf92/v+GEhiJyZomEpWak9sBHEcc93+CN8loJ2bGKDVlp whoA== X-Forwarded-Encrypted: i=1; AJvYcCW42XzpwKKz3rURLYOzUopcTvkaLFuzvHwCwZ8FzRWmFPsBX8U7hM9AgLIKtynUusZKT80=@sourceware.org X-Gm-Message-State: AOJu0YxdruiALo8VdTj5Lxsv0ITM7rC0zq7ad8Q+6eb2EG2hWCSLYXq4 zgKcgzmn2Tvdn5aW/tKO9N30RWhiF9dWqc7Otj1rGYAqyhIVKqkTVc4J5Xo8xyE9+4ZZatosaIC NTFeDtDnbS2CnRgeEwUR8QpbIormvnq9+SmCYwrekSKj5hl55 X-Received: by 2002:a05:600c:468a:b0:42c:b995:20d9 with SMTP id 5b1f17b1804b1-42e7adbdbbbmr32110865e9.28.1726864911445; Fri, 20 Sep 2024 13:41:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH9wLWuz5dRBz1eWxN/e0LFwGp61GeENcaG+bBwD6kcqR38MmEe7MytdAjhnN0MEq6ZYkP3wA== X-Received: by 2002:a05:600c:468a:b0:42c:b995:20d9 with SMTP id 5b1f17b1804b1-42e7adbdbbbmr32110705e9.28.1726864910976; Fri, 20 Sep 2024 13:41:50 -0700 (PDT) Received: from digraph.polyomino.org.uk (digraph.polyomino.org.uk. [2001:8b0:bf73:93f7::51bb:e332]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e7afeb1c2sm31727695e9.36.2024.09.20.13.41.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2024 13:41:50 -0700 (PDT) Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.97) (envelope-from ) id 1srkRo-00000006HKY-4130; Fri, 20 Sep 2024 20:41:48 +0000 Date: Fri, 20 Sep 2024 20:41:48 +0000 (UTC) To: Carlos O'Donell cc: gcc@gcc.gnu.org, libc-alpha@sourceware.org, binutils@sourceware.org, gdb@sourceware.org Subject: Re: On pull request workflows for the GNU toolchain In-Reply-To: <975a575f-1284-4902-81a9-331e4d1f90d4@redhat.com> Message-ID: <927637c6-c0ac-1efe-b1ae-d2dfdbcfc02a@redhat.com> References: <975a575f-1284-4902-81a9-331e4d1f90d4@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Joseph Myers via Gdb Reply-To: Joseph Myers Errors-To: gdb-bounces~public-inbox=simark.ca@sourceware.org Sender: "Gdb" On Fri, 20 Sep 2024, Carlos O'Donell via Gcc wrote: > > (e) All existing pre-commit checks from hooks should be kept in some > > form, to maintain existing invariants on both tree and commit contents > > (some hook checks make sure that commits don't have commit messages > > that would cause other automated processes to fall over later, for > > example). > > These could all move to pre-commit CI checks that block merging. Checks are supposed to apply to direct pushes as well as to merging through the PR system. (Direct pushes should I hope end up being rare on mainline, not necessarily rare on other branches. Some invariants of commit history should apply to all commits on all refs, e.g. that no-one accidentally copies an old GCC commit message in a way that confuses tooling searching for From-SVN: lines. On mainline, we might eventually want an *additional* check on direct pushes, e.g. that they have a Reason-for-direct-push: line that explains why the commit can't go through the PR system.) Obviously this does not assert what technology should be used to implement such checks on permitted ref updates in the repository (though hopefully as little code as possible is executed in the repository context, as much as possible in some separate isolated context). And arranging the implementation so as much code as possible can be used both when checking the final ref update, and in CI to check a PR that would result in such a ref update if accepted, is desirable (just as e.g. GCC shares code between the cron job that does ChangeLog updates, and the hook that checks if commits have properly formatted ChangeLog entries - though there are unfortunately still some cases that only result in the cron job falling over, not in the commits being rejected at push time). -- Joseph S. Myers josmyers@redhat.com