From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id HwMGIzCvImanJjUAWB0awg (envelope-from ) for ; Fri, 19 Apr 2024 13:51:44 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=Ac1tIneq; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 803041E0C0; Fri, 19 Apr 2024 13:51:44 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6BD7F1E030 for ; Fri, 19 Apr 2024 13:51:42 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 14CFE3847700 for ; Fri, 19 Apr 2024 17:51:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 14CFE3847700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1713549102; bh=OwVsJRwm5+XtEktHc1/4Sx+MuBaZCHULZYuZu2dMyIY=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=Ac1tIneqqZDNtqFCU1a4HBcNF5lM7HrWknPlfLCH1hJ7qnlmeMx7zAN8XhAvE2IuN 9drx5bOcGzemSNy3GkUSEdMFrIp/PJ08ouYMJLIVIq1b/6noassrXHo4SdqyVN6M8z At/yg1bnAuhZlOnnRI6Dgxlq5XFZCxu+mpR9Wg2U= Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id BDA383849ACB for ; Fri, 19 Apr 2024 17:51:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BDA383849ACB ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BDA383849ACB ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713549066; cv=none; b=DBmgwKd7zB96ZbnKeBkiiNaZfrYXDxN19MXhFUoywBGJxngRQMInRReBmxI5iT15Y8E6yndrr80lPLd68e/ArDLwTAkOUBeGDZZMRpHKZWw4ow+ytzwuDZzgQpLwkHDV4D1XBLubpq+tp4FlbczhWwz3mbeA5B/+SjlUEVx6w98= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713549066; c=relaxed/simple; bh=cGDunlhXPkD3kNjzHbgRQj5xc6EJrdX03lusfZYeogw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=hwAAhimsjTqVE2UmUnSNr8dRKMWyOUJ8V7mjDTn11Ke69/lSAmQU3sPlkAWUlCJbck0QwZQFpdH8EYPOGIUJpgqFYk0NGmm+n7JBTdYGuM0QKGMOxYaYN8YVCJIOATnNb7a8WNsDkaFgTF2CI0b/aIMwN3xfZWeBycHlw8fEmZA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C1D901E030; Fri, 19 Apr 2024 13:51:01 -0400 (EDT) Message-ID: <8e024d9b-3066-42af-b665-9a48a5f2c801@simark.ca> Date: Fri, 19 Apr 2024 13:51:01 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] contrib: Add autoregen.py To: Tom Tromey , Christophe Lyon via Gdb Cc: Christophe Lyon References: <20240419090903.2080043-1-christophe.lyon@linaro.org> <87cyqlxqwc.fsf@tromey.com> Content-Language: en-US In-Reply-To: <87cyqlxqwc.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb Reply-To: Simon Marchi Errors-To: gdb-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb" On 2024-04-19 12:23, Tom Tromey wrote: >>>>>> Christophe Lyon via Gdb writes: > >> This script is a copy of the current script used by Sourceware's >> autoregen buildbots. > >> It is intended as a helper to regenerate files managed by autotools >> (autoconf, automake, aclocal, ....), as well as the toplevel >> Makefile.in which is created by autogen. > >> Other files can be updated when using maintainer-mode, but this is not >> covered by this script. > > Thanks for working on this. > >> +# these directories are known to be re-generatable with a simple autoreconf >> +# without special -I flags > > Can other directories be updated to this same standard? If not, why > not? I'm somewhat uncomfortable with the number of special cases in > this script. > > I was hoping it would be more like: > > top level -> autogen + autoconf > anywhere else with configure.{ac,in} -> autoreconf > > Tom I wrote the initial version of the autoreconf support in this script, originally it only had gdb, gdbserver and gdbsupport. But Christophe later added all the directories that currently work with a simple autoreconf. At this point, I think it would make sense to flip the logic and list only the directories that don't work with a simple autoreconf, and then work on reducing that list to 0. Simon