gdb (ARM processor) casting issues in iwmmxt.c

[shanevolpe@gmail.com]

All,
I tried compiling gdb client for the xscale processor and all works
good but for some casting issues in iwmmxt.c  Here is what I found:
There is casting occurring on the target:
 (unsigned long) s1 = a * b;
 I changed all the castings to only cast on the source and not
target.. After my modifications everything compiled fine.  Below is a
patch file with my changes.  I'm not sure if there is something I'm
missing, I have never seen casting on the target before.

Patch:
--- gdb-6.3/sim/arm/iwmmxt~old.c    2003-03-27 12:13:33.000000000 -0500
+++ gdb-6.3/sim/arm/iwmmxt.c        2006-09-18 15:26:05.000000000 -0400
@@ -2114,7 +2114,7 @@

       s = (signed long) a * (signed long) b;

-      (signed long long) t += s;
+      t += (signed long long)s;
         }
       else
         {
@@ -2130,7 +2130,7 @@
     wR [BITS (12, 15)] = 0;

   if (BIT (21))    /* Signed.  */
-    (signed long long) wR[BITS (12, 15)] += (signed long long) t;
+    wR[BITS (12, 15)] += (signed long long) t;
   else
     wR [BITS (12, 15)] += t;

@@ -2166,7 +2166,7 @@
       b = wRHALF (BITS (0, 3), i * 2);
       b = EXTEND16 (b);

-      (signed long) s1 = a * b;
+      s1 = (signed long)a * (signed long)b;

       a = wRHALF (BITS (16, 19), i * 2 + 1);
       a = EXTEND16 (a);
@@ -2174,7 +2174,7 @@
       b = wRHALF (BITS (0, 3), i * 2 + 1);
       b = EXTEND16 (b);

-      (signed long) s2 = a * b;
+      s2 = (signed long)a * (signed long)b;
         }
       else            /* Unsigned.  */
         {
@@ -2183,12 +2183,12 @@
       a = wRHALF (BITS (16, 19), i * 2);
       b = wRHALF (BITS ( 0,  3), i * 2);

-      (unsigned long) s1 = a * b;
+      s1 = (unsigned long)a *(unsigned long) b;

       a = wRHALF (BITS (16, 19), i * 2 + 1);
       b = wRHALF (BITS ( 0,  3), i * 2 + 1);

-      (signed long) s2 = a * b;
+      s2 = (signed long)a * (signed long)b;
         }

       r |= (ARMdword) ((s1 + s2) & 0xffffffff) << (i ? 32 : 0);




-- 
Registered Linux User: #293401