From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16081 invoked by alias); 4 Aug 2009 17:37:38 -0000 Received: (qmail 16070 invoked by uid 22791); 4 Aug 2009 17:37:37 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 Aug 2009 17:37:31 +0000 Received: from wpaz24.hot.corp.google.com (wpaz24.hot.corp.google.com [172.24.198.88]) by smtp-out.google.com with ESMTP id n74HbRnm023296 for ; Tue, 4 Aug 2009 18:37:28 +0100 Received: from qyk15 (qyk15.prod.google.com [10.241.83.143]) by wpaz24.hot.corp.google.com with ESMTP id n74HahvG010063 for ; Tue, 4 Aug 2009 10:37:25 -0700 Received: by qyk15 with SMTP id 15so4681457qyk.16 for ; Tue, 04 Aug 2009 10:37:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.100.9 with SMTP id w9mr1946944qcn.31.1249407444841; Tue, 04 Aug 2009 10:37:24 -0700 (PDT) In-Reply-To: <20090804145318.GA31664@caradoc.them.org> References: <20090728154001.GA19451@caradoc.them.org> <8ac60eac0907291656v13f568ebw4f3a2b9bb7c7223d@mail.gmail.com> <8ac60eac0908031749y59867374wa451d2f504483390@mail.gmail.com> <20090804145318.GA31664@caradoc.them.org> Date: Tue, 04 Aug 2009 17:37:00 -0000 Message-ID: <8ac60eac0908041037q46b447d9n7b539ab53d7ce1ea@mail.gmail.com> Subject: Re: Solibs and objfile BFD ownership From: Paul Pluzhnikov To: Paul Pluzhnikov , tromey@redhat.com, gdb@sourceware.org Content-Type: multipart/mixed; boundary=0016364ed258edf6ff0470545601 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00018.txt.bz2 --0016364ed258edf6ff0470545601 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 707 On Tue, Aug 4, 2009 at 7:53 AM, Daniel Jacobowitz wrote: > A comment somewhere about the usage of the usrdata field would be > nice. =A0I gather that NULL and 1 behave the same? Yes. I added comment to gdb_bfd_unref. Updated patch attached. Tested on Linux/x86_64 with no new failures. Daniel, could you confirm that this fixes the ARM failures? Thanks, --=20 Paul Pluzhnikov 2009-08-04 Paul Pluzhnikov * objfiles.h (OBJF_KEEPBFD): Delete. (gdb_bfd_unref): New prototype. * objfiles.c (gdb_bfd_unref): New function. (free_objfile): Call gdb_bfd_unref. * solib.c (free_so): Likewise. (symbol_add_stub): Set refcount. --0016364ed258edf6ff0470545601 Content-Type: text/plain; charset=US-ASCII; name="gdb-bfd-ownership-20090804.txt" Content-Disposition: attachment; filename="gdb-bfd-ownership-20090804.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fxywizmh0 Content-length: 5909 SW5kZXg6IG9iamZpbGVzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1Mg ZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9vYmpmaWxlcy5oLHYKcmV0cmlldmlu ZyByZXZpc2lvbiAxLjYwCmRpZmYgLXUgLXAgLXUgLXIxLjYwIG9iamZpbGVz LmgKLS0tIG9iamZpbGVzLmgJMjIgSnVsIDIwMDkgMTk6MjE6MzEgLTAwMDAJ MS42MAorKysgb2JqZmlsZXMuaAk0IEF1ZyAyMDA5IDE3OjIyOjMzIC0wMDAw CkBAIC00MTQsMTIgKzQxNCw2IEBAIHN0cnVjdCBvYmpmaWxlCiAKICNkZWZp bmUgT0JKRl9VU0VSTE9BREVECSgxIDw8IDMpCS8qIFVzZXIgbG9hZGVkICov CiAKLS8qIFRoZSBiZmQgb2YgdGhpcyBvYmpmaWxlIGlzIHVzZWQgb3V0c2lk ZSBvZiB0aGUgb2JqZmlsZSAoZS5nLiBieSBzb2xpYikuCi0gICBEbyBub3Qg dHJ5IHRvIGZyZWUgaXQuICAqLwotCi0jZGVmaW5lIE9CSkZfS0VFUEJGRAko MSA8PCA0KQkvKiBEbyBub3QgZGVsZXRlIGJmZCAqLwotCi0KIC8qIFRoZSBv YmplY3QgZmlsZSB0aGF0IHRoZSBtYWluIHN5bWJvbCB0YWJsZSB3YXMgbG9h ZGVkIGZyb20gKGUuZy4gdGhlCiAgICBhcmd1bWVudCB0byB0aGUgInN5bWJv bC1maWxlIiBvciAiZmlsZSIgY29tbWFuZCkuICAqLwogCkBAIC01MTAsNiAr NTA0LDggQEAgZXh0ZXJuIHZvaWQgc2V0X29iamZpbGVfZGF0YSAoc3RydWN0 IG9iagogCQkJICAgICAgY29uc3Qgc3RydWN0IG9iamZpbGVfZGF0YSAqZGF0 YSwgdm9pZCAqdmFsdWUpOwogZXh0ZXJuIHZvaWQgKm9iamZpbGVfZGF0YSAo c3RydWN0IG9iamZpbGUgKm9iamZpbGUsCiAJCQkgICBjb25zdCBzdHJ1Y3Qg b2JqZmlsZV9kYXRhICpkYXRhKTsKKworZXh0ZXJuIHZvaWQgZ2RiX2JmZF91 bnJlZiAoc3RydWN0IGJmZCAqYWJmZCk7CiAMCiAKIC8qIFRyYXZlcnNlIGFs bCBvYmplY3QgZmlsZXMuICBBTExfT0JKRklMRVNfU0FGRSB3b3JrcyBldmVu IGlmIHlvdSBkZWxldGUKSW5kZXg6IG9iamZpbGVzLmMKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9vYmpmaWxl cy5jLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjg4CmRpZmYgLXUgLXAgLXUg LXIxLjg4IG9iamZpbGVzLmMKLS0tIG9iamZpbGVzLmMJMjggSnVsIDIwMDkg MTY6Mzk6MDYgLTAwMDAJMS44OAorKysgb2JqZmlsZXMuYwk0IEF1ZyAyMDA5 IDE3OjIyOjMzIC0wMDAwCkBAIC00NTIsMTYgKzQ1Miw3IEBAIGZyZWVfb2Jq ZmlsZSAoc3RydWN0IG9iamZpbGUgKm9iamZpbGUpCiAgIC8qIERpc2NhcmQg YW55IGRhdGEgbW9kdWxlcyBoYXZlIGFzc29jaWF0ZWQgd2l0aCB0aGUgb2Jq ZmlsZS4gICovCiAgIG9iamZpbGVfZnJlZV9kYXRhIChvYmpmaWxlKTsKIAot ICAvKiBXZSBhbHdheXMgY2xvc2UgdGhlIGJmZCwgdW5sZXNzIHRoZSBPQkpG X0tFRVBCRkQgZmxhZyBpcyBzZXQuICAqLwotCi0gIGlmIChvYmpmaWxlLT5v YmZkICE9IE5VTEwgJiYgIShvYmpmaWxlLT5mbGFncyAmIE9CSkZfS0VFUEJG RCkpCi0gICAgewotICAgICAgY2hhciAqbmFtZSA9IGJmZF9nZXRfZmlsZW5h bWUgKG9iamZpbGUtPm9iZmQpOwotICAgICAgaWYgKCFiZmRfY2xvc2UgKG9i amZpbGUtPm9iZmQpKQotCXdhcm5pbmcgKF8oImNhbm5vdCBjbG9zZSBcIiVz XCI6ICVzIiksCi0JCSBuYW1lLCBiZmRfZXJybXNnIChiZmRfZ2V0X2Vycm9y ICgpKSk7Ci0gICAgICB4ZnJlZSAobmFtZSk7Ci0gICAgfQorICBnZGJfYmZk X3VucmVmIChvYmpmaWxlLT5vYmZkKTsKIAogICAvKiBSZW1vdmUgaXQgZnJv bSB0aGUgY2hhaW4gb2YgYWxsIG9iamZpbGVzLiAqLwogCkBAIC0xMDIwLDMg KzEwMTEsMzUgQEAgb2JqZmlsZXNfY2hhbmdlZCAodm9pZCkKIHsKICAgb2Jq ZmlsZXNfY2hhbmdlZF9wID0gMTsgIC8qIFJlYnVpbGQgc2VjdGlvbiBtYXAg bmV4dCB0aW1lIHdlIG5lZWQgaXQuICAqLwogfQorCisvKiBVbnJlZmVyZW5j ZSBhbmQgcG9zc2libHkgY2xvc2UgYWJmZC4gICovCit2b2lkCitnZGJfYmZk X3VucmVmIChzdHJ1Y3QgYmZkICphYmZkKQoreworICBpbnQgKnBfcmVmY291 bnQ7CisgIGNoYXIgKm5hbWU7CisKKyAgaWYgKGFiZmQgPT0gTlVMTCkKKyAg ICByZXR1cm47CisKKyAgcF9yZWZjb3VudCA9IGFiZmQtPnVzcmRhdGE7CisK KyAgLyogVmFsaWQgcmFuZ2UgZm9yIHBfcmVmY291bnQ6IE5VTEwgKHNpbmds ZSBvd25lciksIG9yIGEgcG9pbnRlcgorICAgICB0byBpbnQgY291bnRlciwg d2hpY2ggaGFzIGEgdmFsdWUgb2YgMSAoc2luZ2xlIG93bmVyKSBvciAyIChz aGFyZWQpLiAgKi8KKyAgZ2RiX2Fzc2VydCAocF9yZWZjb3VudCA9PSBOVUxM IHx8ICpwX3JlZmNvdW50ID09IDEgfHwgKnBfcmVmY291bnQgPT0gMik7CisK KyAgaWYgKHBfcmVmY291bnQgIT0gTlVMTCkKKyAgICB7CisgICAgICAqcF9y ZWZjb3VudCAtPSAxOworICAgICAgaWYgKCpwX3JlZmNvdW50ID4gMCkKKwly ZXR1cm47CisgICAgfQorICB4ZnJlZSAocF9yZWZjb3VudCk7CisgIGFiZmQt PnVzcmRhdGEgPSBOVUxMOyAgLyogUGFyYW5vaWEuICAqLworCisgIG5hbWUg PSBiZmRfZ2V0X2ZpbGVuYW1lIChhYmZkKTsKKyAgaWYgKCFiZmRfY2xvc2Ug KGFiZmQpKQorICAgIHdhcm5pbmcgKF8oImNhbm5vdCBjbG9zZSBcIiVzXCI6 ICVzIiksCisJICAgICBuYW1lLCBiZmRfZXJybXNnIChiZmRfZ2V0X2Vycm9y ICgpKSk7CisgIHhmcmVlIChuYW1lKTsKK30KSW5kZXg6IHNvbGliLmMKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL2dk Yi9zb2xpYi5jLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjEyMgpkaWZmIC11 IC1wIC11IC1yMS4xMjIgc29saWIuYwotLS0gc29saWIuYwkxNyBKdWwgMjAw OSAxNzowODoyMyAtMDAwMAkxLjEyMgorKysgc29saWIuYwk0IEF1ZyAyMDA5 IDE3OjIyOjMzIC0wMDAwCkBAIC00MjEsMjEgKzQyMSwxMSBAQCB2b2lkCiBm cmVlX3NvIChzdHJ1Y3Qgc29fbGlzdCAqc28pCiB7CiAgIHN0cnVjdCB0YXJn ZXRfc29fb3BzICpvcHMgPSBzb2xpYl9vcHMgKHRhcmdldF9nZGJhcmNoKTsK LSAgY2hhciAqYmZkX2ZpbGVuYW1lID0gMDsKIAogICBpZiAoc28tPnNlY3Rp b25zKQogICAgIHhmcmVlIChzby0+c2VjdGlvbnMpOwotICAgICAgCi0gIGlm IChzby0+YWJmZCkKLSAgICB7Ci0gICAgICBiZmRfZmlsZW5hbWUgPSBiZmRf Z2V0X2ZpbGVuYW1lIChzby0+YWJmZCk7Ci0gICAgICBpZiAoISBiZmRfY2xv c2UgKHNvLT5hYmZkKSkKLQl3YXJuaW5nIChfKCJjYW5ub3QgY2xvc2UgXCIl c1wiOiAlcyIpLAotCQkgYmZkX2ZpbGVuYW1lLCBiZmRfZXJybXNnIChiZmRf Z2V0X2Vycm9yICgpKSk7Ci0gICAgfQogCi0gIGlmIChiZmRfZmlsZW5hbWUp Ci0gICAgeGZyZWUgKGJmZF9maWxlbmFtZSk7CisgIGdkYl9iZmRfdW5yZWYg KHNvLT5hYmZkKTsKIAogICBvcHMtPmZyZWVfc28gKHNvKTsKIApAQCAtNDU0 LDYgKzQ0NCw3IEBAIHN0YXRpYyB2b2lkCiBzeW1ib2xfYWRkX3N0dWIgKHN0 cnVjdCBzb19saXN0ICpzbywgaW50IGZsYWdzKQogewogICBzdHJ1Y3Qgc2Vj dGlvbl9hZGRyX2luZm8gKnNhcDsKKyAgaW50ICpwX3JlZmNvdW50OwogCiAg IC8qIEhhdmUgd2UgYWxyZWFkeSBsb2FkZWQgdGhpcyBzaGFyZWQgb2JqZWN0 PyAgKi8KICAgQUxMX09CSkZJTEVTIChzby0+b2JqZmlsZSkKQEAgLTQ2NSw4 ICs0NTYsMTEgQEAgc3ltYm9sX2FkZF9zdHViIChzdHJ1Y3Qgc29fbGlzdCAq c28sIGludAogICBzYXAgPSBidWlsZF9zZWN0aW9uX2FkZHJfaW5mb19mcm9t X3NlY3Rpb25fdGFibGUgKHNvLT5zZWN0aW9ucywKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzby0+c2Vj dGlvbnNfZW5kKTsKIAotICBzby0+b2JqZmlsZSA9IHN5bWJvbF9maWxlX2Fk ZF9mcm9tX2JmZCAoc28tPmFiZmQsIGZsYWdzLAotCQkJCQkgIHNhcCwgT0JK Rl9TSEFSRUQgfCBPQkpGX0tFRVBCRkQpOworICBzby0+b2JqZmlsZSA9IHN5 bWJvbF9maWxlX2FkZF9mcm9tX2JmZCAoc28tPmFiZmQsIGZsYWdzLCBzYXAs IE9CSkZfU0hBUkVEKTsKKyAgcF9yZWZjb3VudCA9IHhtYWxsb2MgKHNpemVv ZiAoKnBfcmVmY291bnQpKTsKKyAgKnBfcmVmY291bnQgPSAyOyAgLyogQm90 aCBzb2xpYiBhbmQgb2JqZmlsZSByZWZlciB0byB0aGlzIGFiZmQuICAqLwor ICBzby0+YWJmZC0+dXNyZGF0YSA9IHBfcmVmY291bnQ7CisKICAgZnJlZV9z ZWN0aW9uX2FkZHJfaW5mbyAoc2FwKTsKIAogICByZXR1cm47Cg== --0016364ed258edf6ff0470545601--