Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Paul Pluzhnikov <ppluzhnikov@google.com>
To: Frank Middleton <f.middleton@apogeect.com>
Cc: Hui Zhu <teawater@gmail.com>, gdb@sourceware.org
Subject: Re: Experiences building and using gdb 6.8 on Solaris
Date: Thu, 30 Apr 2009 16:18:00 -0000	[thread overview]
Message-ID: <8ac60eac0904300841t1647155ar46c6337cfa5eece8@mail.gmail.com> (raw)
In-Reply-To: <49F9BB0E.4010706@apogeect.com>

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

On Thu, Apr 30, 2009 at 7:51 AM, Frank Middleton
<f.middleton@apogeect.com> wrote:

> Still seems to fail...
> elfread.c:433: internal-error: sect_index_data not initialized

I misread the exact location where it fails.
Does attached patch fix it for you?

Cheers,
-- 
Paul Pluzhnikov

[-- Attachment #2: gdb.sect_index_data.20090430.txt --]
[-- Type: text/plain, Size: 823 bytes --]

Index: elfread.c
===================================================================
RCS file: /cvs/src/src/gdb/elfread.c,v
retrieving revision 1.76
diff -u -p -u -r1.76 elfread.c
--- elfread.c	3 Jan 2009 05:57:51 -0000	1.76
+++ elfread.c	30 Apr 2009 15:03:41 -0000
@@ -427,10 +427,11 @@ elf_symtab_read (struct objfile *objfile
 			  int max_index;
 			  size_t size;
 
-			  max_index 
-			    = max (SECT_OFF_BSS (objfile),
-				   max (SECT_OFF_DATA (objfile),
-					SECT_OFF_RODATA (objfile)));
+			  max_index = SECT_OFF_BSS (objfile);
+			  if (objfile->sect_index_data > max_index)
+			    max_index = objfile->sect_index_data;
+			  if (objfile->sect_index_rodata > max_index)
+			    max_index = objfile->sect_index_rodata;
 
 			  /* max_index is the largest index we'll
 			     use into this array, so we must

  reply	other threads:[~2009-04-30 15:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-27  0:26 Frank Middleton
2009-04-27  5:25 ` Paul Pluzhnikov
2009-04-27 18:18   ` Frank Middleton
2009-04-30  0:12     ` Paul Pluzhnikov
2009-04-30  0:35       ` Frank Middleton
2009-04-30  5:44         ` Paul Pluzhnikov
2009-04-30 14:52           ` Frank Middleton
2009-04-30  8:02 ` Hui Zhu
2009-04-30 15:41   ` Frank Middleton
2009-04-30 16:18     ` Paul Pluzhnikov [this message]
2009-04-30 16:20       ` Frank Middleton
2009-04-30 16:56         ` Paul Pluzhnikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ac60eac0904300841t1647155ar46c6337cfa5eece8@mail.gmail.com \
    --to=ppluzhnikov@google.com \
    --cc=f.middleton@apogeect.com \
    --cc=gdb@sourceware.org \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox