Re: Add fullname to breakpoint output

[Jim Ingham <jingham@apple.com>]

> Hi,
>
> I wrote a patch that adds the fullname to breakpoint output.
>
> (gdb)
> -break-insert main
> ^done,bkpt={number="1",type="breakpoint",disp="keep",enabled="y",
> addr="0x080483c3",func="main",fullname="/home/bob/cvs/src/gdb/test.c",
> file="test.c",line="8",times="0"}
> (gdb)
>
> I would like confirmation on this before I go through the effort to
> fix the testsuite. There is 85 test cases to fix. I would like to know
> that there is a general consensus that this patch would be an 
> acceptable
> idea before I fix the testsuite.
>
> Thanks,
> Bob Rossi
>
>

Does it do this for both the CLI and the MI, or just the MI?

We found working on Project Builder that it was often more convenient 
to add extra info to the MI output, but not to the CLI.

In my view, the CLI should aim at minimalism, since a human being is 
scanning it and too much information would be confusing.  The MI is 
intended to be scanned by a program, so we should feel free to cram in 
whatever might be useful - within reason of course...  For this reason, 
when we found PB needed an extra bit of data which might not be so 
useful to the CLI user, we would just add it to the MI only.  This is a 
little unsatisfying in implementation, since it means you have

if (ui_out_is_mi_like (uiout))
   {

   }

scattered through non-interpreter specific code.  But this is better 
than cluttering up the CLI output for stuff that is more interesting to 
a front-end...

Jim
--
Jim Ingham                                   jingham@apple.com
Developer Tools
Apple Computer