From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EGBcOIb5i2chvBMAWB0awg (envelope-from ) for ; Sat, 18 Jan 2025 13:57:10 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=QdiDCpMr; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E39F51E100; Sat, 18 Jan 2025 13:57:10 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 977EC1E05C for ; Sat, 18 Jan 2025 13:57:10 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 331BF3858C41 for ; Sat, 18 Jan 2025 18:57:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 331BF3858C41 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=QdiDCpMr Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id A42F73858D1E for ; Sat, 18 Jan 2025 18:56:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A42F73858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A42F73858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737226585; cv=none; b=Puq+RdH5oYGCTBsBfxUmqxdpR6Ndu0GUOybm1YQLc31GZp0Cn1YCWFsrW0LhGzt8Pt7Rc88hbzPYXhv1t2RT+2yBk3IUX7G4YdRHHkSOwkTVPQL9qVCzc31Jlg5PtXCiI7l+AwEh6x8ySYVqokSV83WF1NvjV5gi8k4qMaS2C3g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737226585; c=relaxed/simple; bh=oHYaSCBeIPaKf25Jce97fkv6R3JFcuCu5L/FERZnB6c=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=hL4nMHHxrwnTjC1GW4rf7YKwfVa5WpseguHcMhbKA8ODU82pVVxfJX7mzTIyZRp0jnkgeG8bLcM9iZxOg6CKOvvBZK1T24vLJOZMqycAT0Hbmw2KmWwv57mXrqV7Tww/LIe7JLPyHdww/zNhdVxD5EJiRN7urWt8t/l4ofKiC8k= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A42F73858D1E Received: from eig-obgw-6008a.ext.cloudfilter.net ([10.0.30.227]) by cmsmtp with ESMTPS id ZChQtKbGYYpSZZDzctNOf3; Sat, 18 Jan 2025 18:56:24 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id ZDzctB4nPLkZCZDzctSi7n; Sat, 18 Jan 2025 18:56:24 +0000 X-Authority-Analysis: v=2.4 cv=ecc7faEH c=1 sm=1 tr=0 ts=678bf958 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=VdSt8ZQiCzkA:10 a=ItBw4LHWJt0A:10 a=7CQSdrXTAAAA:8 a=cd5-2nlRkCGhKDjsnZkA:9 a=NqO74GWdXPXpGKcKHaDJD/ajO6k=:19 a=a-qgeE7W1pNrGK8U0ZQC:22 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=SheGZAa10R5UOdtZryVuVSnsi1cc+eZlmdnRE0LycPo=; b=QdiDCpMr2MW6ng8t4H0a5dOnA+ BkQgdoZL1nNKdg9cTzfCjk2WC6imrpMV97bC4/p05ok5uey7hrvVvgVljxb6p3VIlE++iUAaOFvJ9 xJUTaPVlybTKT62I7vkfM+9Bf; Received: from 97-118-36-154.hlrn.qwest.net ([97.118.36.154]:49310 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1tZDzb-0018Vo-28; Sat, 18 Jan 2025 11:56:23 -0700 From: Tom Tromey To: Luis Machado Cc: Tom Tromey , Simon Marchi , , "Aktemur, Tankut Baris" Subject: Re: automated coding style tool In-Reply-To: (Luis Machado's message of "Wed, 15 Jan 2025 10:20:12 +0000") References: <86538dac-6c3a-4b9e-9de9-3906e645fa4d@redhat.com> <87y16vwbzl.fsf@tromey.com> <74c8b867-f5bb-48f7-9849-11d06e63a3d7@arm.com> <87tta2r5z2.fsf@redhat.com> <87tta1qq1i.fsf@tromey.com> <2985f4ae-33c0-4e02-8982-fa132f4d3741@simark.ca> <87msftuhd3.fsf@tromey.com> X-Attribution: Tom Date: Sat, 18 Jan 2025 11:56:22 -0700 Message-ID: <87v7uct0h5.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.36.154 X-Source-L: No X-Exim-ID: 1tZDzb-0018Vo-28 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-36-154.hlrn.qwest.net (prentzel) [97.118.36.154]:49310 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNB0y31SqpxWn0cNU3zx6iHb7tum1mKwbxm4SufWsogD7gXoOFB3cLy2MnnHwuTLYuSH+OCwNBgZumKcbwb+sfbTN82TV1LuggF4KsS3y4GCs6fjMfat AMyt2Hhv0AK7OWVCbf+xXhUGGJhxFPiZ3HixWGY/4xM8j9j1DHf8LM05CX3gK1h7K8Lhu0iFeo6YGQ== X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-bounces~public-inbox=simark.ca@sourceware.org Sender: "Gdb" >>>>> "Luis" == Luis Machado writes: >> I'm in favor of using a tool but my view is that it has to meet some >> minimal standard of usefulness. I just think clang-format does not do >> this. Luis> That's fair. But are we factoring in the amount of time spent over the years Luis> telling contributors "you forgot a space here", "two spaces after period"? Yes, of course I did. I review a lot of patches. My feeling is that formatting is occasionally an issue, particularly with newcomers, but not really a big part of review. Bad formatting can be a signal that a patch requires more attention, because experienced developers try to make their changes conform to the style of the surrounding code -- so discrepancies mean you may be dealing with someone who isn't so adept. On the other hand, I also read a lot of code. And, my view overall is that readability is far more important than ease of formatting. And, furthermore, I dislike some aspects of clang-format's output, on readability grounds. Luis> Some stuff is a bit different and some other stuff is very different. But Luis> personally I'm willing to see this automation go through and I'm fine Luis> adapting to a potentially new format, whatever that is. Me too, but within some bounds. Luis> I might've mentioned this already, but for folks that deal with Luis> multiple projects, FWIW I also deal with multiple projects. Tom