From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-43387-listarch-gdb=sources.redhat.com@sourceware.org>
Received: (qmail 7924 invoked by alias); 5 Jun 2014 22:06:13 -0000
Mailing-List: contact gdb-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb.sourceware.org>
List-Subscribe: <mailto:gdb-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-owner@sourceware.org
Received: (qmail 7832 invoked by uid 89); 5 Jun 2014 22:06:12 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: hera.aquilenet.fr
Received: from hera.aquilenet.fr (HELO hera.aquilenet.fr) (141.255.128.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Jun 2014 22:06:11 +0000
Received: from localhost (localhost [127.0.0.1])	by hera.aquilenet.fr (Postfix) with ESMTP id 1C8AF2BF1;	Fri,  6 Jun 2014 00:06:09 +0200 (CEST)
Received: from hera.aquilenet.fr ([127.0.0.1])	by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)	with ESMTP id iNT6zPZ0PRBu; Fri,  6 Jun 2014 00:06:08 +0200 (CEST)
Received: from pluto (reverse-83.fdn.fr [80.67.176.83])	by hera.aquilenet.fr (Postfix) with ESMTPSA id 7D354954;	Fri,  6 Jun 2014 00:06:08 +0200 (CEST)
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
To: Doug Evans <xdje42@gmail.com>
Cc: gdb@sourceware.org
Subject: Re: [PATCH] guile: Type-check the argument to 'history-append!'
References: <87vbsfv7t9.fsf@gnu.org>	<CAP9bCMTDLWhW-VrJ479b6-GEbifzFcmO5Oe0XhL2BmDPBHwZ=A@mail.gmail.com>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: 18 Prairial an 222 de la =?utf-8?Q?R=C3=A9volution?=
X-PGP-Key-ID: 0xEA52ECF4
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA  D15D 77DD 95E2 EA52 ECF4
X-OS: x86_64-unknown-linux-gnu
Date: Thu, 05 Jun 2014 22:06:00 -0000
In-Reply-To: <CAP9bCMTDLWhW-VrJ479b6-GEbifzFcmO5Oe0XhL2BmDPBHwZ=A@mail.gmail.com>	(Doug Evans's message of "Thu, 5 Jun 2014 09:35:08 -0700")
Message-ID: <87tx7z3tbk.fsf@gnu.org>
User-Agent: Gnus/5.130009 (Ma Gnus v0.9) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-SW-Source: 2014-06/txt/msg00022.txt.bz2

Doug Evans <xdje42@gmail.com> skribis:

> On Thu, Jun 5, 2014 at 5:50 AM, Ludovic Court=C3=A8s <ludo@gnu.org> wrote:
>> The patch below add a missing type check in =E2=80=98history-append!=E2=
=80=99 (I=E2=80=99m guilty.)
>>
>> OK to push?
>>
>> Ludo=E2=80=99.
>>
>> gdb/
>> 2014-06-05  Ludovic Court=C3=A8s  <ludo@gnu.org>
>>
>>         * guile/scm-value.c (gdbscm_history_append_x): Use
>>         'vlscm_get_value_smob_arg_unsafe' instead of
>>         'vlscm_scm_to_value'.
>>
>> gdb/testsuite/
>> 2014-06-05  Ludovic Court=C3=A8s  <ludo@gnu.org>
>>
>>         * gdb.guile/scm-value.exp (test_value_in_inferior): Add test
>>         "history-append! type error".
>
> LGTM.

Thanks, pushed.

Ludo=E2=80=99.