From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25503 invoked by alias); 23 Apr 2012 14:30:49 -0000 Received: (qmail 25455 invoked by uid 22791); 23 Apr 2012 14:30:44 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 Apr 2012 14:30:26 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3NEUP7J012648 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 23 Apr 2012 10:30:26 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q3NEUORt001262 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 23 Apr 2012 10:30:25 -0400 From: Tom Tromey To: Sergio Durigan Junior Cc: Jan Kratochvil , gdb@sourceware.org Subject: Re: Switch -Wunused-variable on? References: <20120422082240.GA21311@host2.jankratochvil.net> Date: Mon, 23 Apr 2012 14:30:00 -0000 In-Reply-To: (Sergio Durigan Junior's message of "Sun, 22 Apr 2012 17:24:32 -0300") Message-ID: <87sjfufrlr.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00182.txt.bz2 >>>>> "Sergio" == Sergio Durigan Junior writes: Jan> IIRC the counterargument for -Wunused-variable was that GDB Jan> contains various #if-compiled code where is a nightmare to get the Jan> code right with matching #if-clauses also for the variables being Jan> used by various #if-compiled code chunks. I could not find that Jan> mail now in the time I gave to it. Sergio> Yes, this is a counter-argument, and I was also thinking about it. I Sergio> don't know how people prefer to deal with this issue, but something Sergio> like: Sergio> #define USED_VAR(var) ((void) var) Sergio> Would be OK? That sort of thing obscures whether the variable later dies. I'd say that the best approach would be to make the declarations conditional in the same way that the uses are. If there are a lot of problem cases with this approach, or if it makes the code too ugly, then maybe it would be better just not to use this flag. Tom