From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id /F39HRtmM2NZBgEAWB0awg (envelope-from ) for ; Tue, 27 Sep 2022 17:07:39 -0400 Received: by simark.ca (Postfix, from userid 112) id 6EB831E112; Tue, 27 Sep 2022 17:07:39 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=YtNbNKww; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 06BBA1E0D5 for ; Tue, 27 Sep 2022 17:07:38 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0D9F73857B95 for ; Tue, 27 Sep 2022 21:07:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0D9F73857B95 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1664312857; bh=/AxeABhVfsMK5+ygUvTYuANj+GkfTcUn1yOA8HPZRZM=; h=References:To:Subject:In-reply-to:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=YtNbNKwwTMRakrVv6GjkFay1CbgmtMN/7FPaJBt2lx7D/JDHiyFsPKyqBszNg7fkF ffDmzQJxlBSyTzWT7qHDgSgvxEpJCmq3sYx2we/fnQo/o2YLQWlOL5XSyle2dmOa9X iOSf42Cq4UbpHWn8QdKkDqgIut7rYTjQK8Y5vA28= Received: from mail-oa1-x33.google.com (mail-oa1-x33.google.com [IPv6:2001:4860:4864:20::33]) by sourceware.org (Postfix) with ESMTPS id 540B83858C2F for ; Tue, 27 Sep 2022 21:07:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 540B83858C2F Received: by mail-oa1-x33.google.com with SMTP id 586e51a60fabf-1319573379eso2081212fac.0 for ; Tue, 27 Sep 2022 14:07:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:in-reply-to :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date; bh=/AxeABhVfsMK5+ygUvTYuANj+GkfTcUn1yOA8HPZRZM=; b=rWFGfRkEppiLVpWRBeS7+cGGhozIYD3DKZM75VQqCF/s1fE8sysqFHEDA602awZ3jI 8/9NVVdMETQ450/AI8FhYNVCTwYmcJqK4e0aBUJ3EiiKXkne9ZYTqLxp0Og5Ae0/0vLl vqD9jIy3/oAudmh6b25RtHR9GO/iBOqox/NW2xpHwvd3XNW+Bq61smA88Xs1VWVttzn2 1xk3FSyf1Zff/JxV8eAG6O4vSmSZ0GuEbLdl4+kZYCw00dnkRyqSo6tmTGziW68LN5p4 LhHbn5glmNXaBJNNQ3eVva/MkpL6NdvxAB4xWXa3UqRxRdTYcfHevSA0WCwwh453ho2p BnpQ== X-Gm-Message-State: ACrzQf1u6twDqsaTHdGlxC0gut4hSIjlv78AFe4tnA24Eyr0qdOatMdg jJTDoNJoXUocIMLr3GuQA2YGntqUxb07f1QF X-Google-Smtp-Source: AMsMyM4U1beGKO+ocHsE/gdJclJI0Dcpx3BzOwFk+Htom2sSKjJsQB7CrncJAkyK3ufC4CXvBFBOJg== X-Received: by 2002:a05:6870:596:b0:12d:91cd:cf36 with SMTP id m22-20020a056870059600b0012d91cdcf36mr3539870oap.84.1664312829551; Tue, 27 Sep 2022 14:07:09 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:b00c:7850:ebea:3ab6]) by smtp.gmail.com with ESMTPSA id 2-20020a4a0102000000b004762a830156sm1063136oor.32.2022.09.27.14.07.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Sep 2022 14:07:09 -0700 (PDT) References: <453759b1-1ddf-1aff-a033-6183b84a4a4d@simark.ca> <674788ed-f691-447c-206d-4a4e15347d4b@arm.com> <20220927093803.7pkbrmim2o76szem@ubuntu.lan> User-agent: mu4e 1.8.9; emacs 28.1 To: Lancelot SIX Subject: Re: Proposal: Add review tags to patch review workflow. In-reply-to: <20220927093803.7pkbrmim2o76szem@ubuntu.lan> Date: Tue, 27 Sep 2022 21:07:06 +0000 Message-ID: <87leq4edc5.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Thiago Jung Bauermann via Gdb Reply-To: Thiago Jung Bauermann Cc: gdb@sourceware.org, Joel Brobecker Errors-To: gdb-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb" Hello, Lancelot SIX via Gdb writes: > On Tue, Sep 27, 2022 at 09:39:02AM +0100, Luis Machado via Gdb wrote: >> So, in summary, I see the proposal to add tags as a way to improve a pat= ch reviewing >> system that >> is not being capable of keeping up with demand. I doubt we would need su= ch tagging if we >> had a >> proper reviewing system in place (be it gerrit, patchworks or any other). >>=20 > > Hi, > > As far as I=E2=80=AFunderstand, patchwork can see the R-b and T-b tags and > update patches metadata based on that. An up-to-date patchwork instance > is available for GDB > (https://patchwork.sourceware.org/project/gdb/list/) and old patches > have been archived. It is in a clean state if we want to try using it > (or re-try, I believe this have been tried in the past but there were > too much limitations at the time). > > If R-b and T-b tags are being adopted, patchwork sounds like a good > candidate tool to help to monitor the patches pending review/approval. > > What is still unknown to me at the moment is how much effort does it > take to keep patchwork up-to-date with events it fails to detect (like > patches merged with minor changes). I am currently experimenting > tracking patches with it (I think Simon is too). Nothing compulsory to > anyone of course. The tool is there for those who want. The pure ML > based workflow will not be impacted with this. Having Bruno's proposal > in would certainly help. FWIW I like Bruno's proposal, it would bring clarity to the patch review and approval process. And as Lancelot mentioned, it also helps people using patchwork. Carlos O'Donell mentioned at GNU Tools Cauldron that patchwork has been very helpful for him with managing glibc patches, and that he would still use it even if no one else in that community did since it helps him keep track of the review state of the patches. --=20 Thiago