From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92972 invoked by alias); 8 Feb 2017 17:12:48 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 92944 invoked by uid 89); 8 Feb 2017 17:12:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_20,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=spending, U*simon.marchi, sk:simon.m, sk:simonm X-HELO: gproxy6-pub.mail.unifiedlayer.com Received: from gproxy6-pub.mail.unifiedlayer.com (HELO gproxy6-pub.mail.unifiedlayer.com) (67.222.39.168) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Wed, 08 Feb 2017 17:12:36 +0000 Received: (qmail 1861 invoked by uid 0); 8 Feb 2017 17:12:34 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy6.mail.unifiedlayer.com with SMTP; 8 Feb 2017 17:12:34 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id iHC91u00r2f2jeq01HCCKT; Wed, 08 Feb 2017 10:12:12 -0700 X-Authority-Analysis: v=2.1 cv=WOnsABcR c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=n2v9WMKugxEA:10 a=A1XX3w7m69UaF-Cs0XUA:9 Received: from 174-16-146-181.hlrn.qwest.net ([174.16.146.181]:57360 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1cbVmr-0001RN-3t; Wed, 08 Feb 2017 10:12:09 -0700 From: Tom Tromey To: Simon Marchi Cc: gdb@sourceware.org Subject: Re: GSoC References: Date: Wed, 08 Feb 2017 17:12:00 -0000 In-Reply-To: (Simon Marchi's message of "Tue, 07 Feb 2017 16:00:06 -0500") Message-ID: <87k2907gk7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1cbVmr-0001RN-3t X-Source-Sender: 174-16-146-181.hlrn.qwest.net (pokyo) [174.16.146.181]:57360 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2017-02/txt/msg00016.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> It would be interesting to gather some feedback from those who lead Simon> this initiative in the past. Would you suggest trying to go for it Simon> again? Why, why not? I did it in the past but stopped because I wasn't spending enough time mentoring. I think it is worth doing but you have to be more organized and committed than I was. Simon> On my side, there's the output colouring support which I'd like Simon> to see become a reality some day :). I actually did this, but I didn't submit it. I got sort of mired in design choices. The first approach I took was to just hack some color stuff directly the CLI ui-out, and add a way to "set color " (I don't actually remember exactly how I spelled this, and the branch is long gone). This required some hacks to get the column computation to be correct so that wrapping wouldn't suffer. I think I just made it so the color string, whatever it was, was assumed not to take any space -- a hack since this wasn't actually enforced. This was a bit too inflexible for me so I abandoned it. The second approach I took (I still have this branch) was to let the Python layer insert an object that would replace the CLI ui-out object. Then colorizing and other reformatting -- the Python ui-out object is "MI-like" and so had access to more data -- could be done by writing some Python code. I liked this approach ok but it needed some hacks (maybe since obsoleted due to Pedro's recent work, not sure). Also I think it suffered because there was no way to get the wrap hints into the Python layer. And, finally, for something like "set color", there's no good way to implement completion because there isn't a list of the table- and column-names. This could be done by introducing enums or something like that, but at that point the patch is going to be beyond what I would want to commit to. Tom