From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17293 invoked by alias); 14 Aug 2014 19:04:50 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 17276 invoked by uid 89); 14 Aug 2014 19:04:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 14 Aug 2014 19:04:48 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7EJ4cJV022743 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Aug 2014 15:04:38 -0400 Received: from localhost ([10.15.16.190]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7EJ4axe011726 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Thu, 14 Aug 2014 15:04:37 -0400 From: Sergio Durigan Junior To: Joel Brobecker Cc: Gary Benson , Mike Frysinger , gdb@sourceware.org, Andreas Arnez Subject: Re: ChangeLogs in commit messages References: <20140814083231.GA6283@blade.nx> <6036430.RnprRWgZmF@vapier> <20140814131206.GA12746@blade.nx> <20140814132939.GH4924@adacore.com> X-URL: http://www.redhat.com Date: Thu, 14 Aug 2014 19:04:00 -0000 In-Reply-To: <20140814132939.GH4924@adacore.com> (Joel Brobecker's message of "Thu, 14 Aug 2014 06:29:39 -0700") Message-ID: <87ioluao58.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00042.txt.bz2 On Thursday, August 14 2014, Joel Brobecker wrote: > No, I strongly object to #5. The ChangeLog entries are part of > the email to be sent along with the patch to be reviewed, We had > that discussion many many years ago, and at the time, people > wanted the CL entry in the email, rather than as a diff. On Thursday, August 14 2014, Joel Brobecker wrote: > Again, I do think that having the CL entry in the commit message is > useful, and I disagree with the idea of removing it from there. > Imagine you are scanning the past changes, looking for what might > have caused a behavior change. When using "git log", having the CL > in there often helps. Being the maintainer of GDB for RHEL, and having to deal with many patches to backport, I second what Joel said. I prefer CL messages to be included in the commit message (a la option #1 in Gary's message), and I strongly prefer to have a good explanation of what the patch does in the message too. Cheers, -- Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/