From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23106 invoked by alias); 26 Jun 2002 21:45:06 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 23095 invoked from network); 26 Jun 2002 21:45:03 -0000 Received: from unknown (HELO gash2.peakpeak.com) (207.174.178.17) by sources.redhat.com with SMTP; 26 Jun 2002 21:45:03 -0000 Received: from fleche.redhat.com (ta0196.peakpeak.com [204.144.244.196]) by gash2.peakpeak.com (8.9.3/8.9.3) with ESMTP id PAA26870 for ; Wed, 26 Jun 2002 15:45:00 -0600 Received: by fleche.redhat.com (Postfix, from userid 1000) id DDAD04F80AA; Wed, 26 Jun 2002 15:57:41 -0600 (MDT) To: Gdb List Subject: bad news about add_setshow_cmd From: Tom Tromey Reply-To: tromey@redhat.com X-Attribution: Tom X-Zippy: --- I have seen the FUN --- Date: Wed, 26 Jun 2002 14:45:00 -0000 Message-ID: <87fzz9d7oq.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-06/txt/msg00274.txt.bz2 Today while testing my jumbo add_setshow_cmd patch, I finally came across this code in do_setshow_command: /* Print doc minus "show" at start. */ print_doc_line (gdb_stdout, c->doc + 5); This isn't i18n-friendly. Really fixing it requires yet another global change to add_setshow_cmd :-(. Also it seems like it will require adding a new field to the command structure to hold the translated text. Or, we could replace the customized text with something generic. This is less friendly though. Does anybody know of other lurking problems before I go ahead and make this change? My current plan is to go ahead and add the new field and new doc strings everywhere. Any other ideas or preferences? Tom