From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4293 invoked by alias); 26 Aug 2002 21:18:14 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 4286 invoked from network); 26 Aug 2002 21:18:13 -0000 Received: from unknown (HELO gash2.peakpeak.com) (207.174.178.17) by sources.redhat.com with SMTP; 26 Aug 2002 21:18:13 -0000 Received: from fleche.redhat.com (mt11.peakpeak.com [206.168.3.155] (may be forged)) by gash2.peakpeak.com (8.9.3/8.9.3) with ESMTP id PAA03167; Mon, 26 Aug 2002 15:18:10 -0600 Received: by fleche.redhat.com (Postfix, from userid 1000) id CCF4D4F80C8; Mon, 26 Aug 2002 15:15:14 -0600 (MDT) To: Gdb List Subject: build failure in TUI From: Tom Tromey Reply-To: tromey@redhat.com X-Attribution: Tom X-Zippy: Okay.. I'm going home to write the ``I HATE RUBIK's CUBE HANDBOOK FOR DEAD CAT LOVERS''.. Date: Mon, 26 Aug 2002 14:18:00 -0000 Message-ID: <87d6s5mie5.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-08/txt/msg00337.txt.bz2 I just updated and rebuilt the gdb trunk on x86 Red Hat Linux 7.3. I get this: gcc -c -g -O2 -I. -I../../src/gdb -I../../src/gdb/config -DLOCALEDIR="\"/home/tromey/gnu/baseline-gdb/install/share/locale\"" -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode -I../../src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd -I../../src/gdb/../include -I../intl -I../../src/gdb/../intl -DMI_OUT=1 -DTUI=1 -I../../src/gdb/tui -DGDBTK -DUI_OUT=1 -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitialized -Werror ../../src/gdb/tui/tuiIO.c cc1: warnings being treated as errors ../../src/gdb/tui/tuiIO.c: In function `tui_redisplay_readline': ../../src/gdb/tui/tuiIO.c:190: warning: comparison is always true due to limited range of data type ../../src/gdb/tui/tuiIO.c:193: warning: comparison is always true due to limited range of data type This causes a failure because I configure with both --enable-tui and --enable-gdb-build-warnings=,-Werror. I looked at the code a bit. I think the simplest fix may be to change the definition of CTRL_CHAR (in readline/chardefs.h) to cast its argument to `unsigned char' (and then remove the `>= 0' check). However, I don't know the policy on changing readline, so I decided not to send a patch. Tom